Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Andrew Morton <akpm@linux-foundation.org>,
        Uladzislau Rezki <urezki@gmail.com>,
        Christoph Hellwig <hch@infradead.org>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        linux-mm@kvack.org (open list:VMALLOC),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH v2] mm/vmalloc: Replace the ternary conditional operator with min()
Date:   Fri,  9 Jun 2023 17:30:57 +0800
Message-Id: <20230609093057.27777-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6VmY+lgWCxf9+t65AO0x+qlw6wcElGKJD4VpyIZ8lWJWllX/EFmwesnqeu4q?=
 =?us-ascii?Q?XaJWDLRMNOvleFvLA/TlgpwwN0089poscLA8zwfhwxeWTs7oz4Np2Y49sf0y?=
 =?us-ascii?Q?I74napPJtZmB+D22UtSmZHl2E9r5dOhA7sWjGziXnRZBOacCp5eLOf4caSF1?=
 =?us-ascii?Q?j6nwfT7Imrszk6wyTec1Qwi2vFACNWuIKwjs9mBnyaQBwMJtS+Y14JLJN1kJ?=
 =?us-ascii?Q?mk3NGKnq+AjkrndO9CKEw6uijiK20h6ss+0Nfjxpd+k5XR1eeD+fvAfcsfmL?=
 =?us-ascii?Q?VvpgiVRX6crzfhNAduUm1r8e/pqTCgvyokUjnnY3ezlfOgiVvC4zSPg03lgP?=
 =?us-ascii?Q?AsmQ1mKDvDDpMO+gisVMq4WgZu/jOksWUj7nmmqiWWjYX0YC9D2D0/Amq0VN?=
 =?us-ascii?Q?OmECnDY+NLjieMKVu8oG/AqxjqP9NJZu7rDjnTqtoDjxLmV15nezdvY2xWs4?=
 =?us-ascii?Q?7GzRLcHDmOrOYfkV1YA56zbuFy4rRBtnfJoFY2onSc9Y6KxUbuF6R72yVhFw?=
 =?us-ascii?Q?nMvDTCjRyWnAstGNy+ZTBjzt0cflniA+7bAePZqgWxFtW0+JyW7GuI5k3IDP?=
 =?us-ascii?Q?0QtUsL6jzTnb1ibf7Xfvvf2ihvqNQlH4BmJc54IYcXDqKmZ7YKJ9HV59Mt7G?=
 =?us-ascii?Q?H5S82paJB7Q0wqd8pBXPaEGflPs5i4aRNf0BBeYb4+j65RUqaXRZLkG96WaB?=
 =?us-ascii?Q?T9btJ/1gM35YRatLTAESwdxg9IiohJK0+Kb1Ul9kwBOp9aLXCHQpoi+elEA2?=
 =?us-ascii?Q?/M9TwWSq+zt1beuLMb82V19d71YHbkjS1xp7G94Pb07KUbne5XOtqjPqAefq?=
 =?us-ascii?Q?3M55Z9FJNkmdzRpY26rH0G1qlGTi6w8dRu1CvxCRYskv7jdFDoPCMVnCDYVN?=
 =?us-ascii?Q?zP0TQmUQmOi40aFqwROGrupVBXj9r96RQTABkwxLEexYuF7714vhlPSNCQ/e?=
 =?us-ascii?Q?aIcrHPs2ZInqchi3OkPIZvXsL7a45GTgeNb989hvja/MwSMfb2txUjqFpEaZ?=
 =?us-ascii?Q?6unmMnTBmp8FowvxwZFy8sYy09qpzN1vHz1dWgEkMDWmvdeRBdZW8c1M3Rfq?=
 =?us-ascii?Q?/yCokkYD4sdUujudZeai1KJ8ey9iWO88836QdmN0hCOYMYX4H3T+HFilXO/m?=
 =?us-ascii?Q?BbeqHtBE3AdkweiLll4sLl2vDklayg4Bkc0Ml2NQKNmsk5tStXJza86A6nvc?=
 =?us-ascii?Q?aG+isuG0NBwFHKY7g0qUOl4cVTXZCFfQM9Afu3KGuBkpGnIEmy3MRqOFqEg9?=
 =?us-ascii?Q?aKOOa0hG/DSICabfm781JBge99Q0HJ8Q8jI9wXK1nwE5fH74X88UGoiQxC2i?=
 =?us-ascii?Q?JpOs3wtsQebRGtczQMFHSDtljQLdTztTexZWu7Kq8M1BzSEUF+HVrfaxLOxW?=
 =?us-ascii?Q?h5axK/v2BmIgredqDLflTilJboX7ZIm8b43snduOJVESkqiYD63CvrSGJrQD?=
 =?us-ascii?Q?bNnQH+pcE5DX7Bq3c3iRP0TDEV/NxKnFpnSSEGgUBBVC5upCOpcIopa+6AEk?=
 =?us-ascii?Q?eQBAgU8MDbX1abO46XnuilGf85Ff50nByC23DJl/H51PyeyDLByCF2s84kFS?=
 =?us-ascii?Q?TAXtpeVGMIQu8N80HWR9cZZ6+AbrlLYkal46EpcP?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68c919d9-fd11-4f87-0cac-08db68cc42e5
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 09:31:11.0674
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NzSgHmS42p7So648uucqjkKFwnkGWK7CX0h3apen6WobBmJV7FX6prs63ab2HidVBKz6MjwjvV6bXE58qblGCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4540
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It would be better to replace the traditional ternary conditional
operator with min() in zero_iter

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
---
 mm/vmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 29077d61ff81..6125ed506895
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -3571,7 +3571,7 @@ static size_t zero_iter(struct iov_iter *iter, size_t count)
 	while (remains > 0) {
 		size_t num, copied;
 
-		num = remains < PAGE_SIZE ? remains : PAGE_SIZE;
+		num = min_t(size_t, remains, PAGE_SIZE);
 		copied = copy_page_to_iter_nofault(ZERO_PAGE(0), 0, num, iter);
 		remains -= copied;
 
-- 
2.39.0