Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0ee84d8a-d2c9-07d0-b738-61fc7c568444@loongson.cn>
Date:   Fri, 9 Jun 2023 19:08:23 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v4 4/4] PCI/VGA: Replace full MIT license text with SPDX
 identifier
Content-Language: en-US
To:     Jani Nikula <jani.nikula@linux.intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>
Cc:     linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
References: <20230609103321.629192-1-suijingfeng@loongson.cn>
 <20230609103321.629192-4-suijingfeng@loongson.cn> <87cz24rjgb.fsf@intel.com>
From:   Sui Jingfeng <suijingfeng@loongson.cn>
Organization: Loongson
In-Reply-To: <87cz24rjgb.fsf@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 2023/6/9 18:58, Jani Nikula wrote:
> On Fri, 09 Jun 2023, Sui Jingfeng <suijingfeng@loongson.cn> wrote:
>> Per Documentation/process/license-rules.rst, the SPDX MIT identifier is
>> equivalent to including the entire MIT license text from
>> LICENSES/preferred/MIT.
>>
>> Replace the MIT license text with the equivalent SPDX identifier.
>>
>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>> ---
>>   include/linux/vgaarb.h | 30 +-----------------------------
>>   1 file changed, 1 insertion(+), 29 deletions(-)
>>
>> diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h
>> index 6d5465f8c3f2..341245205e1c 100644
>> --- a/include/linux/vgaarb.h
>> +++ b/include/linux/vgaarb.h
>> @@ -1,32 +1,4 @@
>> -/*
>> - * The VGA aribiter manages VGA space routing and VGA resource decode to
>> - * allow multiple VGA devices to be used in a system in a safe way.
> Why is this being removed?
>
>> - *
>> - * (C) Copyright 2005 Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> - * (C) Copyright 2007 Paulo R. Zanoni <przanoni@gmail.com>
>> - * (C) Copyright 2007, 2009 Tiago Vignatti <vignatti@freedesktop.org>
> Replacing the license text with SPDX is fine, removing copyright notices
> is not.

Sorry, I'm mindless

I should keep the copyright notices(original authors) there.

I will respin this patch. Thanks for pointed out.

> BR,
> Jani.
>
>> - *
>> - * Permission is hereby granted, free of charge, to any person obtaining a
>> - * copy of this software and associated documentation files (the "Software"),
>> - * to deal in the Software without restriction, including without limitation
>> - * the rights to use, copy, modify, merge, publish, distribute, sublicense,
>> - * and/or sell copies of the Software, and to permit persons to whom the
>> - * Software is furnished to do so, subject to the following conditions:
>> - *
>> - * The above copyright notice and this permission notice (including the next
>> - * paragraph) shall be included in all copies or substantial portions of the
>> - * Software.
>> - *
>> - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>> - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>> - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
>> - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>> - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>> - * DEALINGS
>> - * IN THE SOFTWARE.
>> - *
>> - */
>> +/* SPDX-License-Identifier: MIT */
>>   
>>   #ifndef LINUX_VGA_H
>>   #define LINUX_VGA_H

-- 
Jingfeng