Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9899fa21-8ffd-eed4-2b6e-68ddcd6fd670@loongson.cn>
Date:   Fri, 9 Jun 2023 20:25:16 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v5 1/4] PCI/VGA: Use unsigned type for the io_state
 variable
Content-Language: en-US
To:     Andi Shyti <andi.shyti@linux.intel.com>
Cc:     Bjorn Helgaas <bhelgaas@google.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
References: <20230609112417.632313-1-suijingfeng@loongson.cn>
 <ZIMRpbUHcW5qGFBU@ashyti-mobl2.lan>
From:   Sui Jingfeng <suijingfeng@loongson.cn>
Organization: Loongson
In-Reply-To: <ZIMRpbUHcW5qGFBU@ashyti-mobl2.lan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 2023/6/9 19:48, Andi Shyti wrote:
> Hi Sui,
>
> On Fri, Jun 09, 2023 at 07:24:14PM +0800, Sui Jingfeng wrote:
>> The io_state variable in the vga_arb_write() function is declared with
>> unsigned int type, while the vga_str_to_iostate() function takes int *
>> type. To keep them consistent, replace the third argument of
>> vga_str_to_iostate() function with the unsigned int * type.
>>
>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks a lot.
> Andi
>
>> ---
>>   drivers/pci/vgaarb.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c
>> index 5a696078b382..c1bc6c983932 100644
>> --- a/drivers/pci/vgaarb.c
>> +++ b/drivers/pci/vgaarb.c
>> @@ -77,7 +77,7 @@ static const char *vga_iostate_to_str(unsigned int iostate)
>>   	return "none";
>>   }
>>   
>> -static int vga_str_to_iostate(char *buf, int str_size, int *io_state)
>> +static int vga_str_to_iostate(char *buf, int str_size, unsigned int *io_state)
>>   {
>>   	/* we could in theory hand out locks on IO and mem
>>   	 * separately to userspace but it can cause deadlocks */
>> -- 
>> 2.25.1

-- 
Jingfeng