Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932111AbXJOXfu (ORCPT ); Mon, 15 Oct 2007 19:35:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761663AbXJOXfh (ORCPT ); Mon, 15 Oct 2007 19:35:37 -0400 Received: from hancock.steeleye.com ([71.30.118.248]:54257 "EHLO hancock.sc.steeleye.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761425AbXJOXfg (ORCPT ); Mon, 15 Oct 2007 19:35:36 -0400 Subject: Re: [PATCH] git scsi misc include fix From: James Bottomley To: Paul Jackson Cc: Andrew Morton , Matthew Wilcox , linux-kernel@vger.kernel.org, Andrew Vasquez , linux-scsi In-Reply-To: <20071014053508.30836.69658.sendpatchset@jackhammer.engr.sgi.com> References: <20071014053508.30836.69658.sendpatchset@jackhammer.engr.sgi.com> Content-Type: text/plain Date: Mon, 15 Oct 2007 19:35:30 -0400 Message-Id: <1192491330.14524.16.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-4.fc7) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1538 Lines: 50 On Sat, 2007-10-13 at 22:35 -0700, Paul Jackson wrote: > From: Paul Jackson > > The added line in scsi_eh.h: > struct scatterlist sense_sgl; > fails to compile, with the error: > field 'sense_sgl' has incomplete type > unless scatterlist.h happens to be included > somehow already ... which it isn't always. > > So include scatterlist.h in scsi_eh.h directly. > > Signed-off-by: Paul Jackson > > --- > > This patch goes after the patch 'git-scsi-misc.patch' > > include/scsi/scsi_eh.h | 1 + > 1 file changed, 1 insertion(+) > > --- 2.6.23-mm1.orig/include/scsi/scsi_eh.h 2007-10-13 01:13:26.568876534 -0700 > +++ 2.6.23-mm1/include/scsi/scsi_eh.h 2007-10-13 01:31:32.911855338 -0700 > @@ -2,6 +2,7 @@ > #define _SCSI_SCSI_EH_H > > #include > +#include > struct scsi_device; > struct Scsi_Host; I've added linux-scsi which should be cc'd on all SCSI issues. I don't quite believe this, though. The requirement for struct scatterlist is the same before and after the gid scsi-misc patch. If the compile fails with git-scsi-misc because of a missing scatterlist include, it should also fail with vanilla 2.6.23 without the git patch ... could you see if you can find out why it doesn't? thanks, James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/