Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230527012206.133464-1-samsagax@gmail.com> <8ae3e2ad-27ff-4339-88d4-504c2f59e501@roeck-us.net>
 <CABgtM3h8DXs0swGQth=dcE3J_W8k8iejvfFgjVSm9nKbRmxHDQ@mail.gmail.com>
 <820cef00-4768-46ae-c5a5-ea7c0dff71c5@roeck-us.net> <CABgtM3h0KMsOzZZvYKZLsFXn9A81V59ygSKizoF3TTkraMWr-Q@mail.gmail.com>
 <94f78001-13df-8c39-4771-7842dc94195e@roeck-us.net>
In-Reply-To: <94f78001-13df-8c39-4771-7842dc94195e@roeck-us.net>
From:   Joaquin Aramendia <samsagax@gmail.com>
Date:   Fri, 9 Jun 2023 09:50:51 -0300
Message-ID: <CABgtM3iOyCDgDY1gj-gJ4DXaXCY41FKzy-=miz0iiT8ywjbMHg@mail.gmail.com>
Subject: Re: [PATCH] hwmon: (oxp-sensors) Add tt_toggle attribute on supported boards
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     derekjohn.clark@gmail.com, jdelvare@suse.com,
        linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

> Why don't you just attach the attribute to the platform device as I
> had suggested earlier ?

You mean I should do something like this in probe():

static int oxp_platform_probe(struct platform_device *pdev)
{
  ...

switch (board) {
    case aok_zoe_a1:
    case oxp_mini_amd_a07:
    case oxp_mini_amd_pro:
        pdev->dev.groups =3D oxp_ec_groups;
}
    hwdev =3D devm_hwmon_device_register_with_info(dev, "oxpec", NULL,
        &oxp_ec_chip_info, NULL);
...
}

Would that work? Or even be correct?
--=20
Joaqu=C3=ADn I. Aramend=C3=ADa