Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6d99ffb5-a72a-168f-858f-8fa01f7593f3@linaro.org>
Date:   Fri, 9 Jun 2023 14:44:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH V3 3/5] clk: qcom: camcc-sm8550: Add camera clock
 controller driver for SM8550
Content-Language: en-US
To:     Jagadeesh Kona <quic_jkona@quicinc.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
Cc:     Bjorn Andersson <andersson@kernel.org>,
        Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
        Vinod Koul <vkoul@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Taniya Das <quic_tdas@quicinc.com>,
        Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
        Imran Shaik <quic_imrashai@quicinc.com>,
        Ajit Pandey <quic_ajipan@quicinc.com>
References: <20230601143430.5595-1-quic_jkona@quicinc.com>
 <20230601143430.5595-4-quic_jkona@quicinc.com>
 <95bd4c66-08c6-15f3-db6c-97f820fe5517@linaro.org>
 <cf60ea04-057b-7856-3a30-775051cefa26@quicinc.com>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <cf60ea04-057b-7856-3a30-775051cefa26@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 9.06.2023 13:49, Jagadeesh Kona wrote:
> Hi Dmitry,
> 
> Thanks for your review!
> 
> On 6/1/2023 8:21 PM, Dmitry Baryshkov wrote:
>> On 01/06/2023 17:34, Jagadeesh Kona wrote:
>>> Add support for the camera clock controller for camera clients to be
>>> able to request for camcc clocks on SM8550 platform.
>>>
>>> Co-developed-by: Taniya Das <quic_tdas@quicinc.com>
>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>>> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
>>> ---
>>> Changes since V2:
>>>   - No changes
>>> Changes since V1:
>>>   - Sorted the PLL names in proper order
>>>   - Updated all PLL configurations to lower case hex
>>>   - Reused evo ops instead of adding new ops for ole pll
>>>   - Moved few clocks to separate patch to fix patch too long error
>>>
>>>   drivers/clk/qcom/Kconfig        |    7 +
>>>   drivers/clk/qcom/Makefile       |    1 +
>>>   drivers/clk/qcom/camcc-sm8550.c | 3405 +++++++++++++++++++++++++++++++
>>>   3 files changed, 3413 insertions(+)
>>>   create mode 100644 drivers/clk/qcom/camcc-sm8550.c
>>>
>>
>> [skipped]
>>
>>> +
>>> +static struct platform_driver cam_cc_sm8550_driver = {
>>> +    .probe = cam_cc_sm8550_probe,
>>> +    .driver = {
>>> +        .name = "cam_cc-sm8550",
>>> +        .of_match_table = cam_cc_sm8550_match_table,
>>> +    },
>>> +};
>>> +
>>> +static int __init cam_cc_sm8550_init(void)
>>> +{
>>> +    return platform_driver_register(&cam_cc_sm8550_driver);
>>> +}
>>> +subsys_initcall(cam_cc_sm8550_init);
>>> +
>>> +static void __exit cam_cc_sm8550_exit(void)
>>> +{
>>> +    platform_driver_unregister(&cam_cc_sm8550_driver);
>>> +}
>>> +module_exit(cam_cc_sm8550_exit);
>>
>> Please convert this to use module_platform_driver
>>
> 
> We still have to evaluate if module_platform_driver() works for us in all scenarios. We will post a cleanup patch once we conclude on module_platform_driver().
With the arm64 defconfig, CCI and CAMSS are compiled in as modules. Since
they are not boot-critical components, this will likely not change.

Konrad
> 
>>> +
>>> +MODULE_DESCRIPTION("QTI CAMCC SM8550 Driver");
>>> +MODULE_LICENSE("GPL");
>>
> 
> Thanks & Regards,
> Jagadeesh