Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 14:13:34 +0100
From:   Mark Brown <broonie@kernel.org>
To:     =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado 
        <nfraprado@collabora.com>
Cc:     kernel@collabora.com,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Chen-Yu Tsai <wenst@chromium.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] Revert "ASoC: mediatek: mt8192-mt6359: Remove " Jack"
 from Headphone pin name"
Message-ID: <57a02e71-06f7-402b-9ec8-def5020d5ea0@sirena.org.uk>
References: <20230608221050.217968-1-nfraprado@collabora.com>
 <abe6e5f5-7373-44fc-90b6-2c01b1f1e96e@sirena.org.uk>
 <ef54367a-a4f5-45af-aff1-08513c75c63c@notapiano>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="E8+wg9sr5mfw0F8n"
Content-Disposition: inline
In-Reply-To: <ef54367a-a4f5-45af-aff1-08513c75c63c@notapiano>
Precedence: bulk


--E8+wg9sr5mfw0F8n
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 09, 2023 at 09:08:47AM -0400, N=EDcolas F. R. A. Prado wrote:
> On Fri, Jun 09, 2023 at 10:39:25AM +0100, Mark Brown wrote:

> > Please submit patches using subject lines reflecting the style for the
> > subsystem, this makes it easier for people to identify relevant patches.
> > Look at what existing commits in the area you're changing are doing and
> > make sure your subject lines visually resemble what they're doing.
> > There's no need to resubmit to fix this alone.

> just for my own reference in the future, what exactly should have been do=
ne
> differently in this commit? Are the subject line and commit reference in =
the
> message generated by 'git revert' no good? Or is this message from a bot =
that
> can't handle revert commits?

Yes, what git revert generates by default are no good and you should
edit it to look like a normal commit message with a standard subject
line and standard way of referencing other commits.

--E8+wg9sr5mfw0F8n
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSDJX0ACgkQJNaLcl1U
h9BY4wf/dGzg2Cru1Lxw8y9ddzXRSKRzYVlr6E4w9UIYuIwjnMAYZBK7vSyJgd6r
Gbzug4aC6m8b04va9StPFEbF8FIlHMfhWV1Y6QDUUfbQW8Y3SXPKcCP2M8UBWzLH
8fwIxMZbPMCuuOWEMqAepvYpaC6TIj8aVbjnkhQdGaU969ZeuYN5U69QkpcwdMTj
1V4lkpFZw9bvlQelnboCzPBT4NDs0erRd0YVuST0S1RuEAFJaBnVri1BK4Dv8wYH
yauo8qrsKtx9ILr/FvS1HiWpDZpToon33JoolQprrUvKdn6PAAXWcWWhY1BUZVsG
bfvz8rHv3tufHWywiMHCIh83cxLEXA==
=DCBe
-----END PGP SIGNATURE-----

--E8+wg9sr5mfw0F8n--