Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 09:08:47 -0400
From:   =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado 
        <nfraprado@collabora.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     kernel@collabora.com,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Chen-Yu Tsai <wenst@chromium.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] Revert "ASoC: mediatek: mt8192-mt6359: Remove " Jack"
 from Headphone pin name"
Message-ID: <ef54367a-a4f5-45af-aff1-08513c75c63c@notapiano>
References: <20230608221050.217968-1-nfraprado@collabora.com>
 <abe6e5f5-7373-44fc-90b6-2c01b1f1e96e@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <abe6e5f5-7373-44fc-90b6-2c01b1f1e96e@sirena.org.uk>
Precedence: bulk

On Fri, Jun 09, 2023 at 10:39:25AM +0100, Mark Brown wrote:
> On Thu, Jun 08, 2023 at 06:10:48PM -0400, N?colas F. R. A. Prado wrote:
> > This reverts commit cbbc0ec6dea09c815f1d1ef0abaf3f2ec89ff11f. That
> > commit removed the " Jack" suffix with the reasoning that it is
> > automatically added to the name of the kcontrol created, which is true,
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
> 
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.

Hi Mark,

just for my own reference in the future, what exactly should have been done
differently in this commit? Are the subject line and commit reference in the
message generated by 'git revert' no good? Or is this message from a bot that
can't handle revert commits?

Thanks,
N?colas