Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230605125248.279921-1-brgl@bgdev.pl>
In-Reply-To: <20230605125248.279921-1-brgl@bgdev.pl>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Fri, 9 Jun 2023 07:47:14 -0600
Message-ID: <CAL_JsqKczF9yYHWjqneBv-y+Qv+O7AkX4gwVG87+aPPazKxtDw@mail.gmail.com>
Subject: Re: [PATCH] gpiolib: demote the hogging log messages to debug
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Kent Gibson <warthog618@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jun 5, 2023 at 6:53=E2=80=AFAM Bartosz Golaszewski <brgl@bgdev.pl> =
wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Drivers should be silent when they work correctly. There's no reason to
> emit info messages when GPIO lines are hogged. Demote the message to
> debug.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Suggested-by: Kent Gibson <warthog618@gmail.com>
> ---
>  drivers/gpio/gpiolib.c |  2 +-
>  drivers/of/unittest.c  | 16 ++++++++--------
>  2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index a7220e04a93e..e4515bda8915 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -4243,7 +4243,7 @@ int gpiod_hog(struct gpio_desc *desc, const char *n=
ame,
>         /* Mark GPIO as hogged so it can be identified and removed later =
*/
>         set_bit(FLAG_IS_HOGGED, &desc->flags);
>
> -       gpiod_info(desc, "hogged as %s%s\n",
> +       gpiod_dbg(desc, "hogged as %s%s\n",
>                 (dflags & GPIOD_FLAGS_BIT_DIR_OUT) ? "output" : "input",
>                 (dflags & GPIOD_FLAGS_BIT_DIR_OUT) ?
>                   (dflags & GPIOD_FLAGS_BIT_DIR_VAL) ? "/high" : "/low" :=
 "");
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 2191c0136531..0060334a98a7 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -1849,19 +1849,19 @@ static void __init of_unittest_overlay_gpio(void)
>          * driver is registered
>          */
>
> -       EXPECT_BEGIN(KERN_INFO,
> +       EXPECT_BEGIN(KERN_DEBUG,
>                      "gpio-<<int>> (line-B-input): hogged as input\n");

As debug messages are normally off, I think you can just remove these.

Rob