Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <96f6201e-8c33-a25d-7ec3-00769f67869a@amd.com>
Date:   Fri, 9 Jun 2023 10:26:54 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Cc:     yazen.ghannam@amd.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86/mce: Schedule mce_setup() on correct CPU for CPER
 decoding
Content-Language: en-US
To:     "Luck, Tony" <tony.luck@intel.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
References: <20230417162006.3292715-1-yazen.ghannam@amd.com>
 <SJ1PR11MB6083E6A167F4542AB439F09AFC9C9@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <7b316c31-ded2-d6d5-0315-dd4906ff833b@amd.com>
 <SJ1PR11MB60837EAC6B0AA28AF7D16784FC9C9@SJ1PR11MB6083.namprd11.prod.outlook.com>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <SJ1PR11MB60837EAC6B0AA28AF7D16784FC9C9@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUcySkNsckxoRko3Smd4UnJ4ckJuTks3VVkwTVJ5NlBEVEM5SzVSYTZ1Q3ZQ?=
 =?utf-8?B?TEYyVzMrNTVOMmJMRGNOdU8wQnNMTHdDcGZBMlpPV0lINlNSWnNjQjNYUjYv?=
 =?utf-8?B?REFxemhDSTBlQVk0cUhYZXVPZ3lOR0pLL1B0UHFMcWI2UzFKSEhMR3ZUU2JH?=
 =?utf-8?B?MHRiTnBZZUhwekRCdHVhZUVpRTRDQURuMGNqTDZvODVqeURkaU5uWFl3ZVYv?=
 =?utf-8?B?VUxNM3hXSFI4Ym96TnlLTC9oQ2F5dHNTMG5BNEw2OWljN21OcFk4VEZEWFoz?=
 =?utf-8?B?T0FNa0R4ZW9NSk52WGFsL1JoS3pqMUgyQmlHWlFpaTlpM21aZS81bURHUlZz?=
 =?utf-8?B?eTBtUTdPR3A0TG0yeUtCZXA4RnR4Z251QzRWL2xWWkV1ai95aEx1b3prZE9K?=
 =?utf-8?B?cks3MEVUMURDY3VKNEVnNmw2YUR6SlZEMGNUclpnOU1RVDY1d0RjbFlrOFEw?=
 =?utf-8?B?TmpuSE5LVTJCNng2SWc0Y3l5VnhTcXlnZDN3cHhxRHRveTFhRUtzMkwrV3Jq?=
 =?utf-8?B?RklobnZJMSs5WkcyZG0rVk5IYlFOYWtaWllObW1KVXlPWkswWUc1ODZXajlz?=
 =?utf-8?B?TGlMb0laVys0VXBhQ2I3VUgzdk5mYTNCbE1kMDdSMW1xM05QWXdVbGNxbkxB?=
 =?utf-8?B?TmxoWUdLbDVVamdKejk0d1dKaDNkb0VEYWtCRnRUelBiS2hpanBITTVlWDRM?=
 =?utf-8?B?MnY1SXptd1MwcXRMbGhBMDloSnBvc0hScHc1SjBXcS93WWhOSk1TNmN6NzZa?=
 =?utf-8?B?ZjdIRzRpdWduR3p0M1l6aVg4L2tuOTRGNVBSVUVtYjhGZTB2SnNkb2ZaNXJJ?=
 =?utf-8?B?ZXNVYk02MG9mWVN3OGlGbThZNkdRRENobm9BZlFHL3dOU29zYktaMERRcVh4?=
 =?utf-8?B?aDJDZmJFSnpXSzVXSDFRNnBBN3RyWWt5cXlEd0tBNU5xWnA5dExjMFdXdkVk?=
 =?utf-8?B?SEl3akVjWHVQZGk0NGNSRzd0a2hidmVtUUZjc2IrQlI3MjhRUW53anFoVjQz?=
 =?utf-8?B?OHNmakwvUDRHMnNmUkNHRGtsdmFDbTJ2QkJhbUtYUjVML05sa2FtdE9kY3pk?=
 =?utf-8?B?bnM3MlpwSU9kWlR2aWR1ZFpyMHhya0g3UEFmUU5qcHVoQVhQUURWRmJOLzF6?=
 =?utf-8?B?TGlPdTdQeUQyekxTVzBVb2UwZHE0TzNGSlR2MWx5anBMdWI5QXFTM0dDcTA3?=
 =?utf-8?B?YlNBdnZBdGpVZFZaQTVYUjM5ZU81SHR2dWxYNXNua1NFa2l5OUlNT0pXZ1Rl?=
 =?utf-8?B?QzB0dE01NEhHUVYzaC9MdytMY0UzNzVodE1OdElkVEJHS2oxd1BwU25XSzFV?=
 =?utf-8?B?aXl1OUhHR1dldFhXYUlFYWgvcWEwazBVSSttY3dXMDF6L2VYSjhlQjhRQ3Bh?=
 =?utf-8?B?SHhncXd1TmhkM1JPS2sxbEhiM2IrNUVvU20wb3VBRUJkeUt2Zk1yOGFIWlNM?=
 =?utf-8?B?REFqeWN2WTFBeXYxQmEybmZ0eHZtbFloS21PR3FRdHVHNUVpMmg4M2xXRDJy?=
 =?utf-8?B?a29iWjJvM2doYmhXekU3ZlYxT0FRUUt2YVR6WVJ5YXZBSDlidmZlcG1ONG80?=
 =?utf-8?B?VHk5UmNTZXZ1VG1Sa2hlaTRTN0U0enFrUll3Zm0rM0JST3pybXp5M2k1RXp3?=
 =?utf-8?B?SjUwRURIYWFCMDV3MDYwSm9XQzgvR3B6aWhnOWNJeHNObjZ3SG1tQUIwRnk5?=
 =?utf-8?B?VGVGcC9rOE1oZjd4ZlhSL1BvWlZEQXNucVlRaW9KZ2FlSTRmZThrRXhmWVZu?=
 =?utf-8?B?ZUt5MU00UHN6RnFTbkZmUTFXT2xpUW0vR2pjOTVGNEwyV0RUYVl0akc0N3hy?=
 =?utf-8?B?UXlCeEZOU2VHdGZrb095cGFMSEF0a04yZEgrZGpUZXNsZ1BSZG95dmROU3dn?=
 =?utf-8?B?WjJ3eWtBdDRIcDRxQlRBOXZtRTZwZW40QndndlBjRkpteHpKZmx6N3hVUk5z?=
 =?utf-8?B?TFVtRnh4Zm1sdHZmbkViWUN0N0NoU2pWS3pKMTRPWjlkQlptZFlkOTNUUXNz?=
 =?utf-8?B?d0pFM1ptTEFTSlpsb0U2Si9TOEZlY2JNWGdmZXIyd2VNeW1iRzZaN0xSYUty?=
 =?utf-8?B?Ti81K1l0dE5kSHRwbVpuRGVFQXRhTk5hREN4QmFhMlRyYzZyK3NxbTNlbVlR?=
 =?utf-8?Q?umvQQTuq9NHTegfIIpmpo1+ti?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 749a68f1-a14e-47e4-cd4d-08db68f59444
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 14:26:56.8516
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sk6cgsZf8nIvSGCbWyvYQa752X/ez3Zsq8sRpd6SPJ9h0BUU5Qg6Wifdx2+2Zzsv2bl7SLXRKB4f3QSdrUXBXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4360
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/17/23 1:39 PM, Luck, Tony wrote:
>> The function expects the data to match the "MCAX" register layout used on
>> Scalable MCA systems. CTL, STATUS, ADDR, and MISC will be at the same offsets
>> for legacy MCA and MCAX. But the rest will be different.
> 
> Ah yes. Looking at the code, rather than the patch I see that it first checks for SMCA
> and returns if it isn't on an SMCA system.
> 
>         if (!boot_cpu_has(X86_FEATURE_SMCA))
>                 return -EINVAL;
> 
>> This could be extended though, if other systems will use it.
> 
> I'll keep it in mind if Intel makes a hybrid server.
>

Hi all,

Any further comments on this?

Thanks,
Yazen