Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3f71e132-8b9b-8f54-973c-ad9403369c1a@amd.com>
Date:   Fri, 9 Jun 2023 10:54:22 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [RESEND 11/15] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move
 SYNAPTICS_DEVICE_ID into CONFIG_DRM_AMD_DC_DCN ifdef
To:     Lee Jones <lee@kernel.org>
Cc:     linux-kernel@vger.kernel.org, Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org
References: <20230609081732.3842341-1-lee@kernel.org>
 <20230609081732.3842341-12-lee@kernel.org>
Content-Language: en-US
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20230609081732.3842341-12-lee@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDBlMEFvOGs1OUZnY3ByYmlxQ1VWT3dDZE5mcXUzZHllMzhRdytab1J6dzZv?=
 =?utf-8?B?UW5BT0NOb0RUT2t3YzJnbS9XdE5CV3VpVTVVSnFQQUowenhIZkx1VmR5ZHZm?=
 =?utf-8?B?MCtOQnY1UHFqY0ZxRFpuQjhHMnU5MjZ2Qk9sbVlxVGJBVVJBb3UrN0FjQWdh?=
 =?utf-8?B?VXBnUHRINHRvU1VSWlIvM3VaaS9STGdMUGwvd1dSbmxyRzQxSit3Y2YvYzhF?=
 =?utf-8?B?T2tsKzlBeDIzUml1UTBnakE3RVpIYmxQNFIzZEJHcHBqZ1BnRm5HbTFyUlVo?=
 =?utf-8?B?SGRLaUdOc2NlTnpoZUxLcmxMMmREcGplZ3U1KzljdStYWUFvWG5xdCtmWFlr?=
 =?utf-8?B?Y1BaS0RnQ045cHZNMEorUzlyYTBRUTY1Unc1Z05sc0FBMm5LSytNMWEzY3VP?=
 =?utf-8?B?UjE3TUE5L00vQU1tNm1SWkZNZE9xSXRUNlhkSFBKS042dmtneHpFdTU2MUZt?=
 =?utf-8?B?Y2duV25KbXJ5SG53OEF6eElQTEE2NUdjbzNKdk1ha3F4MDFFSllJczNSdmhr?=
 =?utf-8?B?b1lEQ2dCZVpVQWNSUDFSYWx4bHA1ZXUrbExWcjh1OVZudDN0ZXc3d1pTdC8x?=
 =?utf-8?B?dWlmQzJ1YUpZZFo0WHJqQXlzYUF6YzZnSzdBcjhtZEtHQUN3S3czWWE0c1ZW?=
 =?utf-8?B?NXhvTnJ6RDNKMXJGUFJUNXFWS0NHc0RJZ1lIY1BiOG84ekFLYk1IMWN2M2xz?=
 =?utf-8?B?T0RIeThMVEhlOUdaMXE2allyeHJPYjhmeU1yMUVZcitDaXZWcUNjUWwwcHU0?=
 =?utf-8?B?WXQrOUtyR0JGd1YybCtadzIxcUFiV3AyeGYxSndFTzFHQ2t5N0ZvZnFOVXhY?=
 =?utf-8?B?MUtyZmg2azMwVTA5OEJLOC9tTDRpSW5CTXBWM0ZnZ0N4cDJrRy9xSHNld2hi?=
 =?utf-8?B?aWlaMWI5N04vNGorUk4wTThQMFdOWnRpY1NqaS80RWl4aDZ3SFZpc0FQWmZm?=
 =?utf-8?B?clYzTTM1ME4vbE0vWk5PRGsvdDJNRWRIK0FhQnphcjNVWUNqd3c3czgzQ3Az?=
 =?utf-8?B?RFY0cVFKa2plVFdKS09WUHB0alpxcDRzYVlPc3FYekZ1cVA2ZVFGSUlKZk1U?=
 =?utf-8?B?Y2FwaS9YOUJZRlZmZ1hYU2t6THRiYUNnZ0JYWTVsUXl5amRXbmhaZWdKanRJ?=
 =?utf-8?B?cjk1MWxFSlJ3TUxHenhIbFJYRXdJTVc3T1R0QzdiRzJrayt5OG5INDdNQytV?=
 =?utf-8?B?cDlrV0M5Z0pIL1hrM01CYm11eXg2MTRhWU9SbUsxVGxXZytKUjlFa3F1QzF5?=
 =?utf-8?B?SmhPc1pBTkVJTkorbEQ1Z2E0Z2R0L0pHMXVxYzlhWndSTnRBaTgvTFVBektI?=
 =?utf-8?B?OHBHdmRqVjVxS0NuQWQyODBybVdUM2pjM3VQTFRxNmhoWjlaQS92MDNCamhT?=
 =?utf-8?B?RzFBeEkybHE2b1NhVlZ0YVZtTkNIOFY5MG1WUWNIdnBURCtsOCs2VDVQR1hG?=
 =?utf-8?B?MXVaSVlHR25NaW40eGQvOHA1QkNjazBBdWdqVjMvNFFvZjVLZmttdU1OMVRr?=
 =?utf-8?B?YXNYMXg2QjF5ZjNoWHRPVlVuUW9XVEtIbUdtL0w4bGdWTlB0dytieVNYRTEy?=
 =?utf-8?B?bUpEcnJKY1dxSGVGZ0pZYmg4WVptcWdWMDZtTklnWUhWNHR5M3k2WTFTdnA0?=
 =?utf-8?B?eDFlNjJjSlh5ZzBHYWhpWnhPdDVPSnJjZVd4eTcvS01qZjlRdnBMMEJWcjVs?=
 =?utf-8?B?OUVPZ1pYNzZzcFZNMDNMcVZHYjdBNU4wd05sQkhzeGJDeTRFcjUyaUlCVnI1?=
 =?utf-8?B?VzhZM20rZW5DZ1k4QjVndm9iR2JHamtHRnZHT1dZNlZXb21DcFlMSXpHb1pR?=
 =?utf-8?B?TzRLbTgyV0oxRGkvYUI0VzdMeFluUkliTWxDMUFiNGhvblpIUzNIS2Zydzlz?=
 =?utf-8?B?YXNBWExRYzBUODZENjMyK3pucENHdUtCUTcvVm0xdU5QTG9MU0I4T0M0NU5X?=
 =?utf-8?B?NEQzUVhrY24yMEZIaDcwQW0reDlhaFFHdTlReExYMW1YcTkvazFWNTJSczV2?=
 =?utf-8?B?WlQzaldsaVJINll6QjYzejNwVEZyQllnR3dCVmZ0MWRLOXBSUnlnd3ArSFpV?=
 =?utf-8?B?OEpzaUZjdm4weHdsdWtsTnpTTjRMWWNYY0V5Tm56YUdVamdIcFJRTytIVWg1?=
 =?utf-8?Q?ucI9DNZMQq4V46qlA20opF4Iy?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9dde8987-5763-44bd-16b2-08db68f96bba
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 14:54:26.8480
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HKD44Gqsd4iuJwBPBVtN0F57qAKtM85dTX07HAnge0kPlfWwISLUW7hPpc/t3MgesAhG62bsumXomjzbtFZFag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6595
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/9/23 04:17, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:48:22: warning: ‘SYNAPTICS_DEVICE_ID’ defined but not used [-Wunused-const-variable=]
> 
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee@kernel.org>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index 09e056a647087..cd20cfc049969 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -44,9 +44,6 @@
>  #include "dm_helpers.h"
>  #include "ddc_service_types.h"
>  
> -/* MST Dock */
> -static const uint8_t SYNAPTICS_DEVICE_ID[] = "SYNA";
> -
>  /* dm_helpers_parse_edid_caps
>   *
>   * Parse edid caps
> @@ -702,6 +699,9 @@ static void apply_synaptics_fifo_reset_wa(struct drm_dp_aux *aux)
>  	DC_LOG_DC("Done apply_synaptics_fifo_reset_wa\n");
>  }
>  
> +/* MST Dock */
> +static const uint8_t SYNAPTICS_DEVICE_ID[] = "SYNA";
> +
>  static uint8_t write_dsc_enable_synaptics_non_virtual_dpcd_mst(
>  		struct drm_dp_aux *aux,
>  		const struct dc_stream_state *stream,