Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2237575rwd; Fri, 9 Jun 2023 08:25:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5S8uupdcetFvIrxyR3FKf0uzSajXapU8wXoFd8Qgh+kyWfC4dfp5aAT5DV5E0AqyPVcFDF X-Received: by 2002:a05:6a20:a10d:b0:111:1bd6:2723 with SMTP id q13-20020a056a20a10d00b001111bd62723mr2080404pzk.3.1686324352505; Fri, 09 Jun 2023 08:25:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686324352; cv=none; d=google.com; s=arc-20160816; b=Fwm8qhZ3gIedrrsqcIE1RntXIpH/mCw1Xjg25dfhCguKT7y8V2uTztheN0pd3bNyRl rRcIBI9pj816TC/pcItQmIDwW1n8eyIL1EMljm98Jmvo0R5X7xOAJvYUFW+liTJ8ODJ6 rmY2UWCwJk8HY91E7Dr8KLe8FW3nBxQRrzZ0GzRLl9UwY80fMtgRWcXwOC+Jrs28xBI9 rPYS770CuPwtmhd4gS0llkOupsyn+iJgoKHbYk3+XPph1maMC/nAVQSrCmasUZbB0HZw vR0c9KtOmGZnfmx2QbqNWpOCk0DrYp2PkvPQWetR9ixmMOqHDnh3+O5h5lYwEpYPSyHX CA7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=kZd+Oo92Qi7oLu3blWbTQ3tlDlTIWl9/PxVYgxXQHOI=; b=sxfrWGYYezawA6YYHFiY/FAFWadHjg9XWxM9LxzhcERsAzAXI78fEFXNM3pSa6Auyb KzGgejFXGuHa/H+NohLJXa4dH8qnulVOXs/Uqd5g9CXIZN0qpSV8uao7vNNreZjULQlF BoaGtXYfXvB76mZG7VLUejBIwMl2Ggll3aFbleVtx3b2RCHT0IdSdbuNfYFox9n3CSbp H2Hb/cAxW7EBtm2MKcqvSrtEW/AaVl63sdxahNp00Zscwv4K8MNTuYM7t8OKyc8wk5XK b4av4+Tt6AQ5XhmY1xK5zlqofxnYFThKda0f7BJGYGJhQfN0l9p2YMLMzdsXWOsOWjf5 +hfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="0C/USPda"; dkim=neutral (no key) header.i=@linutronix.de header.b="z7dh/aAF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 201-20020a6302d2000000b00524ea64ba6esi2689597pgc.530.2023.06.09.08.25.40; Fri, 09 Jun 2023 08:25:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="0C/USPda"; dkim=neutral (no key) header.i=@linutronix.de header.b="z7dh/aAF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240479AbjFIPIT (ORCPT + 99 others); Fri, 9 Jun 2023 11:08:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231295AbjFIPIR (ORCPT ); Fri, 9 Jun 2023 11:08:17 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68CDF359A for ; Fri, 9 Jun 2023 08:08:11 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1686323290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kZd+Oo92Qi7oLu3blWbTQ3tlDlTIWl9/PxVYgxXQHOI=; b=0C/USPdaOlI/XdjGaFa12TUur5NbEg1zPbJPETBRoPWbBkhjBfvI9tVmldOEjCSS7q9LuO iwj16eiU3lbaDeCSBACEfZZKqzMNwStJLF3jhOrGTNRuKZ9sbJ22Y2VZyct4FpsQ/v+mIC r8NYrzdUf6fv6YNTbh5HUtM7U+IMOnKTFkV4GiFopVvWwieImytDGfnrVh9UREkkS/FieT lvSoaUQyz1sjFRblZAWU7weFfzZCxLbM0ig611Xw8kY+urZw3W31+VnJqp+PXK2o4Svn5g HFGCBhLZ4EkcmJ2v26haM9laiYoyM8/+H3yOsPNkNuGJIb/TAMue3fI1dYCWuw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1686323290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kZd+Oo92Qi7oLu3blWbTQ3tlDlTIWl9/PxVYgxXQHOI=; b=z7dh/aAFSCLnUKSLLP9J+MtJM1Hx4b02lu7nE2aA6vUP//lNONw0E6cTuF8gy/Pr0oWzAj ynXtGzMG6m7gwMDA== To: Nikolay Borisov , x86@kernel.org Cc: linux-kernel@vger.kernel.org, mhocko@suse.com, jslaby@suse.cz, Nikolay Borisov Subject: Re: [PATCH v2 2/4] x86/entry: Rename ignore_sysret and compile it unconditionally In-Reply-To: <20230609111311.4110901-3-nik.borisov@suse.com> References: <20230609111311.4110901-1-nik.borisov@suse.com> <20230609111311.4110901-3-nik.borisov@suse.com> Date: Fri, 09 Jun 2023 17:08:09 +0200 Message-ID: <87h6rgish2.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 09 2023 at 14:13, Nikolay Borisov wrote: > Give ignore_sysret a more descriptive name as it's actually used to make > 32bit syscalls a noop and return ENOSYS, rather than doing anything > special to sysret. While at it also compile the function unconditinally > as this is going to be used in the patch disabling ia32 syscalls due to > 'ia32_disabled' parameter. ONE patch does ONE thing. Rename is ONE thing. Make it undonditional is ANOTHER thing. They are independent and especially the second one is not 'while at it'. Thanks, tglx