Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8ee2cde8-9463-a2d6-a3a4-4a298b8fef18@amd.com>
Date:   Fri, 9 Jun 2023 11:07:54 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [RESEND 11/15] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move
 SYNAPTICS_DEVICE_ID into CONFIG_DRM_AMD_DC_DCN ifdef
To:     Lee Jones <lee@kernel.org>
Cc:     Leo Li <sunpeng.li@amd.com>, David Airlie <airlied@gmail.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>,
        Harry Wentland <harry.wentland@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
References: <20230609081732.3842341-1-lee@kernel.org>
 <20230609081732.3842341-12-lee@kernel.org>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230609081732.3842341-12-lee@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEVlM2NVRlNNRExRVkxqYVlnVzB0NEZSN2Q3dytxN1JZTEE0cUJVbmZ5SnZC?=
 =?utf-8?B?NXBuZnpwMnEvaDZucU02OU4xbWtxL3doSmJZV0QzR3hGYlMyNVRuTDdvbXd2?=
 =?utf-8?B?NjQrb0NEZFFXclBjbG5Fak1NK0RzQkIwa3dkV0lqbVRTTGU1bkhQclducDNp?=
 =?utf-8?B?OGNnNndVY3NXdmFaQllNK2FVaGdxaDVRVmlZSU9tQUtvcUhnTzEreHA2REZI?=
 =?utf-8?B?U2tJcGJ1My9EWDRWcWhqaEZ3WFp2Zm9xRVRoUG42ZlNXeFo4MFVnbnBVMlJZ?=
 =?utf-8?B?d0pHRWN3aEVXRUVDTWRvckJCeUk2UzluclFFVDRScUJnMTlraHJlNDRQc0VF?=
 =?utf-8?B?TGZrK0hMOXJLUWxzejdNQ0c0YlNBSHJseTEvZm1EY2RJVkNzTkpSSThBYVZU?=
 =?utf-8?B?WFF4L0Z5a1pVd2ZiaEhlRm5iODk1TUhNcEtMcFY0WVZ3VkFKbmgxamZWL0N0?=
 =?utf-8?B?aVJ6ZkVkc3JLd21LNDdsdU9yaFNVak5kMjVhRmdETlhqMHM5cWs5YUVodW9l?=
 =?utf-8?B?cjd4TXB2bTRJR2Q5WXRoakM2bS9senlaeXJYZDh3dWw1UnpTUUJqK1BZaDYy?=
 =?utf-8?B?bHNlSmhEWFZPRnRpM0JHSUs5ZXVPZXEyUE9jU25pbHRQajVDY2pnU2RId0xv?=
 =?utf-8?B?ak80UjBVajlSaGVnbVgrOERIcG9QTk9lUEdjM0QvQURvaWxveGp3TksxWlRk?=
 =?utf-8?B?M2cvcWI1cTliU2JFS1NsOXRKdkpYN1hkRTFmeFk2dFFHYnR0cURTc2VDSVRJ?=
 =?utf-8?B?aWtXd2gyaDJOZXRUb2twbHNVTTZqakhYTVY2SjBEQkhQNy9rQ0ljb0dvSG50?=
 =?utf-8?B?NUtkVUt1cXlDVmdVZGdVODR5M3pUY0R2ZGNEOGVuT2RjcFQvb2RqZ2JHbzk3?=
 =?utf-8?B?S3AvenR3a3ZFZDBkMlpRZCtPakZna0FkNjh1SjU5MGxDblJUaHN3cmd4NmQx?=
 =?utf-8?B?eTJ5WEh0SkNvSkwvQUU3WGMvMlNKZzFUSWNKOTl4RzlNM2RSODlxVnNLSlNu?=
 =?utf-8?B?eWlVTmFVWjdia2tublJuU2FqRWIxRjFFeXloODFsa2dpUTAvWU5VaEpySng5?=
 =?utf-8?B?TitwcmVwbVJZTFZ0K2VjNXp2bDNJRGhOblhVUmZCZjRPNjJDT3N5K3hUUmQ5?=
 =?utf-8?B?aXhIMnRPWXo0U1N4ZjFOMmxsZUVlMktEYWc1ZHRicnh5dWFaVEx1RE9ZZ2lm?=
 =?utf-8?B?eVVGcThUNEp3VVRMUEFTc2VlSXJMZVNpNG9MaTl5NTVaaGhOcjg4MGZHay9a?=
 =?utf-8?B?bjdFcUwzSTVJMWhvTlZ3eW5GeXhMTzErYldndTlqMmtzcDJzWWV6RkRwbGFB?=
 =?utf-8?B?L3h3R3k2b0RHSTdPdTBNaEJBeVErMDhGQTREWlM2NkVXcFNHZWY4cFFiM3JL?=
 =?utf-8?B?R0haQ0hteE5tczhjZlljeHRrSWhQS2UrY2ptR2VzM3BRbktZaWdOSFRLNnR0?=
 =?utf-8?B?SDczNnhkWmdwYjBjK1RlUG1wNTBjNW10cGRMUXlhUDk4N1pRc0xRZU52bDFk?=
 =?utf-8?B?R2J4SnIvNnhwRGtTZmtSdXdlU21NdkVWWkc0ZjlsTzdtc2hQamxpWDZ1OXNL?=
 =?utf-8?B?Nys1emN1eGE5aStEWERUM3p5c2RQZTlNNThyUjFkcU9YOVpCYzBkTk9zaGVs?=
 =?utf-8?B?YVlrMEI3YWxxbXJqTFpPZkNnM3l0WW1mdXhvb1lpZHlIbm5zSjBzVVF4bXF2?=
 =?utf-8?B?dXEvanVSQ1RrazNKb2xWL0pzTmk4eitjaEJMQnB6bGJySlBzbmYzUFUyQi9M?=
 =?utf-8?B?RDFQWHdwU2xSOUc5NW5VMUhHMitLMnloM0J6REgzOW0wQ3Y1QjFUQjg0NmEr?=
 =?utf-8?B?a2liNGYxaWNSSzF6ZzVQNkFtQ3hhblJ3Wm1OY09oY3NXdE9mNDlwcUNZLzU0?=
 =?utf-8?B?NHgyajVmZmx6QTNhUGw0YjVINmgwN1dYK1dCSEtHWnZlV29ZeHpYWkczMXRR?=
 =?utf-8?B?VEJ4dHpPcnZrNllZWnE0alNsMzhUSHZlbFFTbjYzeExFc2wrTUE3ZlBTMjlr?=
 =?utf-8?B?S3dJeitYRW9yOVRacyt6eTUwK1BYREd1NUVoV1dRVndnMVdRcDlJL3hvNDls?=
 =?utf-8?B?bnlGNXBSNHdJY2F6cml0d0c5QytVdVEwVC9OOFFqN3hKMTdQaHUxa254Wm5L?=
 =?utf-8?Q?Wrzr6KP+ZkeUr6dxw67fkt4vD?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 431a4db9-627a-41cd-0516-08db68fb4f66
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 15:07:58.3145
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: joVOLe/D4X/rr/WWiCcNjfgDUuc/WeeFrMEfjvpUIeS+LWTGVnoIxg0GPm/QaHy3rxOR5628zx1bx7w79U9UYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9205
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/9/23 04:17, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:48:22: warning: ‘SYNAPTICS_DEVICE_ID’ defined but not used [-Wunused-const-variable=]
> 
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee@kernel.org>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index 09e056a647087..cd20cfc049969 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -44,9 +44,6 @@
>   #include "dm_helpers.h"
>   #include "ddc_service_types.h"
>   
> -/* MST Dock */
> -static const uint8_t SYNAPTICS_DEVICE_ID[] = "SYNA";
> -
>   /* dm_helpers_parse_edid_caps
>    *
>    * Parse edid caps
> @@ -702,6 +699,9 @@ static void apply_synaptics_fifo_reset_wa(struct drm_dp_aux *aux)
>   	DC_LOG_DC("Done apply_synaptics_fifo_reset_wa\n");
>   }
>   
> +/* MST Dock */
> +static const uint8_t SYNAPTICS_DEVICE_ID[] = "SYNA";
> +
>   static uint8_t write_dsc_enable_synaptics_non_virtual_dpcd_mst(
>   		struct drm_dp_aux *aux,
>   		const struct dc_stream_state *stream,
-- 
Hamza