Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22e3c25e-487b-c02f-46f3-6d2ab2be8813@linaro.org>
Date:   Fri, 9 Jun 2023 17:38:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH V2] dt-bindings: reset: convert the xlnx,zynqmp-reset.txt
 to yaml
Content-Language: en-US
To:     Piyush Mehta <piyush.mehta@amd.com>, p.zabel@pengutronix.de,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, michal.simek@amd.com, michal.simek@xilinx.com,
        nava.manne@xilinx.com
Cc:     linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, siva.durga.prasad.paladugu@amd.com,
        git@amd.com
References: <20230609110447.151235-1-piyush.mehta@amd.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230609110447.151235-1-piyush.mehta@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 09/06/2023 13:04, Piyush Mehta wrote:
> Convert the binding to DT schema format. It also updates the
> reset-controller description.
> 
> Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
> ---
> - Addressed the Krzysztof review comment:
>  - Update DT binding to fix the dt_binding_check warning.
> 

...

> diff --git a/Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml b/Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml
> new file mode 100644
> index 000000000000..a39b17599e05
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/xlnx,zynqmp-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Zynq UltraScale+ MPSoC and Versal reset binding

Drop "binding"

> +
> +maintainers:
> +  - Piyush Mehta <piyush.mehta@amd.com>
> +
> +description: |
> +  The Zynq UltraScale+ MPSoC and Versal has several different resets.
> +
> +  The PS reset subsystem is responsible for handling the external reset
> +  input to the device and that all internal reset requirements are met
> +  for the system (as a whole) and for the functional units.
> +
> +  Please also refer to reset.txt in this directory for common reset
> +  controller binding usage. Device nodes that need access to reset
> +  lines should specify them as a reset phandle in their corresponding
> +  node as specified in reset.txt.
> +
> +  For list of all valid reset indices for Zynq UltraScale+ MPSoC
> +  <dt-bindings/reset/xlnx-zynqmp-resets.h>
> +
> +  For list of all valid reset indices for Versal
> +  <dt-bindings/reset/xlnx-versal-resets.h>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - xlnx,zynqmp-reset
> +      - xlnx,versal-reset
> +
> +  "#reset-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - "#reset-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/reset/xlnx-zynqmp-resets.h>

Drop, won't be needed after removing unrelated parts.

> +
> +    firmware {

Drop

> +        zynqmp_firmware: zynqmp-firmware {

Drop, three level of indentations for that simple reset-controller...

> +            zynqmp_reset: reset-controller {
> +                compatible = "xlnx,zynqmp-reset";
> +                #reset-cells = <1>;
> +            };
> +        };
> +    };
> +
> +    /* Specifying sata reset control of devices */
> +    sata {
> +        resets = <&zynqmp_reset ZYNQMP_RESET_SATA>;
> +        reset-names = "sata_rst";
> +    };

Drop this - not related.
> +
> +...

Best regards,
Krzysztof