Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2271977rwd; Fri, 9 Jun 2023 08:56:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4QmL7tqVQVVtJEC7r+Y1Fc7vCtwCKWqGTOFk1DjNApAhP3VK/99vr4BO4pE19MrxDVlO83 X-Received: by 2002:a05:6a00:80d:b0:64c:aa98:a69f with SMTP id m13-20020a056a00080d00b0064caa98a69fmr1825256pfk.1.1686326161182; Fri, 09 Jun 2023 08:56:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686326161; cv=none; d=google.com; s=arc-20160816; b=VxIR7lLezg+lE4peFLzSmQHTlP0Qh9AgRQ5CQafQ5WOHXKHwpWG4zlzXyZVMtQm+Ry rRFk/HCL99vBNwFOjijY7hKqw8BRLXpB8Nn2mBVvRRxLE7JTy6zrnD+gMpWTHu/kJfUi bbMlgW1C/Y33ZErjWhkoZ47Z0IlCYVDXgTssTSBWM+rKQL+jiQE0nJyGb/ys9NwHNvKD la9Qo6jpylpJqylCGyD0E2dJiin23zc6g+YAvxipp0T6pouVce4EIB+cOlve4E2zMCy2 qPQG/8Oky5KUr5iiNlLmmm8ON2ThpCWsmgvP7zvCBEDIiXojnY7evakxHpKh7qBctUdK Kl0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=dlYetFzyhLMyF3NusrcGZAmOlPnFI4UTBMPTOwwT0Jo=; b=GMxt1B+7156NXZw90FYZatyzS6BNga6ESZ7fe3AXHVDn2/B66P8WiAgcfjgX1lqSS/ GsJn3vENkOF6cQuoXQ/CVqBvxA3008RFkrvvc0FydifycHt9OsV1j9dwSRz1ZgRNgYQT BGbSN3Y8cy1ThPOBKi6+Dv4zcWDuGQhfaJWUuqqT6nD+1WHNUECM38cjISn9OoF2ogeP /bFVrc6wrRfkCjukWrb+IuTs95/eXU4SRMHOPYSywvIlSu/jO8O4rwcCo8rFV4qO/RwG BdDj0h0ry9D9CYttpRO8FlG8T/gXvuvy67mpT3M+lcZlw8OScLgrICJ5Kh3InvrOWU1R LuZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q6sMLpBs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k12-20020aa79d0c000000b00625c6092a12si2682134pfp.215.2023.06.09.08.55.45; Fri, 09 Jun 2023 08:56:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q6sMLpBs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241534AbjFIPct (ORCPT + 99 others); Fri, 9 Jun 2023 11:32:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241492AbjFIPcr (ORCPT ); Fri, 9 Jun 2023 11:32:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3B0B2D7E; Fri, 9 Jun 2023 08:32:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7EFB565905; Fri, 9 Jun 2023 15:32:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4774CC433EF; Fri, 9 Jun 2023 15:32:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686324765; bh=dlYetFzyhLMyF3NusrcGZAmOlPnFI4UTBMPTOwwT0Jo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q6sMLpBsvPBcyzARdQoeTv3j/scpWnGVpxzpF7M8N075McuHpF8SqL0avX7acboOk sTLk9SLd2KIgelmXfioJwSi6jQKY5BkC5iW9JGgNjLT4qp2FZVFa42OJ43grs1QTPy Iw6fnPfqtmYb5fnD7ezMpB+iqS8jJk9uEcyiz+L4YAHSZREIoE6n9jpvIknNWpL1ML OeW2Zl0+SrwDs741OXwStxiHgsAiaj9VyNzaJF2c+motjDd8r4luiar534amWvfGZe hV6PDALEj/LFj8VEyuny/5y90mdPKlVvVXgby/gF+FsobOZ/bZPLXZXUUPfaBt6s71 u+9iLPsAoGMaA== Date: Fri, 9 Jun 2023 17:32:42 +0200 From: "wsa@kernel.org" To: Andi Shyti Cc: Robert Hancock , "michal.simek@amd.com" , "shubhraj@xilinx.com" , "marex@denx.de" , "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] i2c: xiic: Don't try to handle more interrupt events after error Message-ID: Mail-Followup-To: "wsa@kernel.org" , Andi Shyti , Robert Hancock , "michal.simek@amd.com" , "shubhraj@xilinx.com" , "marex@denx.de" , "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20230606182558.1301413-1-robert.hancock@calian.com> <20230606192453.zjzz4kt76kus5hr5@intel.intel> <20230606212053.bwpoxyost4fkpati@intel.intel> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="D5hvdBwwauKsvaEG" Content-Disposition: inline In-Reply-To: <20230606212053.bwpoxyost4fkpati@intel.intel> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --D5hvdBwwauKsvaEG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > I think the patch is correct and I will ack it: >=20 > Acked-by: Andi Shyti =20 >=20 > I think, though, that this needs a proper fix and testing, in > order to cover all the possible combinations. The scenario you > highlighted is indeed one, but not only, potential situation that > could arise. >=20 > Can I just ask you to write a bit more in the comment to=20 > highlight the possible failure? I tend to apply it to for-current because it improves the situation. Further improvements could be made incrementally? D'accord everyone? --D5hvdBwwauKsvaEG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmSDRhoACgkQFA3kzBSg KbZoTg//Qjf6/YplAMgDIXOGtvX0j5ZvkMC8lZGeyLubFKKP1Zm08Dh0fFLdS8XW OV+7j8ApDYQuWm1FHfdwncVBoq/Eo6UXcNhKxWmAU760DAmNeKzgoKFEGkqiKvcJ d//Qaxvk4o1FlwFIyPQxfsQjPwrCduYjITZlcf8JejsXLA97jeKuydyGOmQIVcJM 24tg9759PONQiscAiNkzB9oo/0nu6FjLOQF4Nlo8Ob8JavO4WLCsDGrZWMJ5Mf5a uN/ma2sjm8K4BzipWD1sfe+kStCtCM+kIQ/ozHmfXKq4phD3DD4PGt+99gJuRfML 4HMcVyYawsIIpqJgL11up0EMaQMFh3+1pNyOpdYtMKaEoYgzRecg5K/c9Q5FD1a1 AU8O2FM8QW9xxWZ8+s3nIlz8BVs1nycbeodjFw9g4/p0HfykqjpjsFlYlfb2ilK2 /psyP4gv9pjPvW4Sk0QLNrX+LrQqmVnxojT5XvasHS1MVgCQjLx9mJIvwmYpGzjW l6PvlDBq1BwDtS1gEAMwHWpiJrz69MsTQ5dmH1FqmZPG1BQq9d6Q+UWLqrq2CP/Q Y+xEGQpJ7amnIp755CQSuytNBt8bYLHMBYUdbvWUGGspmYcH2MDXTKkYRFYEyRqo Mo+XFKf66usxPdn+6Sv3wmPDvNTM/V93su8ip4oD/1oZujJyHg8= =dlC7 -----END PGP SIGNATURE----- --D5hvdBwwauKsvaEG--