Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 08:37:21 -0700
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH 2/2] x86/microcode: Add a "microcode=" command line option
Message-ID: <ZINHMRR28jre+Bw/@a4bf019067fa.jf.intel.com>
References: <20230605141332.25948-1-bp@alien8.de>
 <20230605141332.25948-2-bp@alien8.de>
 <ZIE1G9UBAT36kPhJ@a4bf019067fa.jf.intel.com>
 <20230609122828.GBZIMa7OtCIpSkYGxV@fat_crate.local>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230609122828.GBZIMa7OtCIpSkYGxV@fat_crate.local>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TggZH15zUdj2hftBE1dwTwsr8qOsJ+7mOoUZMhtJtEVf+cBJCjcqa1mHip9H?=
 =?us-ascii?Q?yXToDxE3bno+8b2FytYFn3khHfppEB15AQ958Rnx4UIuLvkbxMPhe7BdPNBy?=
 =?us-ascii?Q?6SOBPLBZZY3qjcpSclKRiiuJzumaBZz6aZ8GbRQ+SPOMEzfdvS6BxNBUX33s?=
 =?us-ascii?Q?zG4V5KpAdTLmdVK4rlkT8K4bhbd1Nmr0HU9/miM5tuIW3JqjhZOvZBJYlUPb?=
 =?us-ascii?Q?H7TCMSWbnBhhtgnnbsP+E8Q9zKeaEcQvMmuU00VOCjy7tVWWnISgw+EZqAiX?=
 =?us-ascii?Q?xViT1RjMnuaq8AMyFQjCE1tMv4VQoL8xEhJAEGiTzRxea6F0XIYL1eP92a0s?=
 =?us-ascii?Q?thkIcmwb4cwtd7EywxmqtohrdoqLkmYGHlwvE5KGEGKbg791FZzSNtkh7gjv?=
 =?us-ascii?Q?mTXCdIE2YQri5UDpN/dv+L8FgyXokpU9NeL4j0HhNneoEptTZb8SZ6ji/F0u?=
 =?us-ascii?Q?81iP9gxD2s3xO+gAXugs5J7CqnKcwbO7vXV3HAIIIIQkJ0yvHppQJABmlY/c?=
 =?us-ascii?Q?1uTaRrpiYAGBcFCka3c0b+96sBbU8Lii5DyZIm9xyahChuAX1weiiFmvyo7y?=
 =?us-ascii?Q?2Kcoi/1u70/YvvXkq/lWUjwucjktN59qkWbSihDem+JPTYaLWTvJUj7M6Euj?=
 =?us-ascii?Q?OK5p46AGtG2B7iA5ngE01SGm4gsgKfSSsa6Q6ELzjxLjy6Us7EHj1gAhmNxK?=
 =?us-ascii?Q?eznnhe4FJXEpsniS4FjatCMzY0/ESaHDT9yZt2P4qdIhPvhB50S5664UK6Fs?=
 =?us-ascii?Q?NPIHDPiRMWl/5XiJNhMAgc57+89WUuyb/KSx6nnIm8CmqFO4AK+iGzSPL3dv?=
 =?us-ascii?Q?ERy2BdLlSTzU+jSUmOS2Ix5Asw9GuhNUbB7Xripdqj5NXDbprTagewT3uc1Y?=
 =?us-ascii?Q?CBV47RyzStibEz+W6ym+/UGIzhe6VLXHx2J1U38xFK5f6Ni+RgQw5xadvt41?=
 =?us-ascii?Q?GFEAm+Gbd/kQMFx1lH+qF45ky5oLJXWWfp2iGdzmeyniUOVJIdToWzMQoqsH?=
 =?us-ascii?Q?aUj3/Y4vnKsBEqLZ43DCZU5j6vneo9Okr2wrUVApey+tefGqTHNcXsVrgPG7?=
 =?us-ascii?Q?OPMSWrGgW9k7xJYAAQKrYWHkzdoOntYc5RCD8u6s4isK6b2Lsb5QPw8gUrRk?=
 =?us-ascii?Q?yJRlvsgmMJXtmtT5V9sINYzVVwg+CupjG43EdqqCwQ+XkKdZFpLZDr/4vbVJ?=
 =?us-ascii?Q?Lf7mJrpC8dahTyLTbK+eqOUfl8DssIjiEa9n830CNJJ5egtTzEOZSymvb+MK?=
 =?us-ascii?Q?UDyw6edrZAN+pEZxTpxlDZ6OSI5jyN8AQV2zKqg6iLMK3xgVJwS4gmXVSOE9?=
 =?us-ascii?Q?FUC4tT8yTMNhlzKv0iTCYxXNPtJXS3zxRUz2EftF9UVbh9fLfu87gglGhll6?=
 =?us-ascii?Q?BK3u6eisV6Tqeiuos6rwkzBn9iXYnTaiiwmMT+quegaG9rGKLz+AJdgv7GGL?=
 =?us-ascii?Q?z7iI3166g/dshHD7wswekoGj4UL81YXm6v016PUbDaQh8Fo3u4o0nBQsmeho?=
 =?us-ascii?Q?fVGyTFMjm7fQci9qkyO4I7AFAhVdPhoISGLHBW1GntoE8TdEMtRMS7CMbTH+?=
 =?us-ascii?Q?pyUizhPRGDYenm1PbKb9eeFGiUwOWf8kjcZa92BJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a924dd7-af75-4923-94bc-08db68ff6e35
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 15:37:27.9645
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8Umj9V2EySX+OzHiq4SfrOMyV2fpul0/XDqJv5wm9AOR8GrMtkZbjveju8vEmisUKbOG4xYcJUDVumcotF+2uQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6296
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 09, 2023 at 02:28:28PM +0200, Borislav Petkov wrote:
> On Wed, Jun 07, 2023 at 06:55:39PM -0700, Ashok Raj wrote:
> > When end user changes the behavior, isn't it against the design
> > specification? And if so, should that result in kernel being tainted
> > after a reload?
> 
> That's a chicken bit and should not be used usually. I'm adding it just
> in case.

How about a debugfs opt-out instead? Say something like 

/sys/kernel/debug/microcode/debug_control?

Since the code doesn't use this in the early loading, it appears we can
drop the cmdline entirely?

> 
> > Is this reload on all threads required by all models, or only certain
> > models? I was wondering if the forced reload could be limited to only
> > affected CPUs instead of doing it on all unconditionally.
> 
> Unconditionally.

Thanks, this simplifies.

Since this is quite different from what the "typical" HT behavior w.r.t ,
microcode, maybe good to document this behavior in microcode.rst.

If the user switches the expected flow, should the code "taint" if its opted out?

> 
> > Shouldn't the "control" be under LATE_LOADING? Since this only controls
> > late-loading behavior?
> 
> No, that's a bitfield and is going to be used for other flags, if
> needed and which are not necessarily late-loading related.

My .000002c. Maybe add such sysfs control only when we really need one,
but should not include debug use.