Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 17:43:21 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Daniel Thompson <daniel.thompson@linaro.org>
cc:     Jonathan Cameron <jic23@kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Bjorn Andersson <andersson@kernel.org>,
        linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: sensor-hub: Allow multi-function sensor devices
In-Reply-To: <20230528092427.42332-1-daniel.thompson@linaro.org>
Message-ID: <nycvar.YFH.7.76.2306091742090.5716@cbobk.fhfr.pm>
References: <20230528092427.42332-1-daniel.thompson@linaro.org>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 28 May 2023, Daniel Thompson wrote:

> The Lenovo Yoga C630 has a combined keyboard and accelerometer that
> interfaces via i2c-hid. Currently this laptop either has a working
> keyboard (if CONFIG_HID_SENSOR_HUB is disabled) or a working accelerometer.
> only works on kernels. Put another way, most distro kernels enable
> CONFIG_HID_SENSOR_HUB and therefore cannot work on this device since the
> keyboard doesn't work!
> 
> Fix this by providing a richer connect mask during the probe. With this
> change both keyboard and screen orientation sensors work correctly.
> 
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>

Srinivas, are you aware of any multi-function device that this patch might 
break?

Thanks,

-- 
Jiri Kosina
SUSE Labs