Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230609070117.100507-1-jiapeng.chong@linux.alibaba.com> <ce770d0f-20b4-8040-8625-365758351998@mojatatu.com>
In-Reply-To: <ce770d0f-20b4-8040-8625-365758351998@mojatatu.com>
From:   Jamal Hadi Salim <jhs@mojatatu.com>
Date:   Fri, 9 Jun 2023 11:55:50 -0400
Message-ID: <CAM0EoMm_w5vCfdTTJrPfFCrmWOuqL1_yqCmwHFAZSDdHqVMKZg@mail.gmail.com>
Subject: Re: [PATCH] net/sched: act_pedit: Use kmemdup() to replace kmalloc + memcpy
To:     Pedro Tammela <pctammela@mojatatu.com>
Cc:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 9, 2023 at 8:30=E2=80=AFAM Pedro Tammela <pctammela@mojatatu.co=
m> wrote:
>
> On 09/06/2023 04:01, Jiapeng Chong wrote:
> > ./net/sched/act_pedit.c:245:21-28: WARNING opportunity for kmemdup.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D5478
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
> LGTM,
>
> Reviewed-by: Pedro Tammela <pctammela@mojatatu.com>

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal

> > ---
> >   net/sched/act_pedit.c | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
> > index fc945c7e4123..8c4e7fddddbf 100644
> > --- a/net/sched/act_pedit.c
> > +++ b/net/sched/act_pedit.c
> > @@ -242,14 +242,12 @@ static int tcf_pedit_init(struct net *net, struct=
 nlattr *nla,
> >       nparms->tcfp_flags =3D parm->flags;
> >       nparms->tcfp_nkeys =3D parm->nkeys;
> >
> > -     nparms->tcfp_keys =3D kmalloc(ksize, GFP_KERNEL);
> > +     nparms->tcfp_keys =3D kmemdup(parm->keys, ksize, GFP_KERNEL);
> >       if (!nparms->tcfp_keys) {
> >               ret =3D -ENOMEM;
> >               goto put_chain;
> >       }
> >
> > -     memcpy(nparms->tcfp_keys, parm->keys, ksize);
> > -
> >       for (i =3D 0; i < nparms->tcfp_nkeys; ++i) {
> >               u32 offmask =3D nparms->tcfp_keys[i].offmask;
> >               u32 cur =3D nparms->tcfp_keys[i].off;
>