Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <09cc666a-bc52-44b3-230c-26dc705c5a56@nvidia.com>
Date:   Fri, 9 Jun 2023 10:29:56 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] drm/edid: Add quirk for OSVR HDK 2.0
Content-Language: en-US
To:     Jani Nikula <jani.nikula@intel.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
References: <20230609014207.2759720-1-rcampbell@nvidia.com>
 <87y1ktqa75.fsf@intel.com>
From:   Ralph Campbell <rcampbell@nvidia.com>
In-Reply-To: <87y1ktqa75.fsf@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VU1CbS9EaFB5UmJyT1VmSy9FallTWE4xWjIrS3NIWUg1MERkS01HdnhZcjVT?=
 =?utf-8?B?ZzZxZHF0LytRUFBXSDFrNlpPUVJaYi9yU29qcVRFc3FiVXhxdmhLMERHKys4?=
 =?utf-8?B?TmlmWXhLWDcvL0RXdE93eUFiQmJ5cEtvb1Fqa2JEZVRkOEFmWGRSdmdOL1g4?=
 =?utf-8?B?S3h0Qi9uM2NDSTJGaXhieEE1Q2ZsRkR0UkN6Nit5MkNFdEE1OGhXcXNzeTdT?=
 =?utf-8?B?UEw1Ym5DcnYxa1U5dlJlSEp5T294WEp5VGVKTFhOMXdKeVZtMENCdW5CQnJq?=
 =?utf-8?B?dCt2R3RMMnhLb2d0eXZMcGpPbndnK2ZxeGF4OVpyVVdvNWdKRWJNZFRYKzE4?=
 =?utf-8?B?Q0ZybHRRZmoyQy9ja0RjNmM1aEVSNmZ5dlRldWhDKzdnKzMrTkVRTkRYdDl4?=
 =?utf-8?B?ZnlZem1qSUFkdlhDMy9FQU9ERVRXRUhXSzFzckRjZndSS2E5VmRob1k0RFVk?=
 =?utf-8?B?Y1JyZ2NhV3BacDZWeUx4ZHRzOURYenlKcGJiSC8yYXVBcUhrWU9CMDZPdmlu?=
 =?utf-8?B?UE9vMVZiajZIc2Z1bTY1MWFJb2cvd2NnVS9zN01EUFFteGE5ZTZxMWhVWGJR?=
 =?utf-8?B?WjZQcklvbTY1eXIwY2k0NjAzcEx6eFdNT1MvU2FuaFplUG5NS2k0S2pGYzkw?=
 =?utf-8?B?UkVGTTltTFZ0bS9TWlNhNkt1YjVWaHZ4cCtWZVFrWmptTGt5TkMyV2dkekFl?=
 =?utf-8?B?QktSazZqQmdkYm9qcFp0WWZyMDFYQW5iZVpwMEJkZHA3UUpESVRMU3BaeEg4?=
 =?utf-8?B?L28yU292RXpaL2tJbDlBcXZGaEFJK2kycEJ4MDB4OEZ3REJnWHJiRExFYWh1?=
 =?utf-8?B?TnU0MURwTk80N2pDSjVHT05LVmJyMkpPc2dYVnBTZ2FrMVBiNWZLTngvN2Nu?=
 =?utf-8?B?cE0yYTh5Y29Pa05uZzZHOVdRZEtOQjVjdUtTRWtBUGs3WTdaamIvNlhGSmly?=
 =?utf-8?B?S3E2UkNHK1EzTnpvdkFnUThnTU83Y2JvTmh3NHRsaytYTnRxTzZYTWdYT1lR?=
 =?utf-8?B?UlVvdXZlTk1ocXIzbU5sS1BtWmtRZ1VaY29xZ0NpOWZrYTZqMVlWU3hBeWZU?=
 =?utf-8?B?clBxT0kwRmZFQ3JCRmJXekxiYmluRXVWeXRLb0RYMTU4RitlTkJLUlBWWDdT?=
 =?utf-8?B?cEJlWmczUk50d2U3b2l6M0RpMmx6dERyc3RvVDJ4bmdvNXlnOGJjVnlVZk1P?=
 =?utf-8?B?TW9wSFlkZkFMbkkrRjdHd2NBTmxFTm14UVFpdVlrTUlLNEw4Q29OekpJbE5k?=
 =?utf-8?B?RDZxRitBMERvZ284Y1ZreUpvT0xyQXB2MjdwOEw3L1drRG9lc1lSMFNSY1FX?=
 =?utf-8?B?cHErRGZ3MnRVdzNhRlhwbCtsdEFmeExORU1USlVKUkpOMG1WdXBGb29mZnZ3?=
 =?utf-8?B?eUdGeHV6VTN5UEJWYkRnb1J0OU9kNmNjcFppd2QvNGJKaUxERGt0UENpRlZw?=
 =?utf-8?B?dHkwSUlMZ2R3TTFMVXpNVGNPNHBQdk5tMW5oQUtUVjE3ajF1SVZyWGx2K0I3?=
 =?utf-8?B?VE02OUZ3WEdVU2R2cDZLRC9vN3VVTlIrQlF3aWJCMGJRWGt2Y2R6M1F0cXpG?=
 =?utf-8?B?Wmh1akVLSnRzNzlDNndPeVhTVUg3OC9JdEtVaE84N0UxdklrQm96MUlNMDVU?=
 =?utf-8?B?dGd6TFZDVm1sQjJ6NmMrenhYdElrZDAwQTE1ek9OcnBkZTdVaUlDUUQwMmxq?=
 =?utf-8?B?cytETjUrTkNtZldoSzNONE9RbjQ1VjdWbmh4Y0JGZjJCeEM0S1ZFSFJoTFl5?=
 =?utf-8?B?THFJcUo1RFA4UGRSRUNFclJoOXlEc0lvdVl4clV3OTBEbTJXNGZBRE9pcXcx?=
 =?utf-8?B?SDRkWHJFK0wrU0x3NTVCT3RDOC9HMEJGUHBTUUh5bmJiOWNYT1gwSmpzVC9n?=
 =?utf-8?B?M1RSLzE1ZklBQVVCVDdVa1VzZUc0clAra3dHZDVncWZzMDMwdVhGa00zVjFi?=
 =?utf-8?B?Mnh4dm1NejhPZFhoc3ZUK2tHUmpXYzI1eStoczhPeGJ1UkhyZGV0ejlqL1B5?=
 =?utf-8?B?cDg2azhGbktyZldvaFVESlZWMmhackx6Mm1ZcnQzSWhpcUo5VWNiYTBlcE9B?=
 =?utf-8?B?MytjRCsvSGtjZFEyaStWalBoNTRwMHlLWmpPV2NySFFuN0gwNkpRRzI1a3Jw?=
 =?utf-8?Q?2KjXg1puAgw/x9x6IqNTd1nX7?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97fbd32b-3e82-47df-7c7c-08db690f2658
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6150.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 17:29:59.4012
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aInh310XFhprHV3bxWOU21Q1en5etRs2VCC1FKizpBslH3//DAHpv5vfStvm1C3nHchFlqW0aaYqLS5PgF7SGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5273
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/9/23 02:03, Jani Nikula wrote:
> On Thu, 08 Jun 2023, Ralph Campbell <rcampbell@nvidia.com> wrote:
>> The OSVR virtual reality headset HDK 2.0 uses a different EDID
>> vendor and device identifier than the HDK 1.1 - 1.4 headsets.
>> Add the HDK 2.0 vendor and device identifier to the quirks table so
>> that window managers do not try to display the desktop screen on the
>> headset display.
> At some point in time we requested bugs to be filed about quirks, with
> EDIDs attached, so we could look at them later, and maybe remove the
> quirks.
>
> The headset non-desktop thing started off as a quirk, but since then
> we've added both Microsoft VSDB and DisplayID primary use as ways to
> indicate this without quirks.
>
> BR,
> Jani.

If you want me to file a bug, I can do that and I have the EDID too.
Where would I file it?

I did see the DisplayID 2.0 code. This headset is no longer being
manufactured so updating the EDID is not practical.

>> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
>> Tested-by: Ralph Campbell <rcampbell@nvidia.com>
>> ---
>>   drivers/gpu/drm/drm_edid.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> I don't know how many of these VR headsets are still around but I have a
>> working one and I saw and entry for HDK 1.x so I thought it would be good
>> to add HDK 2.0.
>>
>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>> index 0454da505687..3b8cc1fe05e8 100644
>> --- a/drivers/gpu/drm/drm_edid.c
>> +++ b/drivers/gpu/drm/drm_edid.c
>> @@ -230,6 +230,7 @@ static const struct edid_quirk {
>>   
>>   	/* OSVR HDK and HDK2 VR Headsets */
>>   	EDID_QUIRK('S', 'V', 'R', 0x1019, EDID_QUIRK_NON_DESKTOP),
>> +	EDID_QUIRK('A', 'O', 'U', 0x1111, EDID_QUIRK_NON_DESKTOP),
>>   };
>>   
>>   /*