Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 13:19:24 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Catalin Marinas <catalin.marinas@arm.com>
Cc:     Donglin Peng <pengdonglin@sangfor.com.cn>, mhiramat@kernel.org,
        linux@armlinux.org.uk, mark.rutland@arm.com, will@kernel.org,
        rmk+kernel@armlinux.org.uk, palmer@dabbelt.com,
        paul.walmsley@sifive.com, aou@eecs.berkeley.edu,
        tglx@linutronix.de, dave.hansen@linux.intel.com, x86@kernel.org,
        bp@alien8.de, hpa@zytor.com, chenhuacai@kernel.org,
        zhangqing@loongson.cn, kernel@xen0n.name, mingo@redhat.com,
        peterz@infradead.org, xiehuan09@gmail.com, dinghui@sangfor.com.cn,
        huangcun@sangfor.com.cn, dolinux.peng@gmail.com,
        linux-trace-kernel@vger.kernel.org, loongarch@lists.linux.dev,
        linux-riscv@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 4/8] arm64: ftrace: Enable
 HAVE_FUNCTION_GRAPH_RETVAL
Message-ID: <20230609131924.5ff89413@gandalf.local.home>
In-Reply-To: <ZILxZ6wrYUnnxT/E@arm.com>
References: <cover.1680954589.git.pengdonglin@sangfor.com.cn>
        <c78366416ce93f704ae7000c4ee60eb4258c38f7.1680954589.git.pengdonglin@sangfor.com.cn>
        <ZILxZ6wrYUnnxT/E@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 9 Jun 2023 10:31:19 +0100
Catalin Marinas <catalin.marinas@arm.com> wrote:

> On Sat, Apr 08, 2023 at 05:42:18AM -0700, Donglin Peng wrote:
> > The previous patch ("function_graph: Support recording and printing
> > the return value of function") has laid the groundwork for the for
> > the funcgraph-retval, and this modification makes it available on
> > the ARM64 platform.
> > 
> > We introduce a new structure called fgraph_ret_regs for the ARM64
> > platform to hold return registers and the frame pointer. We then
> > fill its content in the return_to_handler and pass its address to
> > the function ftrace_return_to_handler to record the return value.
> > 
> > Reviewed-by: Mark Rutland <mark.rutland@arm.com>
> > Tested-by: Mark Rutland <mark.rutland@arm.com>
> > Signed-off-by: Donglin Peng <pengdonglin@sangfor.com.cn>  
> 
> We fully trust Mark's reviews ;) but just in case you need an official
> maintainer ack:
> 
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>

Thanks Catalin, that does help.

-- Steve