Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230522193219.1477158-1-tharvey@gateworks.com> <20230609160008.GA1132019-robh@kernel.org>
In-Reply-To: <20230609160008.GA1132019-robh@kernel.org>
From:   Tim Harvey <tharvey@gateworks.com>
Date:   Fri, 9 Jun 2023 10:36:04 -0700
Message-ID: <CAJ+vNU2w+eU=SGROpyWtkBhdqo+M4XDe9m9FecEeXT=dbEr6rw@mail.gmail.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: gateworks-gsc: remove
 unnecessary fan-controller nodes
To:     Rob Herring <robh@kernel.org>, Lee Jones <lee@kernel.org>
Cc:     linux-arm-kernel@lists.infradead.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Li Yang <leoyang.li@nxp.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Conor Dooley <conor@kernel.org>,
        Conor Dooley <conor.dooley@microchip.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 9, 2023 at 9:00=E2=80=AFAM Rob Herring <robh@kernel.org> wrote:
>
> On Mon, May 22, 2023 at 12:32:16PM -0700, Tim Harvey wrote:
> > Remove the unnecessary #address-cells and #size-cells nodes from
> > the fan-controller. These are not needed as the fan controller does not
> > have any children.
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > v2:
> >  - udpated commit log to explain why the nodes are unnessesary
> >  - added Krzysztof's rb tag
> >  - added Connor's ab tag
> > ---
> >  .../devicetree/bindings/mfd/gateworks-gsc.yaml         | 10 ----------
> >  1 file changed, 10 deletions(-)
>
> This is not going to get applied if you don't send it to Lee.

Lee,

Sorry, I missed adding you to this thread. Can you pick it up or do
you need me to re-send to the list and you?

Best Regards,

Tim

>
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b=
/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> > index acb9c54942d9..dc379f3ebf24 100644
> > --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> > @@ -122,12 +122,6 @@ patternProperties:
> >        compatible:
> >          const: gw,gsc-fan
> >
> > -      "#address-cells":
> > -        const: 1
> > -
> > -      "#size-cells":
> > -        const: 0
> > -
> >        reg:
> >          description: The fan controller base address
> >          maxItems: 1
> > @@ -135,8 +129,6 @@ patternProperties:
> >      required:
> >        - compatible
> >        - reg
> > -      - "#address-cells"
> > -      - "#size-cells"
> >
> >  required:
> >    - compatible
> > @@ -194,8 +186,6 @@ examples:
> >              };
> >
> >              fan-controller@2c {
> > -                #address-cells =3D <1>;
> > -                #size-cells =3D <0>;
> >                  compatible =3D "gw,gsc-fan";
> >                  reg =3D <0x2c>;
> >              };
> > --
> > 2.25.1
> >