Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2544658rwd; Fri, 9 Jun 2023 12:57:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5IUyYBTI0g1bBtCs+gcwVcbTHA32+ykYi7WE2ZmEwMaXu3IZaxb7EKS7+yqkO7xlvsqXQb X-Received: by 2002:a17:902:c941:b0:1ae:6947:e63b with SMTP id i1-20020a170902c94100b001ae6947e63bmr3264854pla.16.1686340621102; Fri, 09 Jun 2023 12:57:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686340621; cv=none; d=google.com; s=arc-20160816; b=u/GER1WCJfjySxzXZ1Ra50RipqIfthibJKOR46XHOtk9ZsXm7xZJA+j/uZ1P49HelR 87townP5dVNgklJHMStTkFddb5K+2vSnYB0CkD6YrJTyVH3MmjYUnrhsMyjy51X70diz 0Ud9ArHG9echhLb2Z/JqQIFz6pJ8js0+6/5W7uF4jZ832RekbYO4LdJ6er4cHG7RFSQe XQqobojnBq+XTcBHsgcHved1AQLTFu9TCUV5FLWtKDWYJyL5aNEnrh6suW7Cg1zZKdjW 9gi9SlYEmRMgAmpJiyyezI1r077RhRlseqvJp6PxTQcYeS/2bpLYKshWatPwYYMwqRIS QDBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Dyuyr/vB8znGREwNUPyMFqGY83Beo0Fhz+hCWPWv2lg=; b=r36XTgezP96Bla+3VdTmzvwDaPGK6QXyTWud+I7yZJWmlKMsMlliyzMaakbnFCzDC+ lHxQX494mkBwuR1HERWxYnqfuQdtZZkU+zTKvLxX0t9gd1kFLYboVeII5ij2NC9Bm6yi hv5xybtekMmTjO9RLM6hh9pLSlqehoQ8QL9QCZUUQIGwyYpla0REuiH2Ur6jGuMTkOA8 6STmVvkxbketlmsOP7kFQlFW7nfIbW36MlwLnt+YB++0MOrwDE3UCwe8Gc0P3hGvD2Rz Ir/Vtgd2RiFVCmkKHN9xfx7qanX7cSxVudnNu3GV2497844k4T8L/0y5BN3VLEAmgAHH /b8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k2-20020a170902c40200b001b39cb47192si33034plk.648.2023.06.09.12.56.47; Fri, 09 Jun 2023 12:57:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231609AbjFITa1 (ORCPT + 99 others); Fri, 9 Jun 2023 15:30:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231657AbjFITaZ (ORCPT ); Fri, 9 Jun 2023 15:30:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F411030FE for ; Fri, 9 Jun 2023 12:30:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8920965B55 for ; Fri, 9 Jun 2023 19:30:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42C24C433D2; Fri, 9 Jun 2023 19:30:22 +0000 (UTC) From: Catalin Marinas To: linux-kernel@vger.kernel.org, Baoquan He Cc: Will Deacon , horms@kernel.org, thunder.leizhen@huawei.com, John.p.donnelly@oracle.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 0/2] arm64: kdump: simplify the reservation behaviour of crashkernel=,high Date: Fri, 9 Jun 2023 20:30:19 +0100 Message-Id: <168633894002.3180904.11323833556978641615.b4-ty@arm.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230515060259.830662-1-bhe@redhat.com> References: <20230515060259.830662-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 May 2023 14:02:57 +0800, Baoquan He wrote: > In v5 patch, Catalin helped review and acked the patch. However, an > uninitialized local varilable is warned out by static checker when Will > tried to merge the patch. And Will complained the code flow in > reserve_crashkernel() is hard to follow, required to refactor. While > when I tried to do the refactory, I feel it's not easy, the existing > several cases causes that. > > [...] Applied to arm64 (for-next/kdump). I reworte some of the paragraphs in the documentation patch, removed some sentences to make it easier to read (some details were pretty obvious). Please have a look, if you think I missed something important, just send a patch on top. Thanks. [1/2] arm64: kdump: simplify the reservation behaviour of crashkernel=,high https://git.kernel.org/arm64/c/6c4dcaddbd36 [2/2] Documentation: add kdump.rst to present crashkernel reservation on arm64 https://git.kernel.org/arm64/c/03dc0e05407f -- Catalin