Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2629007rwd; Fri, 9 Jun 2023 14:24:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5q9TKyE5P6fzIuRV8wQBBhiyoM5NCxAvqBL5OHNmfFyJWeAKG3XM+Zkw1JzGpgSiycBdGX X-Received: by 2002:a05:6a00:3a29:b0:662:f0d0:a77d with SMTP id fj41-20020a056a003a2900b00662f0d0a77dmr2232847pfb.30.1686345892855; Fri, 09 Jun 2023 14:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686345892; cv=none; d=google.com; s=arc-20160816; b=rYPK3UtrCBdREn+xNpe8E7ZTOkOMwoblGoyiinKqZv150SvvVKEVsDygcx60W02kvb qI58V3uVzFlqHTplbR5e3OXEZroPw7zdZbzIFLgfqlmEFXGxW7XXs3u+yKTqLuopb+Xh W/h1RozxYNCAnrauARSZkwyDiHE3CXrdvDq2db9E1puPsiR8V2H+nvd6Pl9Rk59pdi1G DzZ+Fm2Q5MwUwQj0CfIxhBXU2s+p//2e5ciqT6KatGeBMS58HcXxzgIhQ9da6ZXkaIuU ZDvCrSK7rrv9BMQiQbB9lLt8Z5jcSkc70dK5Kbco6zwMW3xntufNmPZm0nEAXIxyyVlQ mxSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :feedback-id:references:in-reply-to:message-id:subject:cc:from:to :dkim-signature:date; bh=He8yZMV2kI8DEJFeHkiOpD6I4kpbWyGVezca/gfNczU=; b=eH2NbqSVb/oTRMSVji3T4Ot0crOO7wowJPO2kocw2bQtS0SwqlG+E3YGi+F072NVFc S0YN8YqiTAHJ/QfPjPX20LlblIQiWoIPzbm11i+hjKeu0I7Dhan7cwZb0LjW5gC05ftD HxgAMY7WNfutfYNM0z/FzMa8Ps25V6W+wx8tt3odgs6e6XnGpZNAcq3blQmWhOeB4bqe IM9bCHPj2tsc7nXR9Miho8T8FulM0FcYjhrxGpmapqaclkuh7+G1KBQrBZft+6JFaU65 lNE/Irv6XR8f+uUIcTl605QTWKqjoQHBeE+P20y/sx0f1xCUIUrYgQ2dWtKfcoXDMqqY nqpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=ZnXS7fHE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h6-20020a056a00000600b006430bec8238si2906589pfk.328.2023.06.09.14.24.41; Fri, 09 Jun 2023 14:24:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=ZnXS7fHE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231675AbjFIUwy (ORCPT + 99 others); Fri, 9 Jun 2023 16:52:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbjFIUwx (ORCPT ); Fri, 9 Jun 2023 16:52:53 -0400 Received: from mail-40140.protonmail.ch (mail-40140.protonmail.ch [185.70.40.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8921C2D74 for ; Fri, 9 Jun 2023 13:52:52 -0700 (PDT) Date: Fri, 09 Jun 2023 20:52:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1686343970; x=1686603170; bh=He8yZMV2kI8DEJFeHkiOpD6I4kpbWyGVezca/gfNczU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ZnXS7fHEsgjdPBDSqfMRmtKVAKvHqYiJOovmcJinFKhD+Qe881bRtyJ2yx9rGl4xE doy99lYaqjtNQzsyll1qciZtgHDfIeL7o6kyxtrqMyjSmePiPK8eX7D9pMCD9C8XEc kIhuGElfd4EK025NFCweSwgmW7XvbZQ6tbHsKG9RL9WZGJrvct9yfMb7poq0s0P//t piYx408ZmpvOYIuRSqLwHKRNyCwD9Iazhfu3o3zYK/zHZpItX+IdI+xZrm3514rsCY OgWOFzqr3O0YpzbMPVA9j8FqUH+jDH7oF8fJ8GAfNEyd2WIqhq41nhK1uhZQbjlLpQ XbmLZDaGv2Kbg== To: broonie@kernel.org From: Raymond Hackley Cc: davem@davemloft.net, devicetree@vger.kernel.org, edumazet@google.com, jk@codeconstruct.com.au, krzysztof.kozlowski@linaro.org, kuba@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, michael@walle.cc, netdev@vger.kernel.org, pabeni@redhat.com, raymondhackley@protonmail.com, robh+dt@kernel.org, u.kleine-koenig@pengutronix.de Subject: Re: [PATCH v2 2/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply Message-ID: <20230609205227.105306-1-raymondhackley@protonmail.com> In-Reply-To: References: <20230609154033.3511-1-raymondhackley@protonmail.com> <20230609154200.3620-1-raymondhackley@protonmail.com> <20230609173935.84424-1-raymondhackley@protonmail.com> <7ad5d027-9b15-f59e-aa76-17e498cb7aba@linaro.org> Feedback-ID: 49437091:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On Friday, June 9th, 2023 at 7:34 PM, Mark Brown wrote= : =20 > Specifically your driver should only ever call regulator_disable() to > balance out regulator_enable() calls it made itself and it should know > how many of those it has done. regulator_is_enabled() should only ever > be used during probe if for some reason it is important to figure out if > the device is already powered for startup, this should be very unusual. > If something else enabled the regualtor then whatever did that needs to > undo those enables, not another driver. Thnak you for explanation. I should drop regulator_is_enabled() here since it's misused. Regards, Raymond