Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <30ff8a49-d3ab-63b7-1c9d-fbbea7a4b565@amd.com>
Date:   Fri, 9 Jun 2023 17:42:21 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] cpufreq: amd-pstate: Set default governor to schedutil
Content-Language: en-US
To:     Mario Limonciello <mario.limonciello@amd.com>, rafael@kernel.org
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        perry.yuan@amd.com, Ray.Huang@amd.com, Wyes.Karny@amd.com,
        gautham.shenoy@amd.com
References: <20230608095358.30548-1-mario.limonciello@amd.com>
From:   Leo Li <sunpeng.li@amd.com>
In-Reply-To: <20230608095358.30548-1-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1ZXdkNNVmp6Zi9FbFlTdkhVOURzR3AyNFJmN2ZEK3l2UWNSVUl0ZGw2OUow?=
 =?utf-8?B?SnhRNEtuYWFnYzBKSktZK0NUUWhBd25renplMHhWSXk5RjQrQWJNcUVCSHZj?=
 =?utf-8?B?SnRGSzAvcVJyNTdoNGo1VDNicWxlL2MzQjB1OWJiOE1GdUJreFlnUUxkRVhx?=
 =?utf-8?B?TDY4MDBIaTBkUlp6RWNyVG4rYklvNytxMjZQc0hKWDFhYWxOT3Yxb2FPZG5D?=
 =?utf-8?B?dnhKZVplenRhbGxFcVRMYThqZ0ZHMHJRcXc0RExvYUs4TzZYU0ZkRmJQdzBJ?=
 =?utf-8?B?QWhsbGtWWTlmY1lkbWpycThSNU1iSXcyN0dtYzR0WFNGZDQrUkhjWjJoWll4?=
 =?utf-8?B?cnF4Ymd5SXFPa21lU0FFdWNFSnkxMjF6SEU3ajdrZnRYU1dPaVJNeHZEMjlj?=
 =?utf-8?B?NWsxazI0M2ZvVzFHMjI5M1cwZnV5TFJWY3FwM1E2Um5vUngrQ0xOdWhtZ2hs?=
 =?utf-8?B?c0gxbkhIVlZLQnBTYjhEU3poOUd5KzJHVCtxUnlUdkt3a3o2NjNOVm90eEQw?=
 =?utf-8?B?Z0NpRDZ6dWdiNzViZGxCZlVOME5tWTVJWHNOQkdjOU9HR3lsTU9jWUxRanF2?=
 =?utf-8?B?a1BtOEgzcGF3cE1MK0xKVnp0TVBTMy9BVlp4TWh5R1JneWYxSEFORVNUVWY2?=
 =?utf-8?B?UThMMkxYb1JVMUdRSWtFL1lCb0Y4V0kwTkJzelIwM3JHcGxKQ2NJNHNOVlgy?=
 =?utf-8?B?MUdrMmtSSUxyank3UFpOdnlGeVg4MmVDa3dmcVMzSjhFamZPZTFuZFJwV09N?=
 =?utf-8?B?Q3lBaU5OWmZMMDNSOVpSOXhvOWsvamJReG9Ec3FvV3QxSi9VMXFJcitRTXRN?=
 =?utf-8?B?dFdlb1lBVDFldGpUZWxFY043NE9NL0lwOFEydE9Za2dsdGM1MEtBQ3h1NUVv?=
 =?utf-8?B?dHlXQzdOMHAxc0RiY2Vkd0NEaGErNG9uc1FyOVJLTm4veFJmTWVtODd3NDB6?=
 =?utf-8?B?QmtzTlkvc0M4T3FLS1dhYWVRaTRFY05TVnBGQW8zaFhodHNsbVFiOVBydWl1?=
 =?utf-8?B?am95TXZWL0NNbHlzZkpTdk5WbEtHRGpQbWlHM291T0FXRkVuUXUrdFkzRjN2?=
 =?utf-8?B?elh5cERGUzJlbGo3S1R1dlhJNzF4NWFzS1FaR1hSbU1qakpjejFoRnZZQzNi?=
 =?utf-8?B?Rkdjc0ZGakdHMG1rcGdZWDZzWjBkWWdJUkU4NkxaajEwOTdhYm5UT2REUGJH?=
 =?utf-8?B?ZDlFRVNrMkNVb0dkSWhsZ3E3VmZldVVLQWNSdjFodVE0SXBiazRWRC9IQUJ4?=
 =?utf-8?B?aWx1Qlk1SkUyd2J3bXhLOGtiMkRQa1ErR0pGTS9GWXZFaC9yd3lMUklIeUtP?=
 =?utf-8?B?WGdWSXc0ZlA5bFR1K0pRNTdPdGJpd3ZiallJWmdGTWV3QldHTVkxOXpxWUxT?=
 =?utf-8?B?MEkwc3FZZVlMV0JBZUZoOSs1QU1IRlNIY3VUc05UOXpqd0lEMWYvM1FvZ0kw?=
 =?utf-8?B?NkFOeVpZSDNWQXVMb1ZGbHBZRWVtaS8vUUNXSjZvYmxFNGorTTFZQlhtcHV2?=
 =?utf-8?B?ZU5BbXl3cUh1TVlBWUJyU21LNTd5UFVRRlNISENkb3ZvMUV5RmNaMjBpdURr?=
 =?utf-8?B?ZjBkQkE1djVLdnUwTzN3ZmRGMzcwMkRBbCtxZG5Jd2FyYXdxOGgvdEkzRUhJ?=
 =?utf-8?B?TGVuNmhwWlpYZ25XVW95YUJmN0FBOXdreTdrVmRxOEZiTk9YZGpqd1pacUZY?=
 =?utf-8?B?WGV5RHp1dTRmUk05eUJMMWNvMDNtL3JINkdFL2MzcERTUWlmOC9mMUFJMEor?=
 =?utf-8?B?Q0Jxbzd1Ty9IUmtBbkw5ZmJiUmpyTzJ5MzBaUzlSR205M2J3dnFqcVBzSmJy?=
 =?utf-8?B?R21mQVpSaVMwdllXT2ZqK2VPSkNlMmdIZWhaWXVoQWlGRWloNmdHS3U3WEFy?=
 =?utf-8?B?MUpNbEtTZXZLVkFtN0xSY3F6cDFMcWZPUTNqT0lXMnEzUkkrOWdyV3BKNHF2?=
 =?utf-8?B?YktiMHhQaDB1MjMvVStuaGRpdFB2akFkd01PUnBLZjFyMEFVUjlteFBWQXJH?=
 =?utf-8?B?T2VVZHludStjd1B5d1BhMytoaW83eHp6YzcxWlpMUFI1dzVwdWw3L1FlM09O?=
 =?utf-8?B?SDk3YWY4c1I5MDJKWXdWMWFTM2tmSXdGV09NUWJla0xLZmhya2RGWWJYUWF0?=
 =?utf-8?Q?EW8fmTAwpF2ubXHJuN4YiYUBf?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d537376a-40a5-473b-5150-08db6932695b
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5311.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 21:42:24.3269
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UokAsCMXmpRcF/z22NK6ahIVyHOWwseVIUORn1LDZVzOzXiAZXaO+mPd+kQXydKA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4162
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/8/23 05:53, Mario Limonciello wrote:
> The Kconfig currently defaults the governor to schedutil on x86_64
> only when intel-pstate and SMP have been selected.
> 
> If the kernel is built only with amd-pstate, the default governor
> should also be schedutil.
> 
> Cc: Sun Peng (Leo) Li <sunpeng.li@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Reviewed-by: Leo Li <sunpeng.li@amd.com>

Thanks!

> ---
>   drivers/cpufreq/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 2c839bd2b051..a1c51abddbc5 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -38,7 +38,7 @@ choice
>   	prompt "Default CPUFreq governor"
>   	default CPU_FREQ_DEFAULT_GOV_USERSPACE if ARM_SA1110_CPUFREQ
>   	default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
> -	default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE && SMP
> +	default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if (X86_INTEL_PSTATE || X86_AMD_PSTATE) && SMP
>   	default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
>   	help
>   	  This option sets which CPUFreq governor shall be loaded at