Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 17:18:43 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: RE: [PATCH v5 09/26] cxl/regs: Remove early capability checks in
 Component Register setup
Message-ID: <6483c1639f58_e067a294bd@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230607221651.2454764-1-terry.bowman@amd.com>
 <20230607221651.2454764-10-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230607221651.2454764-10-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NwARnaXgLhgOwWj4NaZXmaxwfF3Oa5r97lIhNkcAJ57cq3jY0AyBDn2Y2gJB?=
 =?us-ascii?Q?HJQX03we0iFjYQ12Omd2pCYGlh0dvEdQSUEqmcW4YADKseUtA+n+D9aHTPwo?=
 =?us-ascii?Q?evyLkldIbpfAZSItAZ7V47iCmu9JBY+c2cotUC5h79tsYMdB1tBj69aGdqCQ?=
 =?us-ascii?Q?hOveVuEbMbJCEK66c6+Vcqxeuos32xMB11tnVUdqNRXxAvVWzis3i/iXXhuZ?=
 =?us-ascii?Q?1idLI3KskAf3VESL6UCUIoRow2+kj6nZnwTfybwctp+uTUBJ5Hsf2Vvs6LHW?=
 =?us-ascii?Q?OTqZmTy3Y7KDE4UsSGSyLfCYYVb5auzw+LvFlZjXE5nnX4t3NwPbB+UKpJl2?=
 =?us-ascii?Q?LxXKePYTQpe3oLGCL4Snb0RzVTJLVa1a/8LKf48OOrUHhgyFyrIfVCSst6Fs?=
 =?us-ascii?Q?QCgI21ej9fcVoYM1F9/p/T6uQBJEnak2gee4/MPYNTuPQskKXd29vT3MzT5S?=
 =?us-ascii?Q?/6RmLJF7sVPc9odoo5OZ/uoqM1Cgp1L6NvArBxAOaTTdqjnsuki2qAYN0+c4?=
 =?us-ascii?Q?L/1oGE2eqotSQ8YhVsMy7I7NpN1NRGL67D/A3eMizkiqq2wX2PKSANlaPvGm?=
 =?us-ascii?Q?6S6YX1DxxvqBxo+eUddZzuEdAgL9VJS7TtQD+DuWTBEtf2oFM965diTWzBd5?=
 =?us-ascii?Q?PtRzXuNodToFTI+l+3m7acyXsHtQPUApu+E82V4ZfIB4qnYb6OX5DJ4ZuZ7A?=
 =?us-ascii?Q?eqh2z5PJMM6YZfO8xPRAgE+erNSwsYDuemTEg4zPGnYZQ2DWhDjP6LGKCCYE?=
 =?us-ascii?Q?rA1qCUR9AwGUYqAFDx6t7BYDSYQRcwt/s/Zb8qvV7XTmXYQy0pRAnTdZhQld?=
 =?us-ascii?Q?yq010hY8L2Cfb2DIQlMcGUK14hqnqN9bp4/lSVpXY8Cki7x67Nw6vNqx1Ui+?=
 =?us-ascii?Q?m6HbEX/5zwOz7U0/Fl6bhe/X3vijg52QhpJWgJN6iJ/rdSFrMyoWk7QvceZ2?=
 =?us-ascii?Q?OUeyfLJobV05xia5jcnin0NDt4dLCdQzcO8vl1Bo9d9iSanZIConbZZPEPSH?=
 =?us-ascii?Q?7vXMx5cJKsSm3n1jlZx7RcTk0BSCj0Bwth7V2jZBd/AZk/seQ6jBEKYZhMd5?=
 =?us-ascii?Q?tVYodt/gZ1K2Jpw9psGi7xgZ9jA8gyNIVo6bPytZ/lFW8WjvjAG+vlWbE07R?=
 =?us-ascii?Q?nruM6VeROKg7RGSfFCQtmVFm6JMuDpqpxG8vmce+oHJuC0jOLQo8d9X39NnF?=
 =?us-ascii?Q?WDD4WcnwJhiOIENab20p3f4AtO8PRCbuovlTdPAtluTAcLmRgPHegluGVlks?=
 =?us-ascii?Q?asANGbGGQTtFgVHkXA/Mm4mtMaEBHUBvF5LOprT//LAYGBBddnm4Gw63t7Te?=
 =?us-ascii?Q?b5nekOxngMa99NiVdQF7xokkfCz1GjcW+6Y09xrBq0KfUD6/fp1oBZY2rzVR?=
 =?us-ascii?Q?ShgK/oJaVIJ+EPdNen3vQmdZjLT/u5G5LkG2si2l8YH3jmdwyZqWTZLnF8wF?=
 =?us-ascii?Q?d3UkECk0gZ2OnfoGy2Yz0Ps7UjS53UD4H6jMKsLEUlWTKovUaRuH1T/oSDQg?=
 =?us-ascii?Q?c7cSwOp0HEl2BXbh5CQGFYat5FEf7a/ujbHLm1Nzn34WyzYyC5YY5F6tCZMs?=
 =?us-ascii?Q?9yXeqKdaaabiGrId/lxfBrj9SkMOZX4HlSTm6q9lLZmnxceETVbGbnLdof8x?=
 =?us-ascii?Q?qA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5cc7c003-b92b-4306-79da-08db6948425c
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2023 00:18:47.8587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uWcWmIvxNdUp1QeXJtIC8VlFEX1Xv8uJVpACRBkpAl0ODEuqvB/4neipw4gcuLnAbSDDwI0hCHTzu/fGxDmB7xu49iGpKMYbwEvDd5SIDmI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6126
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> When probing the Component Registers in function cxl_probe_regs()
> there are also checks for the existence of the HDM and RAS
> capabilities. The checks may fail for components that do not implement
> the HDM capability causing the Component Registers setup to fail too.
> 
> Remove the checks for a generalized use of cxl_probe_regs() and check
> them directly before mapping the RAS or HDM capabilities. This allows
> it to setup other Component Registers esp. of an RCH Downstream Port,
> which will be implemented in a follow-on patch.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Looks good.