Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2851995rwd; Fri, 9 Jun 2023 19:03:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ya9jslRWJjYGOUNjRQI4aCsjHm8t17qk/uTU9W+IW8AIBfDGCzMx5No17XQdgg3smUeha X-Received: by 2002:a05:6808:8f3:b0:398:1186:88b9 with SMTP id d19-20020a05680808f300b00398118688b9mr258759oic.30.1686362625415; Fri, 09 Jun 2023 19:03:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686362625; cv=none; d=google.com; s=arc-20160816; b=b52IWdWe0usah+7KIVcFVGb5oOBaLbKe36UrnEyUak75SacNxw0LzjsPSp0NiSTmfW 2H29AzG4kKr8KhMhOOVUCVBd6MFWetHHo4uyEz+KVwYALxucQhbvaQsKOCbjK1n1kJC5 CQ1j5/G1CZ5roOokS3ErdYQtN/lodYkjvFipzWW0jrR6eLwJYEX9K9mCokrJjCXbWjmS iDtgiEsBdPtq8i7XpvOBUp3egd2ySa3k/Hor1ySh9rPDOKIqXCaIKx1ooGLGLs/95ScR GDxHUjvlg1kKkvUVR/FI4V8ceovkHMP4XwXL1sJQuQOlMPU99HHR8PhUk1iOqSwHFHuG 1YOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rvR6dekxmIrpYjXvV65854iQwAmXJOxjH90USp3ojPU=; b=GQX/5UQcbkqIV8qUBJut9GUa11DoQxUxCYtdtI7BlNRyOpiCQBN+aQNBQEvRvHUyVc 2DdVhQG2DZ8VT3/u88yE+04XqhuuFG68p9VQT1PddXugAC5pjxCygGijtScHxFm8grLJ 8B+P6m0NUsdIQpAjoKQM3HYBel2LuCGNXyitlew9hTWJSe1i5RzPe1yD2huJtAcmlyF3 izNhAn+EK6ZXz0xMSmoIF+Jie6hOmwJobwYv56PSEs43sNSPwsEOqegNjgt48DJp1XFn UYKqBJo856gHu32IUJJ/Nxjd84szwkm0ybf3qM1qeru2fJE4DxCHGTkUx6RQWA6E4ztb phRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=dkJFJ8ZY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j63-20020a636e42000000b00543c1b255d3si3553886pgc.174.2023.06.09.19.03.28; Fri, 09 Jun 2023 19:03:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=dkJFJ8ZY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232349AbjFJBv6 (ORCPT + 99 others); Fri, 9 Jun 2023 21:51:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbjFJBv5 (ORCPT ); Fri, 9 Jun 2023 21:51:57 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 848D33A82 for ; Fri, 9 Jun 2023 18:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rvR6dekxmIrpYjXvV65854iQwAmXJOxjH90USp3ojPU=; b=dkJFJ8ZYNaV+JBxahyxLYGOPcC D0MaV1ccDO7CA8v+voLS6TUWourA/iBtlDzY00iqgT1KwrznvuJ+qbuSaTqnxcYdaNZdVgx0z18oq w/mJVrR6Kpy0V74k2ke/icCzvaiUixHLy8V69u8iwAxnBVklfVLIAgX72mh4703GeLA8137nmVmmt 0eJDTD83WgeQrBXKMzXf/f6CFmzgChGE5Z7NIYUgvutdMQSNZC56Dbjir2TBUM/kLc9kVQrES4Tns rFm1JOZa+i1aU6XX7O7nR2pOelHBxPCkbLqQLzKu6WXea+K3iZrai+ysfUZ0/eNRHH2LzrMZJEINk AD4piwdA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q7nlQ-00HMf4-Sc; Sat, 10 Jun 2023 01:51:36 +0000 Date: Sat, 10 Jun 2023 02:51:36 +0100 From: Matthew Wilcox To: Andrew Morton Cc: "zhaoyang.huang" , Suren Baghdasaryan , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com Subject: Re: [PATCHv5] mm: skip CMA pages when they are not available Message-ID: References: <1685501461-19290-1-git-send-email-zhaoyang.huang@unisoc.com> <20230609153519.ff01046ef0faff00a74bd5b0@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609153519.ff01046ef0faff00a74bd5b0@linux-foundation.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 09, 2023 at 03:35:19PM -0700, Andrew Morton wrote: > > This patch fixes unproductive reclaiming of CMA pages by skipping them when they > > are not available for current context. It is arise from bellowing OOM issue, which > > caused by large proportion of MIGRATE_CMA pages among free pages. > > We saw plenty of feedback for earlier versions, but now silence. Does > this mean we're all OK with v5? I'm fine with the implementation now. I have no idea if this is the right approach.