Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 19:23:51 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: RE: [PATCH v5 13/26] cxl/port: Store the downstream port's Component
 Register mappings in struct cxl_dport
Message-ID: <6483deb75d0e5_e067a29420@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230607221651.2454764-1-terry.bowman@amd.com>
 <20230607221651.2454764-14-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230607221651.2454764-14-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XVyq0vA4ZULtBlaYjBEEXBwAp1dtjGUCJdhsch5EP8HNhECdBkBxOl+bXOqU?=
 =?us-ascii?Q?DKQc0X1Qg01NtP3pmotQNZa1o7rHnrq9Ke58xg1iDOsB+whWppSL4MjYgC+n?=
 =?us-ascii?Q?NTk6SJilpgScxkQV4CTX0+MNsDoexxhE/BTvzrNcMuGvzJ5IFMZK6NDuphwa?=
 =?us-ascii?Q?2lI07T9O3UZ4UnPc2sAhvRRLgEaBZYqorl4Zw1xoxTKs6Lyxy2dZvkD/8P/K?=
 =?us-ascii?Q?/VIZnRCxcbcUUM4U+MdlwyHmZnIMkhDN4ICfUeM1EV6cTWbdAAxMC/Ho4a6H?=
 =?us-ascii?Q?EnFAA1VfeU3vkCJAWbRp6X80/BL3RINWKlAi2P77YWGdfYyby6YUqKA4+CQ1?=
 =?us-ascii?Q?ljBacnvkQi5eLXoDUDiQjHZb3ikwiHLHwO/S4jwSz+zCq1yuPLTEiA2Mo5iA?=
 =?us-ascii?Q?ELmGDqHTRJuHa7Ux00DfU1eoy68KfAjubqGho2iZYdZMb8kXb6JVKUdF1w0U?=
 =?us-ascii?Q?5BY3qP+pCVp6kkC0v7+IXQBF03YIHwREEgEeQqSiJ62lf/bDxbBUwHAziK82?=
 =?us-ascii?Q?xjLII6WsimRML6PV66hCH3TiCiEIX8hUDrLW/mocTui8ubSfvLB+Cy1DRr1S?=
 =?us-ascii?Q?1iio1pVGSc2/EyRIdRqkVgxgu2r+4cGKHjK6kWCm4VIP5c3+JxpiTu/Mp0UJ?=
 =?us-ascii?Q?CUk30/I+CRmYOVtY9NDrm5m6GgMc18gNRtHZNnhNLyQYCJCu+TY/V+rl+Mc+?=
 =?us-ascii?Q?TbXW70d8yRU2K/oAJf3lXhAK3kpuZIwGmws5Z36IjYO/z4wIuvDrZpJ1OCId?=
 =?us-ascii?Q?MNvCq5qKk21TA5xZ9P9kP2O0K3cafkUeXk5N4jF4l0Iyy9LLZLwa06wsoKOq?=
 =?us-ascii?Q?dLzqGrNuFF2A0C9IuLp90ONaDGNK+qxYuSDYpsbmkwI+KU8KaUgWzZw5aYfl?=
 =?us-ascii?Q?DywzQoTeL7jZHLL9dVBfmufAsCzQeIVLggBQ3GlXGeI+y7GxmeKS5rLDb2EM?=
 =?us-ascii?Q?1t1cutmLRaWcICh2xLnq3PovpFbhlQaQvYYUBl/CI6b/RasoBM8i1s912207?=
 =?us-ascii?Q?reDVQoG8HQeKWL79RVOWbpBgjOKPfISLtvpH/IOEBTodFRPoTePsE2UtIguZ?=
 =?us-ascii?Q?YZ+WXdtIzB+dAMPQB6RSV1nHJf6/sHVnjhT0Qkp9JSZSL2kbukE9adGQgH4U?=
 =?us-ascii?Q?/HYPGnSCJSARif50y6aj0NEGL0msoXh040KqLtED8dOqs5SjGpSLOlbmu27a?=
 =?us-ascii?Q?KzScm3cj3zrFIx+wb7s43nFu2Q7LYfRVJbObxxxsnx5jMeU9rexniUx8fvtq?=
 =?us-ascii?Q?Ytsuud328J7I/DB9aa7Y2J83/IiCi059F3cnVxkbLrVA7GghHmfHhfYGJWU1?=
 =?us-ascii?Q?e8k7dKNpPbf4cGEpasKn4p7cbJGZ0HOcP8391UWW9yP2Bc7XYpDDIjJIMC62?=
 =?us-ascii?Q?LM0rdGmc0ck4sZIPYBHDp8GEvOQvyzmu24hrdLDoPGSMaySC8obO4liqgu87?=
 =?us-ascii?Q?DEmtyQeXLMQoNXHG3OgJ9IkR8YGmQINZHW15WFZR2KWg3w8IBUV7y4PhiUjl?=
 =?us-ascii?Q?u/nM4ZPvQCzosApRElWcf6CZm6bTLhGZ4NoJRJ3fudneHXBdpf+9AS+A7qSZ?=
 =?us-ascii?Q?fbtRQ19pNTdew9XPahrMAZsRIqksgyWlnakLzdc6Ewo9A0DsW1paYTFx/442?=
 =?us-ascii?Q?/g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 19900220-68eb-4639-88ef-08db6959bd93
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2023 02:23:55.9236
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +p0Bwe6Do5t7Z5KeWPHUYEoUPIhF6Bh2B61V5KF4eWVlLGIEKcQSmeJtER8ilk9y53ipNLOBvuaKV+belvWIeDgeFjTL5FXriCiA1yPcoc4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5162
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> Same as for ports, also store the downstream port's Component Register
> mappings, use struct cxl_dport for that.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>  drivers/cxl/core/port.c | 11 +++++++++++
>  drivers/cxl/cxl.h       |  2 ++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index 305125b193ce..a40d8cefb57d 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -708,6 +708,13 @@ static inline int cxl_port_setup_regs(struct cxl_port *port,
>  				   component_reg_phys);
>  }
>  
> +static inline int cxl_dport_setup_regs(struct cxl_dport *dport,
> +				       resource_size_t component_reg_phys)
> +{
> +	return cxl_setup_comp_regs(dport->dev, &dport->comp_map,
> +				   component_reg_phys);
> +}
> +
>  static struct cxl_port *__devm_cxl_add_port(struct device *host,
>  					    struct device *uport,
>  					    resource_size_t component_reg_phys,
> @@ -992,6 +999,10 @@ __devm_cxl_add_dport(struct cxl_port *port, struct device *dport_dev,
>  	dport->component_reg_phys = component_reg_phys;
>  	dport->port = port;
>  
> +	rc = cxl_dport_setup_regs(dport, component_reg_phys);
> +	if (rc && rc != -ENODEV)
> +		return ERR_PTR(rc);

Ah I see that you wanted to share a similar function between this case
and the last patch, but I would still remove one layer of indirection
and make the setup return 0 if there is nothing to do rather than the 

     if (rc && rc != -ENODEV)

...the stresses out the reader wondering where that special error code
case is generated.

Otherwise, makes sense.