Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2873617rwd; Fri, 9 Jun 2023 19:37:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4jZx+awdHANthO1T+iowJvpRldVhnsJ947abuosz/RkqtL/ptW+ZJcmx0GmYYdYDBiqkP2 X-Received: by 2002:a17:907:16a0:b0:96f:74d0:ad0e with SMTP id hc32-20020a17090716a000b0096f74d0ad0emr3763716ejc.58.1686364633014; Fri, 09 Jun 2023 19:37:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686364632; cv=none; d=google.com; s=arc-20160816; b=OmldWUoMp1xSG8mkvePOvicRXXXKGvDLHh8ynxB3nSpooR5ban9EWs+lXXdFReCAvL fY+iccticCt5eSEnBMNtRBCjaOa31kA1MxE0I/g+Px8ASJFrccTEPOSItor7kJU1Uukv oxsCh+VV8RBq3SRG1GjGTq4NR/ZLndiuCUayUpDlRUv2LS3VDQudUzcCB3fpMQ9U3P+h YEHhrX6f2PoW6KIeUNcxseX2jUoQcJtvSYLVyniOK4MXY3s1tVcoYG0c+LWCVda1clHR E4gDPL51J9rKdH1Zl37I2RNdxO8Pd3AeBvI9awG2qt2IvM1H21pcSvLVk43blB/RmyJ3 Dwzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=4XClj7KQogkxLLxJpYVzzUMzYlW7YpvufIbYlrKPOdI=; b=cKNhnKp8cg8J77mxOdxdDQx+LpqjNx7uC701G2hKJdryL+DpYr0ztXQM4fPSI0tIKl YxZ6I2pN9C9jCoAYsUyZl3xKm9a3WwAuCIX839xBQcfcGr3jfStbV4HTfJsUTMwgtm5I psz4qQnlCrlSse1xaSXZJFZrDUUvmMAF/80wBUGJ1V4cZrL6Y0ajbuO4aVwe26w2P9Zn YFXZsA148bM+YNX0d8mUzDYg2vn60hBC1xoYoqhLfJIWOFJdGm21PAqaRr0R6Vx1E9b6 +KD/6cKir4rmfKwA4ynI2mJwtTriLE7uHj3zRQXn0ihXNGWemSKzynrwzTAJoWdjhGV1 6jhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a170906504a00b0097885ff4845si2245062ejk.168.2023.06.09.19.36.46; Fri, 09 Jun 2023 19:37:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230243AbjFJC0n (ORCPT + 99 others); Fri, 9 Jun 2023 22:26:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbjFJC0m (ORCPT ); Fri, 9 Jun 2023 22:26:42 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDC73CE; Fri, 9 Jun 2023 19:26:41 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4QdMJs1TxJz4f3k62; Sat, 10 Jun 2023 10:26:37 +0800 (CST) Received: from [10.174.176.73] (unknown [10.174.176.73]) by APP4 (Coremail) with SMTP id gCh0CgAHcLNc34Nkn+FjLQ--.14638S3; Sat, 10 Jun 2023 10:26:38 +0800 (CST) Subject: Re: [PATCH -next] blk-mq: fix potential io hang by wrong 'wake_batch' To: Jens Axboe , Yu Kuai , jack@suse.cz, andriy.shevchenko@linux.intel.com, qiulaibin@huawei.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, "yukuai (C)" References: <20230609085130.2320859-1-yukuai1@huaweicloud.com> <6b2fc148-3bf9-83d5-fd5e-242ff51c9c96@kernel.dk> From: Yu Kuai Message-ID: Date: Sat, 10 Jun 2023 10:26:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <6b2fc148-3bf9-83d5-fd5e-242ff51c9c96@kernel.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: gCh0CgAHcLNc34Nkn+FjLQ--.14638S3 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYg7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E 6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28Cjx kF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8I cVCY1x0267AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2js IEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE 5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeV CFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxG xcIEc7CjxVA2Y2ka0xkIwI1lc7I2V7IY0VAS07AlzVAYIcxG8wCF04k20xvY0x0EwIxGrw CFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE 14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2 IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UMIIF0xvE42xK8VAv wI8IcIk0rVW3JVWrJr1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267 AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbXdbUUUUUU== X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, 在 2023/06/10 1:41, Jens Axboe 写道: >>From a quick look, these are the only manipulators of active_queues. > If we're under the tags lock, why do they still need to be atomics? > Yes, 'active_queues' doesn't need to be atomic any more. Thanks, Kuai