Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 19:34:05 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: RE: [PATCH v5 15/26] cxl/hdm: Use stored Component Register mappings
 to map HDM decoder capability
Message-ID: <6483e11d17b2b_e067a2944c@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230607221651.2454764-1-terry.bowman@amd.com>
 <20230607221651.2454764-16-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230607221651.2454764-16-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XdtaS03mQ2/zXLjimcEmWwDfnPrQZr9BG6ckVId/qcL/vWAPjwboiIhVHIgA?=
 =?us-ascii?Q?oPPjE1XF9BkRvvJiJXpzi1LwOzHmrV4Dw6Zfwak3gIXHCgUhUSZj4op7QP3c?=
 =?us-ascii?Q?PFnU+UZ0ummoSl8YiegCmYhoKUq3FQtCspW+VvmZ2329Ua6amssGM9ylyo20?=
 =?us-ascii?Q?Ju2vpSKj8v6dx6GoVJi+AjL1SCYIjaPx4lBw0POjGHd/KNYnb4EnLPGmovgc?=
 =?us-ascii?Q?B34LHFTeWu20Uj5/8KbxEVmRIhDnqLDkHfl9Jm2fabwbb00PBWI4q/01muOq?=
 =?us-ascii?Q?FDW0z8eZiytlOiQ1MSQ+T6LZHd+rI2Tq4PpM+W9Nbp6wSGBioCgB9Uf+eZYJ?=
 =?us-ascii?Q?RooQ8pvCa38Dbn/oH0CQGXS8ollt9/RD6jpguLtpx/8IK6gz/jVXSMXHG8FD?=
 =?us-ascii?Q?ySFuIv2BaLuywxqcH5ErVL/5DNOvVDTPuG1WiXnkyXx9zhl2SbQqtXeMmAyC?=
 =?us-ascii?Q?0Jqi+e8/zBioTX1Ik4miBDSyDfywlVpbjEOiymub7rm0LjXBi2BNCGCQUHEu?=
 =?us-ascii?Q?qJvbH2gLAiO2ogR4sSYTQknfV9p+mcvSLDTmrkZBSW2bCcebBeKqP6lon5WY?=
 =?us-ascii?Q?HJsdURUHHl/Ja4DQVP6oPa1kYkkPX6MTgC99i+Z708TkNOKGR+aEfJgzQTJD?=
 =?us-ascii?Q?iQIRdN33Wym7g++VWeWkIhhwEO5C8zSTm80L+WhqCYF+5KJ6DwupMNKjGi9O?=
 =?us-ascii?Q?t90UF/29WudPxVH0TlQC5KExHDnz0kFkpWXSDvZVpAIq3o9cO6/jG74uGwEO?=
 =?us-ascii?Q?pss0i92fV1rUWEnD2J4lZ+WKzvYuhXIcSKBDjl9V1xpUwgXvXG6fgA9n5/4/?=
 =?us-ascii?Q?8klXt9JHStMJe916eKqdl4XcBhEzfM69Xg5KMGg/jD1O9DZFyVyDPYvF2qhk?=
 =?us-ascii?Q?YlTbHdMaTpQILHAqYMG276aLqrLPWsdfppBYpK3spZ8t9+qRNcKvFXdu7NGi?=
 =?us-ascii?Q?LVHysFdVg3Du8SBoHPoTSlKfqROZjwcZTF12MzpXLUoO8X4em9N/iU3tQCK1?=
 =?us-ascii?Q?/3AT1V/8usx8BI3dr9jtim4+fltRvebLUQVJUAb8IJfeyT/mxI5H8nLxmKEh?=
 =?us-ascii?Q?B/Rxd1Dbyt3w71uYL4IFxA81o+3GcUuWg4j2CJ3EeMhS/r+edDzMXWf+8OgE?=
 =?us-ascii?Q?mHbcsE0TxZLqQEpUld8jyFHjpBo98n2fAfOAqJs2mOMAXlihFhodrccTwNJ1?=
 =?us-ascii?Q?obVeRzljjot7XlWVChw+EjXSDDNxxN0wKaelQBesp2SLtF6sTTCoZ6CK9d6I?=
 =?us-ascii?Q?wv3FbgQKYyV0yJzGLCfYZM6IGignAsjrhRAO5p1B0upl90GX82FnZdRvDP/t?=
 =?us-ascii?Q?8fHZ8eho+2f0SREb1FZ2gY6/DZTj9uxOh22I+PZ8brvDwSoQZcurPu/PiTut?=
 =?us-ascii?Q?XiehzY7q5bA06evJshvOQurAakhh8cJyAlxeLa04FC12a0IMTxLeCo5QypAT?=
 =?us-ascii?Q?3NlmLOKdnWPcZxldfeFzrzW84NYX+eexlwMZ7xezWRvfrOItULmolHY2NOAE?=
 =?us-ascii?Q?kxIiDPXKzGujZUbNy/AA3TSnptv9uzdyyNrRYc2ssKnLa7V4/ijW/t+WrHbS?=
 =?us-ascii?Q?PMC+d+wbdpaD6si2pjBHzxpDNZZCzc6G56JmCa9yn0tNZ8ad/BbdVVdFKuGh?=
 =?us-ascii?Q?cA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f06d748a-05c8-4da7-88fa-08db695b2b6a
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2023 02:34:09.6018
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h+yL9gtQEicU0wjvDQBa/mBL8FFENpKzLx3S2y7UdlSHxJzBmzMQi94AUVk/Ys97H8ctZ+2rirDQxxEWBKMfJKmJGt+pnKllyl84jOfBWEg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5176
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> Now, that the Component Register mappings are stored, use them to
> enable and map the HDM decoder capabilities. The Component Registers
> do not need to be probed again for this, remove probing code.
> 
> The HDM capability applies to Endpoints, USPs and VH Host Bridges. The
> Endpoint's component register mappings are located in the cxlds and
> else in the port's structure. Provide a helper function
> cxl_port_get_comp_map() to locate the mappings depending on the
> component's type.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Looks good.