Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 19:29:04 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: RE: [PATCH v5 14/26] cxl/pci: Store the endpoint's Component
 Register mappings in struct cxl_dev_state
Message-ID: <6483dff08a742_e067a2942b@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230607221651.2454764-1-terry.bowman@amd.com>
 <20230607221651.2454764-15-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230607221651.2454764-15-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mvn77XSvY/KL6lWMXCXIASObW+FWC8uvO3FUFerIaDQ8hGTHkmjfC9Hxx8K1?=
 =?us-ascii?Q?pArdd/aBScCiM5Thr/UkAM1PcRajaKurSlWiEsgy/M/XqXMUybiH6RLh3Juf?=
 =?us-ascii?Q?y5pgD6SpuikJMouTfuwxkA7qUqTQpgt+M3WEuWvVZQ0ObYueM8VGaXHJPiyk?=
 =?us-ascii?Q?uhS+gSNoYcb2VpDwlPY4UjrmL/nUzho6YZC9uARSwo1e2ptIcokb4hWIHbNP?=
 =?us-ascii?Q?DqcwQSn4sdpfJ+cfAa/B/3tEcJdFJJzCgmpjx7jEcTZ7svbS3u7aJ9v+wjpb?=
 =?us-ascii?Q?Za7j1knxGWUpAPb6Hbq0ftyxyjwa5LSlIc2VHOzlRdSqNJS04UYyF4aOPh4M?=
 =?us-ascii?Q?1Qg1XudHxlNSU9WDi95Pgum7b/WTcg9QTs/MS4iK0juZAD6p1VH6/BlZsExM?=
 =?us-ascii?Q?daZk7I+kD0feWLlRmS6OoEMhCCQdJUB4BacsYcOD5VQKdqolD+iq8isazzXk?=
 =?us-ascii?Q?JvKZ9Yz8m3w7hGdUgDolwU9C/Is+WT1UWuqcq8n0GtYBTttRqXHKKbItgixl?=
 =?us-ascii?Q?BVui3vEM3v5NeJQpw5dw070P3CbJxEBMn4U5rgE0dMqLcXMptqmNWKQrZjlI?=
 =?us-ascii?Q?9nYGRkOLuy/oIXJkloEHZ49DXG76piSWuJL+3DICU4s+LnGz48zMIEv7SA21?=
 =?us-ascii?Q?LkOiCpu3kcHZn2NUgDqx6VBc16m4PgtRQqIvJDtGX3NlIqb6wftNX+byIfO7?=
 =?us-ascii?Q?snplO6kR0ffg0t8s8O5UGbh7e37msj8NsAl2A99FiH1xOMPfdg3k+Au4pP9I?=
 =?us-ascii?Q?UJpt8kOL0QcvMzyEAYmOcdKT9zffSfEF26M7+tUrYlCKEYjcEzUG94xukg6G?=
 =?us-ascii?Q?XBNbsGius35j2zXUZHMSh8FlrH0IjTplaSnaTEyUzX+AoEYdZOu7SWsQD1Dj?=
 =?us-ascii?Q?kou9i8y6nZBvUV9yV6jCWmx0CKHnlq7pBYmC51W94c1pzbpB154eJX0EGezd?=
 =?us-ascii?Q?dgDYjJq6bUPeigRh9i6ZacEMGoHntuoyOHdHePbRJ00fA25x+5UPWdMzpOYM?=
 =?us-ascii?Q?vYQvszCm73BqtjxcCFYFYvUOeZYyxJTfPf+FoF/MMst6xJMZrGqrnKtC3ywc?=
 =?us-ascii?Q?l5ZbNSODg80MjF5VTsO/KA7Mjujq5/RedUZljlmR7w3HaHQij0/u3jWzNZVD?=
 =?us-ascii?Q?BK8LGmo096hXvhXtuLcKkSf6C4WGr7kwWSCdUBYAbYi3BCjJAfZZKm2ddl0C?=
 =?us-ascii?Q?T4m0veImSa0haiJRyJq2fvJWyLeXbEcQSI2gxoZ3TFqBbnFzp8C5j4L/oAfD?=
 =?us-ascii?Q?6ajItEOSgOfV5V2lboRaUOOYyeWlZTcVwuSx1Wf1rNKZLFmYegAbevGViuPc?=
 =?us-ascii?Q?7aiTaUHgHs8tciDgAUOiLGKj3f/r+LznR/rqN77/StPYeXzwzozw1pLCw9AZ?=
 =?us-ascii?Q?dGO6YhEX6T9v1jOD/O6+sjN3qubaRqcyRQwTI6ro5nqJwiFoLs1qq8AtEyt7?=
 =?us-ascii?Q?pWD5jeKqR7N/3KMA+3cugvZM+XAvLguQKQbLIXstiRsGhzSiiHK+vta/p9VT?=
 =?us-ascii?Q?rTBAO7dxvUbDwc5uh4cWBuXzM3sqIWhB5fmZeuBSAjNFz15SxkbmkdB5HUef?=
 =?us-ascii?Q?4Wqrez/YEYAS/qVH324WShgb/YTCP37cWKj6IGDlcltLEH6CE+O46gli3O3e?=
 =?us-ascii?Q?Dw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d8462ea-b2b2-4a70-526f-08db695a780a
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2023 02:29:08.7528
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w2RdafP6NRiROSC3kT89arnaMqqgiV0ozMJeiOc+sG4Y0Gs7aiFbnXIHueGKuSSLFl5UKrPh56zmCOLk9S+ixgFeO8+k0R/BZF7xJKgzcYA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5176
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> Same as for ports and dports, also store the endpoint's Component
> Register mappings, use struct cxl_dev_state for that.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

This really feels like it should fold in the removal of
cxlds->component_reg_phys in the same patch. I do not see any reason for
cxlds->component_reg_phys and cxlds->comp_map to coexist in the history.