Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 19:38:04 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: RE: [PATCH v5 18/26] cxl/pci: Remove Component Register base address
 from struct cxl_dev_state
Message-ID: <6483e20c66cf_e067a294f7@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230607221651.2454764-1-terry.bowman@amd.com>
 <20230607221651.2454764-19-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230607221651.2454764-19-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wv7C4S3NYwOmSrQSJekKfbGh6xHOciPfI3v1yRxjGPJlWmbexhD9FhnLn5Ot?=
 =?us-ascii?Q?xtHGch973Q24Gbv/nyhTSFxd4Vkg1NI4L72JeG4nd9gNetUxhzdT5FmAn58N?=
 =?us-ascii?Q?elSTEPeNijDT+zPVTfZujCFRZ5dmR/8DwCRCxUccnfiCa+Okebek7NT53Bcm?=
 =?us-ascii?Q?DkmEOmr0Id3l/LBj+GhszyGFIXDCza6dWqrWNtBWeuHopFWJ0Kqhby2sNJoD?=
 =?us-ascii?Q?UUDCwEoMsjz9lA0rj5RC3xraGUdBtp5PD6W6gElt6IsWqzr1wndNjxIYiTLD?=
 =?us-ascii?Q?00GmtxaMKeSYvd44Sisl6poGhUiGosdzeqKqWoDCm6pTEU477ARb4iUqXhNr?=
 =?us-ascii?Q?gryhqwNboHfsh5RvvXyWMGvPr9eRwqfaeSqTxTdtDgzB+5J5irFrNuAAmdkv?=
 =?us-ascii?Q?Tf55ZWUdGUpPLGRyfEKi16Zh9uWkbqXrPwmIWR1O0mRURkx/CDOHxE86nfGl?=
 =?us-ascii?Q?B07jwd7yJPetXJlPbf558y+TcQRwOudzXsiZWeP+UvreoafvV2pmeU8syhjo?=
 =?us-ascii?Q?JfmxNgLnmNCqjfJXEjt/bD8CV0etsJqx3fVOpgyX+qs7i6G/0ahv4B1ax0Ot?=
 =?us-ascii?Q?4GCZtMjBctgXuFCfFAeYhAMp30HLMMVSejAhVBkG69XwGdS/pMIvEHEM367E?=
 =?us-ascii?Q?X/JJFPKRJv5XOBr9seqLvvsPTg08yLTQKJNoYQGJpC0G1H1KzsLfDldZOvT3?=
 =?us-ascii?Q?ZfN9gMH6lLumKJm9QLsaHRmPm07jwnO5wgyIjvQkXDEm1qSNCK1YJhqMfQhF?=
 =?us-ascii?Q?280wTfSJrKoX5Lw8CxVNbwwrLeIIRdZuqVbNkS1RyIGHz1rNL1NfFnomz+AC?=
 =?us-ascii?Q?39JtS9LwZP9WUIiOdkgHdRHV3eoYGU3hrMJeMCYRgSdcWw8iWblP1o/ZfViw?=
 =?us-ascii?Q?/nGZtX0P9emnkhWjh/FNfyy8ETntBERCYJCkV4VVAFhC1H9139Hzu1C6gYQJ?=
 =?us-ascii?Q?VwOF1FMaJjJDG3GLFOx7Qg6GbwMVmBu2IHAoEsi6UHa9dyFOmycw1eB9CdXy?=
 =?us-ascii?Q?B/XJ0zn224lCyNZWFfR2hRuwV8zpzzcvDANBRLdky873qt0p4yn8KYEkGi2D?=
 =?us-ascii?Q?3uUleRQUYwyMXcxnI+EMZSYo9n8EpUWiMYZ4oyola6wnpNfrbRam5u89ConE?=
 =?us-ascii?Q?S438qZLpHCCXxU20G7cU9gkalTwO0zoQWp2UQMpaRXSNNDofSgxEZK+Kaod7?=
 =?us-ascii?Q?5KQRePyrIC1Dw3YPuix5CXf95+lmQ0SL8OwuJyIJBueLCz1+Whh54AKkm6du?=
 =?us-ascii?Q?yPHgE2iKTG15G+Q37irLOk+b1xx6ooFdKzBBZYb+BY1W+yjckYJfpIk2z9UI?=
 =?us-ascii?Q?JhW0UdKsQczyVVLrmTXDFSJAbwbQR1j6FIjaV8uIbhzzMr3zqYHQitAaGl7h?=
 =?us-ascii?Q?XlwZ9poaGLHwK/Tjfhqs9UZ7m2A30AIuvbxlngVfWmfLdMj6rqPVW0mrQ9DD?=
 =?us-ascii?Q?AP9vuF12broz9aNRZSJdny0VCqLCjZIGwIiAG2YCBz9H4sCb0JNrrH56HtzV?=
 =?us-ascii?Q?cuoNMb411gxeAJzsPq9HnAbLNdLdSXApQpPKxCggmojkdf/XIElklb5cDExs?=
 =?us-ascii?Q?GrWZcRABXAAKj6UnTqemjhH/GnajKxLHY3JKDnlgmJV9ZRskQREAgeo3cdZG?=
 =?us-ascii?Q?eg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eefe458c-a974-484e-4b8e-08db695bb9fb
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2023 02:38:08.7498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3wIYRUMdSpMKdKeOpK60R0iNA3aDIAD+fS2HmhyIrLs6XdkiKiHMxkHSx2dw+P1X+37yLA97UIA3hVEEV4YyGUdts0sTNOZG/UmH1TDIIEM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7245
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> The Component Register base address @component_reg_phys is no longer
> used after the rework of the Component Register setup which now uses
> struct member @comp_map instead. Remove the base address.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Looks good, if possible fold it in with the introduction of
cxlds->comp_map.