Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 20:11:17 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>,
        Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
        Oliver O'Halloran <oohall@gmail.com>,
        <linux-pci@vger.kernel.org>
Subject: RE: [PATCH v5 20/26] PCI/AER: Refactor cper_print_aer() for use by
 CXL driver module
Message-ID: <6483e9d55e20e_e067a2948f@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230607221651.2454764-1-terry.bowman@amd.com>
 <20230607221651.2454764-21-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230607221651.2454764-21-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WRFoWoShUjubXutyN38a/2LDCVreP2MzFvbrPWmfh7T/l4tQrd4eSKmN9EAA?=
 =?us-ascii?Q?k1tH7044zgN5cOxBjfBz45SBVWnGtnRBa72Y7gSCUt6il92EG51YJMMylMFH?=
 =?us-ascii?Q?GJlo7BQzkMV7Oz6OAex3MwM2ryQ0fpfUZ82JEGcGdPyvQ5WmruuJRnqaQzrG?=
 =?us-ascii?Q?CA+GoEfnjCrhBLNN2Y7VLKRc8nrRUEXxUhl36o7eClveGd73Q7yi2jlBF6EO?=
 =?us-ascii?Q?WP44ThtGg4v6oj04H/UXapSKJekiU+iptJowk4WQ4g17fjgsA/dQgUKtPu0L?=
 =?us-ascii?Q?X63P64XGxcS/3Q7y/BSXPlwcnOUGpIwCE3DOeQAFNbRQvg/pzysPRtft0THE?=
 =?us-ascii?Q?cPaQlyDZMAE7J3Fzwmr26yhvyFBOCo6wUjdgGtdzpOyzYxAvReTO05/VlZ5y?=
 =?us-ascii?Q?KVg9I2QeKm3oq5JaocmfTAWLhlnVvcRziCxNCtMMO4mpAn6+o2Eo861YYPFg?=
 =?us-ascii?Q?XtUiR3WVmqfCWQBNbhaXpi6kaqOM7ipJ/nof7d4tePGy41HaMhUJ+0Fy2Ufv?=
 =?us-ascii?Q?ehdKQ2CrDY5l9sGurKGugcQSV39xatAwttcvlsPLS82dy+wX4q2CYYLrjKge?=
 =?us-ascii?Q?uNA7Rs6dmw7H2xFp3nreEZfKmbF/zndu4vn7WoTtStK5Z1Y3j/wTnabTSNEd?=
 =?us-ascii?Q?8zY7AWpJtwhH0sqmYmW7IOjhB4bf7wGVLlHyut4fKO3pyNJncqMHRFDXctCE?=
 =?us-ascii?Q?MWvttjKXT9Ux8t1TDW6YdKQ5QXtdQuE4WsJQNbuWrVDryAaCDFo1T7dQwPwd?=
 =?us-ascii?Q?jYPrSesjvs8E+EUZGwCA2lsz22cAj2ClMrhgiM1PDBHpZNhrfXkqvodaeitN?=
 =?us-ascii?Q?VLL6NDK4EuScD1aNWth/N+2mmBnc7Op9OMVnKTTx45zdrLjVKWd0C94zLINQ?=
 =?us-ascii?Q?LU4qAGRyAzAOQoLE9uuMxYlVivdg8AR6Ejyt/5ykleZYFupv+LdWVweDlyTx?=
 =?us-ascii?Q?aOXRzCCtv85QgRbr8yWkpSmVyE0j1YSdctcZXjq8Csl4mACLEBsW4Rp92Nn4?=
 =?us-ascii?Q?oORQD7KkawVbGYjHYjksof43uX/BYmhUXTPAczODcknAz6EUyAU4ffFySzCI?=
 =?us-ascii?Q?u+yN1cQOiPjIRwnqpD/tK2RvmU3g7w1UmXtZCA2vRzfUptykraFjpXTvTvIR?=
 =?us-ascii?Q?bw0HzRXt8pyPzigpTdvaSef9EroVy9RK5dbsIW4cOtLeuxVxk+HzECZfXMJf?=
 =?us-ascii?Q?NjqYtTumcweUApOgZCRypOWjPsDl+nfKy0B5XTIOq/EyQ7CS1cWUEcO6LZM8?=
 =?us-ascii?Q?aN9CbyQbdslFH/UE4EzkTiSENyB5ONvci0PeDW0wVHEoJkj0IjR3RWfdD9eS?=
 =?us-ascii?Q?I3YLmM/nVZcUt1OHeRY+IGsPmNWqI8/wFPjYhPj3yS0nqajE+W8IjJej+EgQ?=
 =?us-ascii?Q?BIrgUbkmxcwZe/+h50PpD4IdiE7eO1yRL/JySUVsdlY0h0rON7BdP1acfTOi?=
 =?us-ascii?Q?I1P6ABinByKxCX7okxviRdRS9dYAKWqM4IsJ65QPVkx8LSYwMHyktTC9obBU?=
 =?us-ascii?Q?SCIoVD6bvkqNLGOk57Q4cwO4LtpIZG7ZN4fFmYl6TeeT0oDuPNZV21zCHCx2?=
 =?us-ascii?Q?iRD6Xa9UPEZ5ecTnRtGXrvnIhGpkIiESNL/7tyQ+LMoBmcxiV1a1tRkYAmPo?=
 =?us-ascii?Q?ag=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82bb3f0b-a8f5-4391-cecb-08db69605dcf
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2023 03:11:21.7343
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pOZEUP/v2khvX/pxWDLIvFn6aGe39MYfPreeFAsm2O/PAbL15f9Ryy/TIYv6hsE8uG6vQAJ6eYMtxtjdsNdSr+Ac77iVUhk/JAE9l/Yksn4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8363
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> The CXL driver plans to use cper_print_aer() for logging restricted CXL
> host (RCH) AER errors. cper_print_aer() is not currently exported and
> therefore not usable by the CXL drivers built as loadable modules. Export
> the cper_print_aer() function. Use the EXPORT_SYMBOL_NS_GPL() variant
> to restrict the export to CXL drivers.
> 
> The CONFIG_ACPI_APEI_PCIEAER kernel config is currently used to enable
> cper_print_aer(). cper_print_aer() logs the AER registers and is
> useful in PCIE AER logging outside of APEI. Remove the
> CONFIG_ACPI_APEI_PCIEAER dependency to enable cper_print_aer().
> 
> The cper_print_aer() function name implies CPER specific use but is useful
> in non-CPER cases as well. Rename cper_print_aer() to pci_print_aer().
> 
> Co-developed-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com>
> Cc: "Oliver O'Halloran" <oohall@gmail.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Looks good to me.