Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 10 Jun 2023 14:34:04 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     <mingo@kernel.org>, <vincent.guittot@linaro.org>,
        <linux-kernel@vger.kernel.org>, <juri.lelli@redhat.com>,
        <dietmar.eggemann@arm.com>, <rostedt@goodmis.org>,
        <bsegall@google.com>, <mgorman@suse.de>, <bristot@redhat.com>,
        <corbet@lwn.net>, <qyousef@layalina.io>, <chris.hyser@oracle.com>,
        <patrick.bellasi@matbug.net>, <pjt@google.com>, <pavel@ucw.cz>,
        <qperret@google.com>, <tim.c.chen@linux.intel.com>,
        <joshdon@google.com>, <timj@gnu.org>, <kprateek.nayak@amd.com>,
        <youssefesmat@chromium.org>, <joel@joelfernandes.org>,
        <efault@gmx.de>, <tglx@linutronix.de>
Subject: Re: [PATCH 11/15] sched/eevdf: Better handle mixed slice length
Message-ID: <ZIQZXMHvV3FKOquH@chenyu5-mobl2.ccr.corp.intel.com>
References: <20230531115839.089944915@infradead.org>
 <20230531124604.341527144@infradead.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230531124604.341527144@infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PXODzL4H9vSjNTEff8A+kjh3vhAAPOpobW21m2yaXJgz/5FOPSWUIKGSiGBM?=
 =?us-ascii?Q?kmdrgnB+L3e2Nt07dibpyvG3lWg8ynKrG2uPGl0RmHEfEsukjKjcAz+wPxgH?=
 =?us-ascii?Q?UlZaITrY4C0DnXOtsgKvG/7N8ZjFIAiLuNpfyBjPu5tNmWqgEiMuYyWTAX9z?=
 =?us-ascii?Q?pSIEgOjsX3J54gY+QIcUmfUnuIreQTyTMrr39xlQsSogZVVe/56OpjnJ/3Vd?=
 =?us-ascii?Q?Pk+QODOwTjMTSe/CkuQRDT3VpdbLTLjmLRGpA6EOtUdFjuZE/JMLRlsQwAxf?=
 =?us-ascii?Q?o88/9ltzbcHSMMp7uj2xeb4FryId4WD0n5ZTEB3cRWZKxH5iBIaZP73TPcBe?=
 =?us-ascii?Q?pt5yS3L0/cMWDOI4ZbnmulbhUQf8dW4uYvhX7UNL/VjzERhhHTywXYWvu78V?=
 =?us-ascii?Q?b9Fcl01SxEORPirG9PkxDd+LegnG/ObhPAF5G0Xa8tq4j8btqCTaho9AsQBp?=
 =?us-ascii?Q?9O5YE71y2I8bi6Z7Lvg+MmCoMj/Rkx6zSvqvVDtmZKka/mYHR5s85VLWKvmR?=
 =?us-ascii?Q?gEewH60YGs4wLgQGSt+UnXa8ACmeOj5b0phCmCYgmaBe39TWowKWEC/KKHeN?=
 =?us-ascii?Q?LnutuOxyK6B6Vt/CAWe+zbIDYesL4sGRAF3xPTo+lHz3X1UUPMbgxeoR8ZLr?=
 =?us-ascii?Q?LNaibfykUvsfNhyfu1Qe/r+xSYfFw2kANXaQiLWkKqmSo4VA1AKnf+ReGFxM?=
 =?us-ascii?Q?OehZBrsS6xiG7QEke/ycMZVIH9gmR52uhCBz1uRc9zPmHtNgxuiribWgkcSK?=
 =?us-ascii?Q?wkHN0Ug8mxW3LKO0LklEWyTsSc21okbJp6JlC86Ch2hVFyrnWE2B/wj6sk8D?=
 =?us-ascii?Q?z9pGYiP+3VvSirT3pNrGX+PS4tDbJJ7E/Wof2JPFt2lStRRF7n9BGapAJZNG?=
 =?us-ascii?Q?fSf8/9sdBPFrYeK3W69Rax64kGDdp6nYZ+rwnNpPOM9akwxMw9nB3nZ3iG3e?=
 =?us-ascii?Q?rhigxj8AjdHLilAnbJzkem4YAUufHSsv/ReEEpW3LyFJsj1YBzxJ6/Uznw0R?=
 =?us-ascii?Q?wrHdh0PjivPkq/wrbXCBtbYqk/ujvQenC7zdEhs+k0dMkoTGG3TWR/5Avb93?=
 =?us-ascii?Q?Dz6D++aSR+ZWLCbXHPAhcIwCV2BBCe4Ch0qy9GSrfBb6QKquBxbp+bK41oDi?=
 =?us-ascii?Q?gEiPM8yqI8/+ArF4J2JnGN45DCmGmUBb7kKQXXE0TTcDT+/DKQz4lC/8AqsY?=
 =?us-ascii?Q?sxMHCllmDpVqqVAGjwMjJbTydU5h+jnQd2uAcrRQDuE5+1dCN/oSINiaZQRJ?=
 =?us-ascii?Q?ku8lta3AJrD2xVB0FFN9QlG6/HE4jy6T4ytyKxVX6/vYjuvzKtWHdlyHNB7B?=
 =?us-ascii?Q?g1wvCEM6Oezd0+gf8BLiwmAg2l3JPf02m7p2ZX4r9SP956bkNoZzNhRVHO0A?=
 =?us-ascii?Q?Be4JurMvbZLpoh2Hvh/o7Yr+SHMnuTZ66Aj6qE8/ca9EH1XgpllFz3d/5m/S?=
 =?us-ascii?Q?0L6G65Qt+zA+6DXt6qn1AaT6bh/MacwMNXjMy6xS/XMtjzMschI2VDGwecrz?=
 =?us-ascii?Q?/oEp3KcGPP7s8MCYuHqn7w/OUOAyUMZSlj51MmYvNxFvyVoxaCWUzii/Q7u3?=
 =?us-ascii?Q?jg0iyVEy7wFI7p4qa0+si2LUsnP8MQRA0E/c3xcW?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 58c32d65-d21d-4465-a430-08db697cbc2b
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2023 06:34:25.8317
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: loufvZrYIMYR8dxnRwGRU52zy6MJMBvPbisOi96ojJ0nzI6i0tErWhr0BQSEpW5gs7w3eozzeF5rLOc+tsVt1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6047
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-05-31 at 13:58:50 +0200, Peter Zijlstra wrote:
> In the case where (due to latency-nice) there are different request
> sizes in the tree, the smaller requests tend to be dominated by the
> larger. Also note how the EEVDF lag limits are based on r_max.
> 
> Therefore; add a heuristic that for the mixed request size case, moves
> smaller requests to placement strategy #2 which ensures they're
> immidiately eligible and and due to their smaller (virtual) deadline
> will cause preemption.
> 
> NOTE: this relies on update_entity_lag() to impose lag limits above
> a single slice.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
>  kernel/sched/fair.c     |   30 ++++++++++++++++++++++++++++++
>  kernel/sched/features.h |    1 +
>  kernel/sched/sched.h    |    1 +
>  3 files changed, 32 insertions(+)
> 
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -642,6 +642,7 @@ avg_vruntime_add(struct cfs_rq *cfs_rq,
>  	s64 key = entity_key(cfs_rq, se);
>  
>  	cfs_rq->avg_vruntime += key * weight;
> +	cfs_rq->avg_slice += se->slice * weight;
>  	cfs_rq->avg_load += weight;
>  }
>  
> @@ -652,6 +653,7 @@ avg_vruntime_sub(struct cfs_rq *cfs_rq,
>  	s64 key = entity_key(cfs_rq, se);
>  
>  	cfs_rq->avg_vruntime -= key * weight;
> +	cfs_rq->avg_slice -= se->slice * weight;
>  	cfs_rq->avg_load -= weight;
>  }
>  
> @@ -4908,6 +4910,21 @@ static inline void update_misfit_status(
>  
>  #endif /* CONFIG_SMP */
>  
> +static inline bool
> +entity_has_slept(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)
> +{
> +	u64 now;
> +
> +	if (!(flags & ENQUEUE_WAKEUP))
> +		return false;
> +
> +	if (flags & ENQUEUE_MIGRATED)
> +		return true;
> +
> +	now = rq_clock_task(rq_of(cfs_rq));
> +	return (s64)(se->exec_start - now) >= se->slice;
> +}
A minor question, should it be now - se->exec_start ?
(se->exec_start - now) is always negetive on local wakeup?

thanks,
Chenyu