Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3095089rwd; Sat, 10 Jun 2023 01:06:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5mA659Pv88yn0HYCNaAuMSj03taANHQt2y6WPIAS7TxIWlVVN9BSAJ5/XWIxJROhDNRt4i X-Received: by 2002:a05:6a20:3d21:b0:10a:dd79:65bd with SMTP id y33-20020a056a203d2100b0010add7965bdmr8579897pzi.27.1686384403830; Sat, 10 Jun 2023 01:06:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686384403; cv=none; d=google.com; s=arc-20160816; b=tdWslxDF5MT1cqNnL95IYJAHq2oFcnaLinNIVw2w9+Ii5eZ8Rjy4oEYe8m+Us0htny QoUALf2S9Mk21uqUTvq5SSMzKhlXF4XlxHgRRtj5wF7jfvsCzGJ5uPrElD/bXlgIp30/ BQYaJf6a6Rg87k8JrwpuZ+OiRTY6himkmduyljrFU8vFdV7PEYgsrkjcCf21ITYl1CZx mpvsFh541AuCSM2nUmjun+087DqCK/p0s2ISTEXv4aTOZ6YGnEAWyzJPcv8nUDm6VNNi /0KK3yrGHn08NjOTsiBMnIRKgyMetJ8v2zjJO2nEheohMPKJTioNYFhOtZU8QBWKlzim CxDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=UmRbWljufOPyIQiIA7CHB8iopRQHod9Lz261qd58zvs=; b=V60NHtgYPJvRxEQXfc2oAwx/DJH+dr+A5QqBkbS6bKICzkfvbj66f7ZUT8elBdZs1N DtGLrA4aVSHPEIs59mOUy023YbNk7N44w3qQDoDn95xVubswVqNErihfX6ONIOCgVsX9 ekfVSBn4o3nV4Pyr3j7sDO+sDqieT+cXUIRTlM+jmQKkII6AC0Yn9XEmuwaRXwYhsu7D pRdNRTPFPggJtU7iF0NrImKuhTg9rhruAL6SCYlyyuGeTsszin48F/XyjFJiGWdy8gvi tVa1PSs4l2h+pu+tZQIJX1TiqrcVF+baUbrah/1hcKD3+DqfIM7W2xbZhVQUG0bfVBkB +KAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=nEy8SFw0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r7-20020a63e507000000b00524ecfa05d8si3948577pgh.15.2023.06.10.01.06.31; Sat, 10 Jun 2023 01:06:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=nEy8SFw0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230258AbjFJHtk (ORCPT + 99 others); Sat, 10 Jun 2023 03:49:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbjFJHti (ORCPT ); Sat, 10 Jun 2023 03:49:38 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 415943A8C; Sat, 10 Jun 2023 00:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UmRbWljufOPyIQiIA7CHB8iopRQHod9Lz261qd58zvs=; b=nEy8SFw08DDvJdj0bE8owjCgYJ MxplFsLBDrXPMjndU9aVtWXYozgH686nLhrIwfzoPEdmK3bZZcdbaZZywwF0Le//wtRCM+oL4rZjd xAXCGmj7bTdJOTw185oeGzARHKM/OsYXo7DgGaS0V+UKYBBfR2oiMcnwNooQm2kB5W3XzmT00TqDd nP0ts9vHWoRIVfAIxOYT5y5E7ctDiFERDzIAlQK0RyublDP6Rj37SfvqnsSilB/KqlE+gpg5yHjEs kKgxOEsmznIm+llwr1JrwtPJFEpmNk5ZhqAYwYd6PZVMqt5L3PbHPGRTOZu2cc3e2NpqWG9KZ416Z Qftgjt7Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q7tLS-00FUgv-1F; Sat, 10 Jun 2023 07:49:10 +0000 Date: Sat, 10 Jun 2023 00:49:10 -0700 From: Christoph Hellwig To: Demi Marie Obenour Cc: Dwaipayan Ray , Lukas Bulwahn , Joe Perches , Jonathan Corbet , Federico Vaga , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Lee Jones , Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/4] Rip out simple_strtoll() Message-ID: References: <20230610025759.1813-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230610025759.1813-1-demi@invisiblethingslab.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'd maybe say remove instead of "rip out", but otherwise this looks good: Reviewed-by: Christoph Hellwig