Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dca634f0-ca7d-1876-0702-6ecc194ac47d@huaweicloud.com>
Date:   Sat, 10 Jun 2023 10:00:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v11 0/4] evm: Do HMAC of multiple per LSM xattrs for new
 inodes
Content-Language: en-US
To:     Paul Moore <paul@paul-moore.com>
Cc:     zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org,
        serge@hallyn.com, stephen.smalley.work@gmail.com,
        eparis@parisplace.org, casey@schaufler-ca.com,
        linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
        bpf@vger.kernel.org, kpsingh@kernel.org, keescook@chromium.org,
        nicolas.bouchinet@clip-os.org,
        Roberto Sassu <roberto.sassu@huawei.com>
References: <20230603191518.1397490-1-roberto.sassu@huaweicloud.com>
 <CAHC9VhSzC0zV31XrEz06HKp=NNbz0XPT24ja0O1sZtNM_aXqHg@mail.gmail.com>
From:   Roberto Sassu <roberto.sassu@huaweicloud.com>
In-Reply-To: <CAHC9VhSzC0zV31XrEz06HKp=NNbz0XPT24ja0O1sZtNM_aXqHg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/9/2023 10:05 PM, Paul Moore wrote:
> On Sat, Jun 3, 2023 at 3:16 PM Roberto Sassu
> <roberto.sassu@huaweicloud.com> wrote:
>>
>> From: Roberto Sassu <roberto.sassu@huawei.com>
>>
>> One of the major goals of LSM stacking is to run multiple LSMs side by side
>> without interfering with each other. The ultimate decision will depend on
>> individual LSM decision.
>>
>> Several changes need to be made to the LSM infrastructure to be able to
>> support that. This patch set tackles one of them: gives to each LSM the
>> ability to specify one or multiple xattrs to be set at inode creation
>> time and, at the same time, gives to EVM the ability to access all those
>> xattrs and calculate the HMAC on them ...
> 
> Thanks for sticking with this Roberto, I see a few
> comments/suggestions on this patchset, but overall it is looking
> pretty good; I'm hopeful we will be able to merge the next revision.

Thanks for looking at it.

Just sent v12 with the suggestions. One is addressed with a different 
patch set (Smack transmute fixes).

Roberto