Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3463421rwd; Sat, 10 Jun 2023 08:07:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4FkkIuyC9WrHiyVAFKNDrbqL+dlOHqH+XEyH6xPtZzB7J4rp6duZ8ipyJgFXkONUF0GXyR X-Received: by 2002:a17:90b:3693:b0:258:d8fa:52cf with SMTP id mj19-20020a17090b369300b00258d8fa52cfmr3886109pjb.12.1686409669210; Sat, 10 Jun 2023 08:07:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686409669; cv=none; d=google.com; s=arc-20160816; b=Zfv7qcPqVFjpYbfKFqeZ3KKe55XmLUn73ocCM0/O+ReR6uUVVDMUKuGHWaK/YDBGeu /u6WkGm8g0KQFe5uEFzcB0+IEkeAzXxZbDJ2mHguqKkMwD+ta6Ods/1HRvkTJhjnG0Qo mC4P0k2DopGCRmCThmSUlNy1Y4gg7QvYs+kDBzRuHUfEPaKehoBnIwmiqoD3z+oqJXtr 3pE5NXuNi+gcYn0T/q3I6kbHTt+efBBRr+jXzAGIDP2plZX0SBi8FDBu4n9bzOxaPVvn DFHeDr/un4VTWMIsYkazAKPrXrMeFhlfA1Mo+17Zv2wZ54QUznmG8sC6bqXjn6WqX5OO 0xqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:references :in-reply-to:mime-version:dkim-signature; bh=b7Ik0zRfTsBIqeOl18BPqRgF8nNcLpxm1RVGGPM/mi0=; b=M+14zi0y6QwCaxicPFIuGiHbT6vbpr9r93kyyfkl+zcMjmRs3VEa/Fb9d5mUuH2XHa Lz5LPpgpJ3kfqkTFvvTI0ylA6R++v1VH28YTTZ04U9P36eS3DHCZNn3MxgAPdObk3idj q7eK3hXDOInxDaGH/gaw8vK1IJud9u0N0dWmIeudkMwI9o4oda3V5KRz5Yd0i8znDrYV MBLGM7dfFBI0TtqMAeru8jbz7XMPqMPUIK9lJpvp9/x433SBG1kz8MG4hxbRhRhRjUNK ipxY3vjadckvnjaaAbt0J1d5B2bD6utnyhuR+tNV9PSAp6mXVM2T3Lr17r4mfLgagP5e EqHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SJeF4Jc2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t11-20020a63954b000000b005340840c0c7si4195040pgn.476.2023.06.10.08.07.34; Sat, 10 Jun 2023 08:07:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SJeF4Jc2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235459AbjFJOkF (ORCPT + 99 others); Sat, 10 Jun 2023 10:40:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbjFJOkE (ORCPT ); Sat, 10 Jun 2023 10:40:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9081730EC; Sat, 10 Jun 2023 07:40:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0C47360F58; Sat, 10 Jun 2023 14:40:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BE5FC4339B; Sat, 10 Jun 2023 14:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686408002; bh=b7Ik0zRfTsBIqeOl18BPqRgF8nNcLpxm1RVGGPM/mi0=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=SJeF4Jc2us5hwri8rSuscA8pOaSh+e84B/uiIsFUJLGTdjF8G6255kK7nqgP73LzL ZcWO2le8RQ2JfhS08jYQLC9WcUyCNnrmVm+GZFRyN8XfBr2d5TaNLDG9NLawmgFCp7 KakpQK56b5oHFz605Mkuka+9cKYwNxx2be+B690/3RLmKtyFXBVHGaUvEVMYL4wtON 7lHwXQXDOwovRQWcszMynPtCmdPWpm/znY1fnjjw5I1fh9PPvrtvFC0iPX6Iz8UJFS pNMeeiWNarOmKdd+aLuFWvg3CF5ohxk+SvXNfBfUIccMVv14rpx4/QPxpm3l5Eq5JT vOvfy8Tak23WA== Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-39aa8a055e0so1304225b6e.0; Sat, 10 Jun 2023 07:40:02 -0700 (PDT) X-Gm-Message-State: AC+VfDx+FErH92o+jHzgoMTeH5iDqaBLuWQ6R1i7KhZNvJ0AqXl3nEXL DhjPvV8LSxsE1/QmqVumoBTm+phlXVpxgroDdIE= X-Received: by 2002:a05:6808:144c:b0:398:50f1:ad19 with SMTP id x12-20020a056808144c00b0039850f1ad19mr1123404oiv.39.1686408001597; Sat, 10 Jun 2023 07:40:01 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:774b:0:b0:4df:6fd3:a469 with HTTP; Sat, 10 Jun 2023 07:40:00 -0700 (PDT) In-Reply-To: <20230609050636.27669-1-luhongfei@vivo.com> References: <20230609050636.27669-1-luhongfei@vivo.com> From: Namjae Jeon Date: Sat, 10 Jun 2023 23:40:00 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] fs: smb: server: Replace the ternary conditional operator with min() To: Lu Hongfei Cc: Steve French , Sergey Senozhatsky , Tom Talpey , "open list:KERNEL SMB3 SERVER (KSMBD)" , open list , opensource.kernel@vivo.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2023-06-09 14:06 GMT+09:00, Lu Hongfei : > It would be better to replace the traditional ternary conditional > operator with min() in compare_sids. > > Signed-off-by: Lu Hongfei Acked-by: Namjae Jeon Thanks for your patch!