Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3591727rwd; Sat, 10 Jun 2023 10:26:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6jB32TlAhUD78m6bHifWWKSAxi5Bd+0ExAjCLrXc9o36UjPpFV9nFl2rMZR736c4nSXhpU X-Received: by 2002:aa7:c50b:0:b0:514:c3ba:d8f5 with SMTP id o11-20020aa7c50b000000b00514c3bad8f5mr1544363edq.10.1686417964312; Sat, 10 Jun 2023 10:26:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686417964; cv=none; d=google.com; s=arc-20160816; b=PV/x1M8NhRN59C5/SwvVcGNwZacKRkGM7wOxf1lAd+gf1HavmjFhT07O4+BRAQnyj4 zFyrFsau9tIBVyX/EfvdIqahQHzpmLplu+qNupDWyJSRjgiDPT1Pdy1GH/71vy1cSXDn QtBsYani0goMvi6+7Q08q+/1QNnoFTtENSaK3IUfsOurp1kvVUGLD/JN/qNBg557XJ8c GxrigGM8VrtPuEoVTbGKT7U7GXzhuyLCXvauCDhg/cixS3yQz/gp4lxQ/fbq4f1caBRj 7XGMUD3yugoEGsF+OvbibDfw+r/AbCosKH2Ww7XyOnrMPAv9QmbROSVuZfeoWoiSkGy4 Ht5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6/ljHa1TetfsMxIoQmiJpKoOzClakUJOlS+VDPzR2rY=; b=K2DR8W54Ts87m8nvhJGZ8b6f8+IWJdvLHB6S/ZjpZbfeB3XTSHnQIkRDMxU9dw8GKZ TJYA85GbSPUYJk7u96UwLWkLRHdyCYHGpbWBA6D2KmKCbrzUmmc3nIg7I9j3gkw1Mijk 3+uVa24vtJg78wLMUErhScNLcqrm3b3ZRpEfPKTGUkrb3rTT6RYLerkwnVhVJQBX7lv5 OTnQrmM/WF4fMbO1XZupOFYtuVE4TjQ2Tm+y66Wv7Fa4EGxEcTRQpfqUTx7F1DvUq/ei k+RoUPep+wakSjF+0vrCJvvI7+M+Rz6EMwrfkg4NLndzjG0iV0OvBlkq9Ao4cxBYBWk/ rYSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=srVZBakS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b2-20020aa7c902000000b005149dba2986si3782318edt.665.2023.06.10.10.25.39; Sat, 10 Jun 2023 10:26:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=srVZBakS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229522AbjFJRK5 (ORCPT + 99 others); Sat, 10 Jun 2023 13:10:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjFJRKy (ORCPT ); Sat, 10 Jun 2023 13:10:54 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C5062D7E; Sat, 10 Jun 2023 10:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=6/ljHa1TetfsMxIoQmiJpKoOzClakUJOlS+VDPzR2rY=; b=srVZBakSpNNQn5PW8fikii/viR cQvMUcdwiz8e0BBzSGPdHWzwnSkyfYlT3qGFSkBexJYzGzmnlqWH8ENxcfWyXEE9rWgI5CDxaOs23 4LY28r9gJENQWA+qUzzLrOrbs+mnkUXwc425rrZ4YGK5DcT0ZnEkwjWiABrxjt8jCK8Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1q826t-00FRzd-RI; Sat, 10 Jun 2023 19:10:43 +0200 Date: Sat, 10 Jun 2023 19:10:43 +0200 From: Andrew Lunn To: Jianhui Zhao Cc: hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mdio: fix duplicate registrations for phy with c45 in __of_mdiobus_register() Message-ID: References: <20230610161308.3158-1-zhaojh329@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230610161308.3158-1-zhaojh329@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 11, 2023 at 12:13:08AM +0800, Jianhui Zhao wrote: > Maybe mdiobus_scan_bus_c45() is called in __mdiobus_register(). > Thus it should skip already registered PHYs later. Please could you expand on your commit message. I don't see what is going wrong here. What does your device tree look like? Do you have a PHY which responds to both C22 and C45? Thanks Andrew