Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3805497rwd; Sat, 10 Jun 2023 15:35:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ44hRN/EoP1I4UntouYCwtBgNsX8a+wJokZVB/Qv9E5mgsh5AeKTyihXMUck6PFdGgzxsQQ X-Received: by 2002:a05:6a20:a218:b0:10f:8f7f:2c29 with SMTP id u24-20020a056a20a21800b0010f8f7f2c29mr4134108pzk.13.1686436550985; Sat, 10 Jun 2023 15:35:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686436550; cv=none; d=google.com; s=arc-20160816; b=FbWYb1rJDk1PCE9QtsMu/MLdZWDWgF4rba6D0geatbJOri20GqvLR8EIpI9Z28P0/f HPTTr1SxjEmS0Ujj29pD4m6hfz7ySL+V0adPSioBoZmbYYNoaLYtVRVXp3FG0VapypOL 6HdBtWjbLlUr2AkWG1s+WwbDItx6Fvu5x1hE6CozdVQ7zbiNLNAkNJu8ceU3d0/14Ka3 QoWwVyHx8HplZw4rd9Yp6YC7bV1K9/CoPesy5e8xoyIZvvAB6IAqOviWfm/x2yDublHg XFzcLWtnvuq39v8rNpNgh3qVEJVSp/XM4BnndIU2OVj3vAKvoqK9yVlWpNBAD8dwEUyg izzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=jVZzPX6ySJgTLx7rG1PlEmES+KNjRD+EkEdNbnlOS88=; b=ULUZsFBriYn5uN/W69uR54s38ThSqAXsD26RyRvvF3Vud272iIp+Zt0YBt9QC9cDeL dbwo0MwK9i75kF7v849d1ioQSTE/jND8gDGUwXvLbwBFmZbrVjUVwPjUsE/QpwQpk9+0 0ybiXQIJ8MV6s1qvNjfYvFxwlO30rg2sFobhBGIQLHbj+6EcbWfG6YzrGn39nd9aFEIg 6mynvbgW21Bik2Mwcvr3jELZ5y63ksgEWeeel47qonrUlhDTo3rqzwIGhqe6xBhpzbRt HbzbKeXclVRTQoL4v0J1Qy36aCkxET6hDfQlH4Gfswkie8ISAth43sGpS/847x4FAqLW LsZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=b25T5Qe4; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v186-20020a6389c3000000b0054295d91e63si1220615pgd.604.2023.06.10.15.35.39; Sat, 10 Jun 2023 15:35:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=b25T5Qe4; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbjFJWIR (ORCPT + 99 others); Sat, 10 Jun 2023 18:08:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229533AbjFJWIN (ORCPT ); Sat, 10 Jun 2023 18:08:13 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 720563A89; Sat, 10 Jun 2023 15:08:12 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1686434889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jVZzPX6ySJgTLx7rG1PlEmES+KNjRD+EkEdNbnlOS88=; b=b25T5Qe4kt5MEyfeX2GABqTnk9yjLItyquzWcx2uF0ipsqgMJo+Jd06bI9wtxSVxGwD/fg nz+i3ogEhNW+eOrE/+j7gQxfpsNLaPE4I9xtkoLRJjP1wegoLl4ky+Ib5h0qVFn3Ktwb71 mcFIsaywBASu+DAaFu7RCo3rCLXQEaKGMXPEhuFLXkh6xtZXFhgu6gwACW9KC0awg7WVtW eNJ4emR5imFeA2He/z1nGztGSklYh3+dKykgJh/tmNsdAvW+EIDUBRGKFBpogE0EUkeT9F yKNajzrDDN7B3NN9z9N3qg6MEwP2ppmAgPDyQ17i45iAAjb3JHBsmFJ3XIxaSg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1686434889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jVZzPX6ySJgTLx7rG1PlEmES+KNjRD+EkEdNbnlOS88=; b=F0OuUI0fMxtyjvJSBkwniYXqfNSWA+CQmKGCPAp9LUuUIenY+Pb43ltP79gk0gHv6mQJtn Miqvo/wls8h5U9Bg== To: Michael Ellerman , linux-kernel@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org, ldufour@linux.ibm.com, bp@alien8.de, dave.hansen@linux.intel.com, mingo@redhat.com, x86@kernel.org Subject: Re: [PATCH 3/9] cpu/SMT: Store the current/max number of threads In-Reply-To: <87fs6z80w5.ffs@tglx> References: <20230524155630.794584-1-mpe@ellerman.id.au> <20230524155630.794584-3-mpe@ellerman.id.au> <87fs6z80w5.ffs@tglx> Date: Sun, 11 Jun 2023 00:08:09 +0200 Message-ID: <87a5x77yye.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 10 2023 at 23:26, Thomas Gleixner wrote: > On Thu, May 25 2023 at 01:56, Michael Ellerman wrote: > /* > * The decision whether SMT is supported can only be done after the full > * CPU identification. Called from architecture code. > */ > -void __init cpu_smt_check_topology(void) > +void __init cpu_smt_set_num_threads(unsigned int max_threads, unsigned int num_threads) > { > - if (!topology_smt_supported()) > + if (max_threads == 1) Which makes topology_smt_supported() redundant, i.e. it can be removed. Thanks, tglx