Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <599cd007-5026-18fa-462f-fc18f9518953@nvidia.com>
Date:   Sat, 10 Jun 2023 23:09:23 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] drm/edid: Add quirk for OSVR HDK 2.0
Content-Language: en-US
To:     Jani Nikula <jani.nikula@intel.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
References: <20230609014207.2759720-1-rcampbell@nvidia.com>
 <87y1ktqa75.fsf@intel.com> <09cc666a-bc52-44b3-230c-26dc705c5a56@nvidia.com>
 <87r0qjpyrr.fsf@intel.com>
From:   Ralph Campbell <rcampbell@nvidia.com>
In-Reply-To: <87r0qjpyrr.fsf@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWtFdHpRc1B0SHNST1FRcDBuV1RQNWU3QjZUczFTYjNGYlpTaDk4NlNOUExp?=
 =?utf-8?B?VVBHdGw2Ymh4ZmJIMUcwVGc2UkZmYW1BVktKTHVVVEpCbG5zanZkMmEweGs2?=
 =?utf-8?B?Wjd3a0NrQmZ1QmFVb3hRYkJOYnBrSno1WkRobElDcjJmUWF2c1RRZjJZcmUz?=
 =?utf-8?B?UExJZE1pMkNGQTllcTZHOU00ZlZYNm5YK1pXaUszdlVYUjA4TStxd3NJQzEv?=
 =?utf-8?B?OXJNbWdmSGVyN2NVTDUzZkllNTRoNVNOQUJiZ3JVS0gxVDlwQnJnMkFNaC96?=
 =?utf-8?B?TFZMcmdTeHBxS2g4RVpLUnpaRldXdXhMODJicml4K09Pek5BdGhXMnN4WFBF?=
 =?utf-8?B?bmpXcEsxU1Y5aHlMN1h2ZElDdkZVaDlQb0c0TnZ3c0JNWndPaHN1dldhaVA5?=
 =?utf-8?B?Rm1zSEJwTW9Sam94NmdObjZwdjQreWtFc3ZyNHlDd2FGSk10MUxkR3ZJc1N4?=
 =?utf-8?B?U3BLbExRZTExblIyaWFnMzMvUDAvaElEbTBMWU5TTnJ2ZEZTMzFiVlFLKzUz?=
 =?utf-8?B?SWtXWHptUncrS3FNMGo5SGtUNkJVdUROaVp1S3daMUdDNWJncm5Cd2ZoSDM4?=
 =?utf-8?B?WVB6UnhzMGtyL1MrZUV0VkZnVmZrU2U4azVLV1JxS3UxeXFpNjNJemJ6Mmdo?=
 =?utf-8?B?WC84K3Rrc0pBVmRBV0M1UnJaeUkvNjRYb3d3M2tWYzJpRVhlSXZxaVg0cEVR?=
 =?utf-8?B?WmRjeXovVndlQzlGOVQ4YzBHaUFJeG44bWMrUlVGQnNBbTBPL2hsa1FQVm1B?=
 =?utf-8?B?NUJhQVRBOCtxTWhudzNOa05CY1hPVnVWS2F6aTY2ZkpaelV6WldOcWVudGo0?=
 =?utf-8?B?MXJPNDQ1RmJ6SUFPM3lMYjBZTGMybGEvTzVHbWVzUk5IdTJadk1nTlVjZkZo?=
 =?utf-8?B?bjZiMXQzSEhuSEFJT01PY1IybG1ESTBmeUIzZmtlSGtyaDY5VmN1UzdSUllB?=
 =?utf-8?B?allaSU92SkxxRmtNQjUxTHQ1K0d2OXI3WkRJOXNxVTNyWGF3bkFUaUlNWHZT?=
 =?utf-8?B?Qk8va2FsR1dacEZOMlM2SFZVMnNpeU1sSThYUWcxZ202eDFKRU9kZXlzVzNE?=
 =?utf-8?B?VHhzQWxWWmxPK2FzS1pHcExuS0tFMUp4azBBNHM5aURlcmR5ZGpyNVgwbmI2?=
 =?utf-8?B?RFVmZjRqamluUHRJSENVVW14K2ROZktNL2tDQnZwNjAvQnQvbzc2bU9ObVM0?=
 =?utf-8?B?RlRUSE5abEozOVhndG5vbEVpdFNrSTNmeGV3ZWJoL0wvN25GV3BZMGZwUURX?=
 =?utf-8?B?cExkejFCVFluN2VFTnliemN0K1d6dU5DM0VqbThBdTlhcFVPMjVBZXFleFFy?=
 =?utf-8?B?Z0pvQU1Bd2VOM0xKcGNqcExTM2JMRUVEZDh3NHVpRmNjQW54SDBJdUFIZ1R5?=
 =?utf-8?B?bDNiUnNFQ1FlMHpNNkdGQmVMOXhZamRTcU1hSGVGbU9jd25QRys4OUlnVGtv?=
 =?utf-8?B?VkgzNUZucjh5N0ZQVU1vaXB1OVBoY0l5Szdtd3BQeFArNDdnZkJaemlFa01O?=
 =?utf-8?B?RVBNQmN4dEM2c3M4bUt3YU1zVW5VMHZMbjU5VTNnY3YzbWl4MC9NaEhUMlQ5?=
 =?utf-8?B?Q2lnbkVLUU5oZ2c5ckF0Z05QSWExa3F2MW0vanEwN0g1MzUvVnpaMkZlaWln?=
 =?utf-8?B?cDZaa0Y0Q0N6TWF5YVdFVEg1VC9RUkhHSGlJME4zVld6VENzQ1JBYnZMUGZt?=
 =?utf-8?B?cXd4TTJ3WlRDT3cvc3RCR3dOSmtsc0hhblNXa1ZsZUg4QXB5cUhvdXgza2tF?=
 =?utf-8?B?WFBMZWZzbkg4V1pyR3Frci9GbjNRSVI1OUtmMDc1cEpscFNWODVWOU5CNGMy?=
 =?utf-8?B?NVRuY1hEYlRTMzhCMGNCS0lja004cmpGdjc3QVB0dWN2NWpaZ3psSmtHOHhw?=
 =?utf-8?B?a1FqZmRZOVpETEE1aVQyT01WdXRFOWx1bE5NQ25aeTVNalVyTnBLVVR0VHlq?=
 =?utf-8?B?WXgxTXE2TTVYRUlZQjVLOU9mWm5vMmtzTXd6WWpzUTRVb1JkVWNIdTdUblJo?=
 =?utf-8?B?bDhDVGJkWmRjczFjNVVXR05iNnd6MGFEaUF4clV3THYxMlQzaHdsSVlwTU5x?=
 =?utf-8?B?WG8ybTh2NGUyaE0ycVBTd3REeXZadzNlTmV5N3lxNmFBbzF1d3VkbUhVVnR6?=
 =?utf-8?Q?swjuMkePZflTLS/0QClN/Xria?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 916cc04d-6a78-4491-4da2-08db6a4268e6
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6150.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2023 06:09:26.4572
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oufDu1xUKGEuhd0j1BGIKtpnXId9LHfEMHubMu+BKRtUnBxxfQu78t5BcCsjtArBzUsUp2qBXwRmuqJ0QB9dYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4420
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/10/23 00:22, Jani Nikula wrote:
> On Fri, 09 Jun 2023, Ralph Campbell <rcampbell@nvidia.com> wrote:
>> On 6/9/23 02:03, Jani Nikula wrote:
>>> On Thu, 08 Jun 2023, Ralph Campbell <rcampbell@nvidia.com> wrote:
>>>> The OSVR virtual reality headset HDK 2.0 uses a different EDID
>>>> vendor and device identifier than the HDK 1.1 - 1.4 headsets.
>>>> Add the HDK 2.0 vendor and device identifier to the quirks table so
>>>> that window managers do not try to display the desktop screen on the
>>>> headset display.
>>> At some point in time we requested bugs to be filed about quirks, with
>>> EDIDs attached, so we could look at them later, and maybe remove the
>>> quirks.
>>>
>>> The headset non-desktop thing started off as a quirk, but since then
>>> we've added both Microsoft VSDB and DisplayID primary use as ways to
>>> indicate this without quirks.
>>>
>>> BR,
>>> Jani.
>> If you want me to file a bug, I can do that and I have the EDID too.
>> Where would I file it?
> I suppose at https://gitlab.freedesktop.org/drm/misc/-/issues
>
> We should then reference the issue in the commit message (no need to
> resend, this can be added while applying).
>
>> I did see the DisplayID 2.0 code. This headset is no longer being
>> manufactured so updating the EDID is not practical.
> I'm not saying the EDID should be updated, just that we might drop the
> quirk if we find another generic way to identify non-desktops that
> covers the EDID in question.
>
> If the device isn't covered by the existing mechanisms, I'm not opposed
> to merging as-is, with the issue reference added.
>
>
> Thanks,
> Jani.

Thanks, I created issue #30
"OSVR virtual reality headset HDK 2.0 not recognized as a non-desktop display"

>
>>>> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
>>>> Tested-by: Ralph Campbell <rcampbell@nvidia.com>
>>>> ---
>>>>    drivers/gpu/drm/drm_edid.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> I don't know how many of these VR headsets are still around but I have a
>>>> working one and I saw and entry for HDK 1.x so I thought it would be good
>>>> to add HDK 2.0.
>>>>
>>>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>>>> index 0454da505687..3b8cc1fe05e8 100644
>>>> --- a/drivers/gpu/drm/drm_edid.c
>>>> +++ b/drivers/gpu/drm/drm_edid.c
>>>> @@ -230,6 +230,7 @@ static const struct edid_quirk {
>>>>    
>>>>    	/* OSVR HDK and HDK2 VR Headsets */
>>>>    	EDID_QUIRK('S', 'V', 'R', 0x1019, EDID_QUIRK_NON_DESKTOP),
>>>> +	EDID_QUIRK('A', 'O', 'U', 0x1111, EDID_QUIRK_NON_DESKTOP),
>>>>    };
>>>>    
>>>>    /*