Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230609120636.3969045-1-arnd@kernel.org> <b3a3e2f8-51d8-f8ce-95ce-1180f80cc2d2@habana.ai>
In-Reply-To: <b3a3e2f8-51d8-f8ce-95ce-1180f80cc2d2@habana.ai>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Sun, 11 Jun 2023 12:50:31 +0300
Message-ID: <CAFCwf122kE8sNksXivPA+E=BWzjroKowwqDJrHVMNj-o3oJq0A@mail.gmail.com>
Subject: Re: [PATCH] accel/habanalabs: add more debugfs stub helpers
To:     Tomer Tayar <ttayar@habana.ai>
Cc:     Arnd Bergmann <arnd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Ofir Bitton <obitton@habana.ai>,
        Ohad Sharabi <osharabi@habana.ai>,
        Dafna Hirschfeld <dhirschfeld@habana.ai>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 9, 2023 at 4:37=E2=80=AFPM Tomer Tayar <ttayar@habana.ai> wrote=
:
>
> On 09/06/2023 15:06, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Two functions got added with normal prototypes for debugfs, but not
> > alternative when building without it:
> >
> > drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> > drivers/accel/habanalabs/common/device.c:2177:14: error: implicit decla=
ration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'=
? [-Werror=3Dimplicit-function-declaration]
> > drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declar=
ation of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove=
_file'? [-Werror=3Dimplicit-function-declaration]
> >
> > Add stubs for these as well.
> >
> > Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks,
> Reviewed-by: Tomer Tayar <ttayar@habana.ai>

Thanks,
Applied to -fixes.
Oded
>
> > ---
> >   drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/acc=
el/habanalabs/common/habanalabs.h
> > index d92ba2e30e310..2f027d5a82064 100644
> > --- a/drivers/accel/habanalabs/common/habanalabs.h
> > +++ b/drivers/accel/habanalabs/common/habanalabs.h
> > @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
> >   {
> >   }
> >
> > +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> > +{
> > +     return 0;
> > +}
> > +
> > +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> > +{
> > +}
> > +
> >   static inline void hl_debugfs_add_device(struct hl_device *hdev)
> >   {
> >   }
>
>