Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1d532c45-ee33-9729-f0ac-b59c2bec8d7d@siemens.com>
Date:   Sun, 11 Jun 2023 15:38:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] rtc: pcf-8563: Report previously detected low-voltage via
 RTC_VL_BACKUP_LOW
Content-Language: en-US
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Alessandro Zummo <a.zummo@towertech.it>, linux-rtc@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <da84b6b1-a9d8-ce46-16a9-e1a2d495240c@siemens.com>
 <20230610083135e40dd2f6@mail.local>
From:   Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <20230610083135e40dd2f6@mail.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHY3VE4xS3ZSbWQza2VxK3N4L3IyUDloS2NXd3FPVlZjNlVwdTVJWDRvUjll?=
 =?utf-8?B?VzI3T08xS0prN0dSMmg0cGphSjdsTW1SdjBaOHZuTCtaNmM2aDMza1J5RGgw?=
 =?utf-8?B?QmNzdDdPNHFwc2JidC9qMlJITzlwOVJCd1FMVEE3WHFiK1FhSEtDc3IrYzBk?=
 =?utf-8?B?eENyaEFOeFh1NWszRWVuQXhWY1graWw3U09SQ1Z5UG8xTHJ3SEpEVFA3YWlP?=
 =?utf-8?B?Q1FsZVRFTTg4UFYzQURXaTVzcGNkbXZ6ZkRLZG1zaSt6SkVKWUM4RWdJTXh1?=
 =?utf-8?B?aDBJeWN4RHNtdEYveFJneG11aTI4TXgrY0dic204akU1OFh1N29XQUlKb3VO?=
 =?utf-8?B?akwzQlExRjgwSzErTnh0VVR6MWRYb0xyQnpJYVdnMnB1ZVVsYzg0ZFF5bGY4?=
 =?utf-8?B?bGQ2OGI4aGhLb3hldTJSSEs4T0xRbjNKZjFtTzVGaklBazlBVW5HcWNrUU5Y?=
 =?utf-8?B?L2JSc215QzNDMGEydjM3T1RwU2xabHhVUU9rQlVzQUJiL2svVzBGNGN2emV5?=
 =?utf-8?B?ckpzVUY2dWZ6MCs5MWZUZjZ5U1ZvUk83ekZleTM3K2cvTCs3dHJkRkFoV1Rx?=
 =?utf-8?B?aEdhZzR6d0tsdXZwTlVNeGlRb1plQ2Vjc25wdjg1cnZSSTF5ZTBUdkJrNy9n?=
 =?utf-8?B?Q0d4eHM1R0N4STYxa1BEKzB4d1IzSkRyV2hUcEV1bkxrZGhIaGp1elAyNTlU?=
 =?utf-8?B?NStFUXlvVG9yd1N1QjhXSDJqZ0JtM1F3cXJDMFVPYXNlYklwT2ZOdEJHVkJK?=
 =?utf-8?B?ZjhwR0hVY2p4Qm9uem1XWFJoOWFxUmZZK1NTUXhqKzVUNm5TQmY5VWU1cFFo?=
 =?utf-8?B?MDg1N3RFWG9DWXcyOWEzcDY1anZ0RHNONEl2dlIvNHQ1STBkdGQ0Zy9CZFJC?=
 =?utf-8?B?MFoweTd3U1g4c2NrQjhacGwvM3JnZ0tMcmdSVGFocnhjNTc0dUhZR1R4b1NL?=
 =?utf-8?B?OGxISm1Xb1lkRk1td3Zmb2RFY2Z3MStuL2FUOWJqaEFjZmZnVXMrSXFlN3U1?=
 =?utf-8?B?V1FwdkROcWFRR0hJUFJRTjRtc3dPdTJkUHFWOWxDZWJ5TlNhY0VFODQ0RHFi?=
 =?utf-8?B?c1pUTlpTTk9HaE1QemhQQ1d2N3RGZ3ZhZU1UMURMejRSWUtIVHRXVksycFg3?=
 =?utf-8?B?U2JyQTZDQmZuUWR4aVRZTldHRkFkQ2dYWjRQYlh2YVNTbUpyMVZ6QS9GYzhp?=
 =?utf-8?B?dVcyNjJuR0VuaDN1ZFl2TUh3U0xMT3BuTis3R1VGL29ZS2EzYWpVUmlCM3Av?=
 =?utf-8?B?Q3RpM3FBbUlwZ2Y3cUVtOHNyM1FqS2FLMFYrN252R0d4eFE4K05BaTJ5MDVX?=
 =?utf-8?B?Mk1Pc0RwajkyUDM4Wm5YSXM0ZHVYenZKZytGRkYrRkUwUzRLQUtuQ1BZaCtp?=
 =?utf-8?B?YVBheG11SjNvMWJGWFVRajExam5OZlhLQUo4eFZKVzJka1NQdWdDT1drTzRR?=
 =?utf-8?B?VjdMbzczU3RtaEJxbGtqNnVkUDJtZ0pZempUWEFja1hFbFJvQVM1SDZ3Zkhx?=
 =?utf-8?B?bzZNN2JhQW5oV0NJZytOc0lGWGt4RXlGYk1JUTNNQWwwWjUvOXVINjBGcVhH?=
 =?utf-8?B?bFNOaDhKOThZZ2NiOGw3TU5NOG0wZStVa05NTWZnQm5HY1JERlphVmRpOExr?=
 =?utf-8?B?K09ZaitodG5pbGEwOERpc2YybnRyVFRIME9ESkxuQTIrV2xzaklvOFpoaDUz?=
 =?utf-8?B?ZG9YbThiQjhIdCs3Q2tuZ3VQNWVNb0E2YWQrMWNrOG80VmdtZk5HWE5CU1Y5?=
 =?utf-8?B?VmxjU2xEUC85T2dNU2JOMGZtejQ1QXVKVDd4WUYyMDkvcUY4MzFsYnJkakNt?=
 =?utf-8?B?RHBIckZyV1NYY1lqTzF0ZXJjZ1R2czZmMkxzSEMvUkdDUXdmbG9QbW5LU2Zs?=
 =?utf-8?B?d2RlaUlYQUx6U2NCblAwM3VEZ0hIVGZqNThmYjBZekNEYjRLU2N3VDlqNGpu?=
 =?utf-8?B?UkRFb0pvM1FWQWtBQ2NiTVI3ZGFBdFUwUEF1RllFN1MzTmNRMmFUamFIKzNs?=
 =?utf-8?B?S2J0dXdzbjljZzlnaDJqMEdkSEEvMnhhSTJFa0V0TTFEd3lONXdzaWZpQ0FM?=
 =?utf-8?B?aFM0c0h3VlE3MFV1Tlk2R2VPc0tocHhaOXBudGhMSUM4bFdXbUMxanRUVEp6?=
 =?utf-8?Q?1CzPsEBKRqvTwT8Lz2+ZwXI8y?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26eae13e-4e60-47d2-1e67-08db6a811850
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2023 13:38:09.7438
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u9/cmUrhMfWOhBbGh1DKq2/ThEZcwJFJ6YLr1BKbr718t6E4ejTMFkBrNfnAiN0xkdkethtU88Ox507zSBRELw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7048
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10.06.23 10:31, Alexandre Belloni wrote:
> Hello Jan,
> 
> On 09/06/2023 23:04:12+0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> The VL bit in the seconds register remains set only until seconds are
>> written under main power. As this often happens during boot-up after
>> picking up a network time, make sure to preserve the low battery state
>> across this, caching it and returning it via the RTC_VL_BACKUP_LOW bit.
>>
>> To permit userspace clearing this state during runtime, also implement
>> RTC_VL_CLR that works against the cached state.
>>
>> This is emulating RTCs which have a battery voltage check that works
>> under main power as well.
>>
> 
> Emulating doesn't work well and I deliberately chose to not implement
> it. For example, in your scenario, if you boot twice without using
> VL_READ, you anyway have lost the information. This makes emulating
> unreliabl. The fix you need is in userspace where you have to ensure you
> read the status before setting the time.

Then let's make sure the bit is also set in the hardware register. Then
also the reboot issue (which is practically a minor one) is solved. The
current situation is far from optimal.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux