Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 11 Jun 2023 17:11:58 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Jianhui Zhao <zhaojh329@gmail.com>
Cc:     davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com,
        kuba@kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH] net: mdio: fix duplicate registrations for phy with c45
 in __of_mdiobus_register()
Message-ID: <c7ca97c3-720b-494c-9865-b77252954a04@lunn.ch>
References: <20230610161308.3158-1-zhaojh329@gmail.com>
 <20230611145728.655524-1-zhaojh329@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230611145728.655524-1-zhaojh329@gmail.com>
Precedence: bulk

On Sun, Jun 11, 2023 at 10:57:28PM +0800, Jianhui Zhao wrote:
> Sorry, I misread the code.

So this is by code inspection, not an actual device tree booting on a
board?

What should happen is that __of_mdiobus_register() has:

	/* Mask out all PHYs from auto probing.  Instead the PHYs listed in
	 * the device tree are populated after the bus has been registered */
	mdio->phy_mask = ~0;

So when

	rc = __mdiobus_register(mdio, owner);

is called, no scanning happens. I _guess_ that is what you missed?

   Andrew

-- 
pw-bot: reject