Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8a52595f-085b-3b68-0082-e9f9487dd331@wanadoo.fr>
Date:   Sun, 11 Jun 2023 21:13:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 2/2] hid-mcp2200 - updated hid-id.h
Content-Language: fr, en-US
To:     Johannes Roith <johannes@gnu-linux.rocks>, jikos@kernel.org
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230611164811.1388-1-johannes@gnu-linux.rocks>
 <20230611164811.1388-2-johannes@gnu-linux.rocks>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <20230611164811.1388-2-johannes@gnu-linux.rocks>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 11/06/2023 à 18:48, Johannes Roith a écrit :
> Added Product ID for Microchip MCP2200 so the module can be compiled
> correctly.
> 
> Signed-off-by: Johannes Roith <johannes@gnu-linux.rocks>
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 5d29abac2300..b48cb8224e0d 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -912,6 +912,7 @@
>   #define USB_DEVICE_ID_PICK16F1454_V2	0xf2f7
>   #define USB_DEVICE_ID_LUXAFOR		0xf372
>   #define USB_DEVICE_ID_MCP2221		0x00dd
> +#define USB_DEVICE_ID_MCP2221		0x00df

2 times USB_DEVICE_ID_MCP2221 with different values?
USB_DEVICE_ID_MCP2200?

Also this one should be merged with patch 1/2 or sent before the other 
one, otherwise  1/2 can't compile.

CJ

>   
>   #define USB_VENDOR_ID_MICROSOFT		0x045e
>   #define USB_DEVICE_ID_SIDEWINDER_GV	0x003b