Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8e3176e3-8eb2-de7f-cc79-d04fe48ab8e6@axentia.se>
Date:   Sun, 11 Jun 2023 23:04:37 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2] mux: mmio: depend on REGMAP as the code has that
 dependency
Content-Language: sv-SE, en-US
To:     Randy Dunlap <rdunlap@infradead.org>,
        Philipp Zabel <p.zabel@pengutronix.de>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <64cf625b-2495-2382-0331-519d1cab0adf@infradead.org>
 <d1a3d8dd-213b-3772-17a7-c08e06cab837@axentia.se>
 <89199aca-5b57-e8df-03ca-b2658ee9d8b3@axentia.se>
 <20230210115625.GA30942@pengutronix.de>
 <31f2a49f-bc48-d502-df31-667ef1a83fab@axentia.se>
 <946cea0c-6d7f-c2e3-4412-4967ece40b94@axentia.se>
 <fc94fa7f-2e73-7b9f-ea4c-2c5dffcbf844@infradead.org>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <fc94fa7f-2e73-7b9f-ea4c-2c5dffcbf844@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFdpUnk0ZVNmNDJTSzJKSU5sZG50SG5KMjl6SjlQWlVGZENpVFBlZ0o1Y3dy?=
 =?utf-8?B?TE1za0w1YTJMUDhtR21zNGQvbEVQMk9USjZsY1c2b0tXUUdxVDZiOTVuak8z?=
 =?utf-8?B?SytFTDRiVGN0TGhHTy8wbFdNMlQ2OVlLSnI2RnptcUE3dW5JQVFNY3VPVlhI?=
 =?utf-8?B?ZERFY2hpWGcrek5XaE5GVmdlVGhHVUZna1pJTlFuRXpVVlJJZ21CTVAxeVhx?=
 =?utf-8?B?aE1wSVR5QWZCZVNkZlNueU5tbGNwa3M3VmxURkQzVTRseDBrV0JsbnpKbkdu?=
 =?utf-8?B?NHd3TUxEdk4vRTFEMUJZbzRCV0xMeXVQclBGdFZzSlkyTXl6L1hZYWVwOVhV?=
 =?utf-8?B?bjNmR1pkekU1WkdJWVJSSGpVbFR0K3gvU0F4dnNLVGg0U0RlNlN5c0pubXJC?=
 =?utf-8?B?aXBaNW9GdHU3SXhZb3pjNkFNdERTcUJPemVpbFFNZG0xL1F3Q2VTWXcvS3Ix?=
 =?utf-8?B?YVlWOGZuQWpsVjZXbGJWcmdpVXkvNHEwZFpBTk5kK0ZBcDJSTzZKaU1wYVZX?=
 =?utf-8?B?cUpuQ3UyRlBpVkdCUXQ5N2xsbm1LS2dadFVnb1A3M01Cam1NNTZDS0drQ0xq?=
 =?utf-8?B?MVp3NVJ0UEN4ZjdkVGJhMjhXUlI3ZUhSclFLZVh4VzRaRDIyYU9rMDJSRGs3?=
 =?utf-8?B?aEh6QjF5UlpmWC9RSzVyQzhMbERFaEM0aEFWWkJYcit3b0NVYlF3Ly9WNWhQ?=
 =?utf-8?B?Tm9ieTNRQ3VPQk9Ub0tBQkQ0VUszaTdFRVNLb2ZJUHJVRzdMU0pvL1BMOW1t?=
 =?utf-8?B?YVdKTFBYbnpQYlNGaGFVeGJLVUtXNWpJd1ZlMUlwdnNDZGpJZWppL2xhQ2Z2?=
 =?utf-8?B?dnJsczVJQ21UWU1ybkxLcUZDN0hqVlBmTXVqa1p3bS9lNEtjZWdjbEo2bWM3?=
 =?utf-8?B?MHIvQmlQNXN3a3NTaXBsNlZZU1o4S3JFRFM4QTl3bjdBSDNRdjBqUmZVVTgv?=
 =?utf-8?B?RFgxQVBsQkxEYW5QOWsrcnVYTEYrTG9ZYVBoclpkTmMwbzF1M0FiaU5jQUZo?=
 =?utf-8?B?d2FDTXc5VTlpUWhXamtMaFlxSTVXUXV1RVUrUUl2aWJSbDgvcmI2TkY4Mmh5?=
 =?utf-8?B?dGs3bndHNWJFSDJ5d0ZkU1VkQkFQUHJncmJCeTVqTHovcEI1WGJXaWN4Umsy?=
 =?utf-8?B?amVvV01WZlFVYk1aM1EvSk5kM01wY21YdU4xTFJOeVBWTXdvSUdtYkY1WmZY?=
 =?utf-8?B?Y2Y0YVdwd25pekNyNTgwN0RYb1ZLMklyUk5YRWZXb2xtWEJXRlc4YmRjRUdU?=
 =?utf-8?B?RW92VzYvL3llSFVOVEQyS0NJaERGSUo4Y2p4MDZONnY4VHJJemh1WHhOM1RK?=
 =?utf-8?B?RlFVVkVHV201aVlKWnFXenpLWm1ZWlRUYzRGc0piS1c1cVR5bkx3dElIZC9J?=
 =?utf-8?B?U3AxeS9KTjUvV09JQS94azR5TGtVdTVZOVNMRDFVV3lIZXVScTAvQkNFWGdJ?=
 =?utf-8?B?TzBoMkhMa2hIYzRjakZQbkNxVjdkeTFJVkFLYXVvcFhFQ0tnZ0hnTVZ4UEND?=
 =?utf-8?B?cnhrYVpDcUNsajFWdkxsV3lxNW1qRDF2OVZuYStXSExsQ0JhS2VEZ1RjSU9R?=
 =?utf-8?B?Q21xY0cwd29mbHJwWllUNTA3UkJPdTVUS3hCS2MvbzRhUXg1elZ2ZFR2b3dJ?=
 =?utf-8?B?aUpWUUNXQ0pLUVhDbWJrejJaRE9VOEhCZzZYNHkrWlZHcXNFdjJhVjFXWUtY?=
 =?utf-8?B?N2dqSHJBUk1GUWVJRkl0SEpKQnhVemR6RXRpQWVyS1dNVnBQaGxDOUpxU3di?=
 =?utf-8?B?R3BHTWV5ajNheFhvNENHUDhraTZFOTNsOFRTWEFsWW5kMzU5THFaYSsyN3BP?=
 =?utf-8?B?cFE4dTdUZjV2cWYzVUt0QzMyNlFwc21BTlNSc2tKQ3ptNHI4NzNVOCtKTEVV?=
 =?utf-8?B?WTVCU0l6OTRzVzU2TVZGL0RKN1h2Z2lwSWFISWNxUUc2V3RIZGZCcEZnOEhp?=
 =?utf-8?B?WE1oRy9jd3RrQ3FDUlIyZktDZG9jdStVcVN2TE5aZ1pzeitIK1luYnBrUDdN?=
 =?utf-8?B?ZU9pKzdJbWQ0d2ZEd0Y2YTNJWGNlblJ1dVBXZXEydHR5Tzl5TEI5SlBUaGlK?=
 =?utf-8?B?OGsycXlNUTF6SmdhTTQrWUpPc1FHRFVQTE9VMWh1TjNqeG83UUJIdXVKVjVX?=
 =?utf-8?Q?LugZjQ0C3TOafhuIq87Mph0L4?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: bf04b4ef-1931-4802-a580-08db6abf7945
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2023 21:04:41.0694
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5HHqHv13fG7gqgswxJj41i+TLfpY+w6C83Ww8lBA/sPfp22EtxnxvsQGR1+r9WnB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR02MB8429
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

2023-06-11 at 22:59, Randy Dunlap wrote:
> On 5/24/23 05:52, Peter Rosin wrote:
>> REGMAP is normally "selected", but that causes a recursive dependency.
>> But since REGMAP is "depended on" in other places, do so here as well.
>> The (implicit) REGMAP dependency was lost when the strict dependency
>> on MFD_SYSCON was removed.

*snip*

>> diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig
>> index 80f015cf6e54..7f07ca06eb2b 100644
>> --- a/drivers/mux/Kconfig
>> +++ b/drivers/mux/Kconfig
>> @@ -48,6 +48,7 @@ config MUX_GPIO
>>  config MUX_MMIO
>>  	tristate "MMIO/Regmap register bitfield-controlled Multiplexer"
>>  	depends on OF
>> +	depends on REGMAP
> 
> REGMAP is mostly selected, not depended on, so preferably
> 
> 	select REGMAP
> 
> here whenever this patch is ready to be merged.

I would have preferred that as well, and if that was without problems I
would not be so hesitant as there are really few pre-existing "depends
on REGMAP".

I do not know what to do here and am not sure whom to ask for guidance.

Cheers,
Peter