Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6a72d06d-4570-864c-ee3f-12edd9458f03@huawei.com>
Date:   Mon, 12 Jun 2023 09:08:44 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] mm: kill [add|del]_page_to_lru_list()
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>
CC:     Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <20230609013901.79250-1-wangkefeng.wang@huawei.com>
 <ZINe7xJPI3s6HJG4@casper.infradead.org>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <ZINe7xJPI3s6HJG4@casper.infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/6/10 1:18, Matthew Wilcox wrote:
> On Fri, Jun 09, 2023 at 09:39:01AM +0800, Kefeng Wang wrote:
>> Directly call lruvec_del_folio(), and drop unused page interfaces.
> 
> Convert isolate_migratepages_block() to actually use folios and
> then we can kill the interfaces.
> 
>> +++ b/mm/compaction.c
>> @@ -1145,7 +1145,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
>>   			low_pfn += compound_nr(page) - 1;
>>   
>>   		/* Successfully isolated */
>> -		del_page_from_lru_list(page, lruvec);
>> +		lruvec_del_folio(lruvec, page_folio(page));
> 
> This kind of thing is not encouraged.  It's just churn and gets in
> the way of actual conversions.

Sure, thanks for your suggestion, will convert 
isolate_migratepages_block() firstly.
>