Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <51dfdee66713e470d9a925ac5a8f8ae1da644462.camel@linux.intel.com>
Subject: Re: [PATCH] HID: sensor-hub: Allow multi-function sensor devices
From:   srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To:     Jiri Kosina <jikos@kernel.org>,
        Daniel Thompson <daniel.thompson@linaro.org>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Bjorn Andersson <andersson@kernel.org>,
        linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Sun, 11 Jun 2023 21:53:51 -0700
In-Reply-To: <nycvar.YFH.7.76.2306091742090.5716@cbobk.fhfr.pm>
References: <20230528092427.42332-1-daniel.thompson@linaro.org>
         <nycvar.YFH.7.76.2306091742090.5716@cbobk.fhfr.pm>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2023-06-09 at 17:43 +0200, Jiri Kosina wrote:
> On Sun, 28 May 2023, Daniel Thompson wrote:
> 
> > The Lenovo Yoga C630 has a combined keyboard and accelerometer that
> > interfaces via i2c-hid. Currently this laptop either has a working
> > keyboard (if CONFIG_HID_SENSOR_HUB is disabled) or a working
> > accelerometer.
> > only works on kernels. Put another way, most distro kernels enable
> > CONFIG_HID_SENSOR_HUB and therefore cannot work on this device
> > since the
> > keyboard doesn't work!
> > 
> > Fix this by providing a richer connect mask during the probe. With
> > this
> > change both keyboard and screen orientation sensors work correctly.
> > 
> > Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> 
> Srinivas, are you aware of any multi-function device that this patch
> might 
> break?
I tried two systems, one with ISH and another with external hub.
Didn't break anything.
I don't have 5+ years old systems, to confirm if it will break
something on older systems with external hub.

Thanks,
Srinivas

> 
> Thanks,
>