Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Steve French <sfrench@samba.org>,
        Paulo Alcantara <pc@manguebit.com>,
        Ronnie Sahlberg <lsahlber@redhat.com>,
        Shyam Prasad N <sprasad@microsoft.com>,
        Tom Talpey <tom@talpey.com>,
        linux-cifs@vger.kernel.org (open list:COMMON INTERNET FILE SYSTEM
        CLIENT (CIFS and SMB3)),
        samba-technical@lists.samba.org (moderated list:COMMON INTERNET FILE
        SYSTEM CLIENT (CIFS and SMB3)),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] fs: smb: client: Replace the ternary conditional operator
Date:   Mon, 12 Jun 2023 13:21:23 +0800
Message-Id: <20230612052123.2775-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6CWcg9jcy5nKkBk8O1JMfhWo5oOhUc1f/8LgIMODfI3TsmOkSQgjMZQd7x98?=
 =?us-ascii?Q?E++W1g3ozVyJppzii+MmSTqP1aU9OKPrqIZt/YI4tKJ0ghohkdb0llRIxnAm?=
 =?us-ascii?Q?kI1rVPunFcr90yEF1DSSO/jrkjkkZAcrN3B1JXsS2PfpQLy5AgUkT2+mjP/0?=
 =?us-ascii?Q?Ls8Y5OghufctqU/xdpSqavJnf1knY8it3b12mX/T34Tx0ToZ8x86P3sEEFbg?=
 =?us-ascii?Q?h9Lq0vBh14BCCkPbnIiL9d6XnuxPpHL1z0HyIyS1LfRWbcrqC4+jvQ1oSoa/?=
 =?us-ascii?Q?neD9tLrUJwVxNxe2YN2ig3Z2aOAOYerB/EAvYvqA19LPzWZbfKR0seltWeL9?=
 =?us-ascii?Q?6hhVdx7DMwOvRcZYO39nLQPmLY3ZpzAX8/Uu+04XWe/rk40Vp4m0jsvwB4lc?=
 =?us-ascii?Q?KCH0cZy6De2zv0E2OG8YDd5tHgyerqg9LJ5kuhcfb5gHgW5u6lPAc2ZwrbtU?=
 =?us-ascii?Q?HEHqvveUoG4IvuwH1Dpn1v0rDUzWWZ63zeLpTvBiBGOP4Dbnqsb6+2Ruet6X?=
 =?us-ascii?Q?iFsBXmAmrWZCiz75wYXhHB2RnISNC+rIHNQDY77KVfaBRnyCf4nKvpwTbTAU?=
 =?us-ascii?Q?D2PDbAaqBoEdnwIOFD7+rlQPpuwOVelo6aSSMaHd8zcmStXhrvN+BB40EBZQ?=
 =?us-ascii?Q?JYbBXF+mfT3ULsbfry3giTIoCnAO1gSpoohhGv6d9BrRuNZ4tPL13JfLjOW+?=
 =?us-ascii?Q?XlRrLq/DhFpRlS+GuhplXFdpGTUslAWOachl+H/ABxpE2S2si1K0Oeg9UXwz?=
 =?us-ascii?Q?zwchWPSdvAf93mEWx2WaDdmNjUMPZAyo2BTpiR/lNZV4OISsSB8xz1rsoSRc?=
 =?us-ascii?Q?Pd8s6ZAgygT5NqhdMT52tyNCd2zAt7OZjZ1OE80YHoDrI2AdQDMnqV2utw53?=
 =?us-ascii?Q?lIxNyfD4YVu5QBnRDwUE5mFd/Krym3FDBD8pbJ5SZ6hACKmVnVGFo86iPM0T?=
 =?us-ascii?Q?cRjzGBe/OUtKw39SPswEokEMHKI48lH2Vx7jNkAicIml4fGhQLQ71cFbQ/9+?=
 =?us-ascii?Q?1Up5AvTkG/QoB+VbvZBQzA7T8lCgsfGGod1dgILGDyE1ezs2dcCOi3LzFyr0?=
 =?us-ascii?Q?3LphVa1xvivI5dziP3xPalr5XIfJ5epOA2jzIXnt3UWPoAlEtpyFHrIl4+2H?=
 =?us-ascii?Q?OPexghH3KIvtdi5Zv0PGqmYystKIMnugdNZ8/Lf7MLhtYJNcpFSE/9dCbdHR?=
 =?us-ascii?Q?wRKVwGAFlrF2zvEjNokFyYa+wNSxAf67cXU58kPZsRsv2PxvljTzGoc216Vz?=
 =?us-ascii?Q?MRF6y5Yxwni+5ptbBP9ib3DCoViuEq12IJuIjfkITJQpZTc2BSB8XRNgUwtr?=
 =?us-ascii?Q?tpSLTfvazyoPbMXqdDThaWFX7BYQ4+B04c/FpdQ6Eyd1Isoor4puGdU+qFcB?=
 =?us-ascii?Q?J4qZJ5rI2wbtsCuiFg4f1wq2j8S4BFaeKbnZwkP9wOL+GOtOJoIRqjBZr28L?=
 =?us-ascii?Q?ZpnQaAtONOc0H8upAkTXCBfcja5c2Pox8ipg5Aa6Nz1MT9aqVpX/akaiO5zL?=
 =?us-ascii?Q?/IEMxJK7snxtp7rRPKgRRGxt44gQSkKLRZHm0pQfKY5pSUVP/b5juaU1ACUI?=
 =?us-ascii?Q?VhYbJXir5A3FbrXMfEwS0BYiWPQHj+v6/DroytHi?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5c7807c-f047-449f-6508-08db6b04e2dd
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 05:21:33.7466
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y+2y2hclpQCWfatWy/CJrEnnG9WYwYEeXRlzGBbJYub3qG9zZN2Az9Xoj/cp1Be7UhO28ggRuaF+ybCltMkWww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6468
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It would be better to replace the traditional ternary conditional
operator with min() in _smbd_get_connection

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 fs/smb/client/smbdirect.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/smb/client/smbdirect.c b/fs/smb/client/smbdirect.c
index 2a2aec8c6112..69f9023f89f9
--- a/fs/smb/client/smbdirect.c
+++ b/fs/smb/client/smbdirect.c
@@ -1582,10 +1582,7 @@ static struct smbd_connection *_smbd_get_connection(
 	conn_param.initiator_depth = 0;
 
 	conn_param.responder_resources =
-		info->id->device->attrs.max_qp_rd_atom
-			< SMBD_CM_RESPONDER_RESOURCES ?
-		info->id->device->attrs.max_qp_rd_atom :
-		SMBD_CM_RESPONDER_RESOURCES;
+		min(info->id->device->attrs.max_qp_rd_atom, SMBD_CM_RESPONDER_RESOURCES);
 	info->responder_resources = conn_param.responder_resources;
 	log_rdma_mr(INFO, "responder_resources=%d\n",
 		info->responder_resources);
-- 
2.39.0