Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net-next] ice: Remove managed memory
 usage in ice_get_fw_log_cfg()
Thread-Topic: [Intel-wired-lan] [PATCH net-next] ice: Remove managed memory
 usage in ice_get_fw_log_cfg()
Thread-Index: AQHZnKWNlFlxLTGfqEadQfmxPjZs6a+GoRjQ
Date:   Mon, 12 Jun 2023 05:18:01 +0000
Message-ID: <CO1PR11MB5089E9E4E21793B60112011BD654A@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <e86a1ab7b450462a1e92264dccb5a5855546e384.1686516193.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <e86a1ab7b450462a1e92264dccb5a5855546e384.1686516193.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tOqCX54TPfrTXlKdIU2iIFS+/4HtQ4pnhVCy8N5lxwlXBE4eCPAgTzdyoyES?=
 =?us-ascii?Q?QaWHRlgU9svvGUJ0I7QFBHXtN2wI6W5ZTRyv6SkbyjyL4xpa2Y8vaW/oN5In?=
 =?us-ascii?Q?Oy0Z0Ly4u4HSJHhHcPZjoUE2liiLpdm/mbUgTDAT11TsYiagWpuD1hTBSGxO?=
 =?us-ascii?Q?IlWA1Xz7Znxe75IIn8Ig4/2a2pMslSFOjsOooGjyl2smNnufc30D8MAspS2J?=
 =?us-ascii?Q?80baqw+NtEKGdp8TK2IWPRoQjr0i78IolVT7NluXSmA2GK64GvH/MzYbWoeK?=
 =?us-ascii?Q?6VPaok0RNv9GeCtnwvB6nYiRWjBd8dWOC7XFiM/CDldhIx+y2vMvXSI89Vhq?=
 =?us-ascii?Q?OeY3if+LoX0lMGiyA/nacdfWBJZEVK4C9i1NuUTfdEwpc+AsLs/JsehSvIca?=
 =?us-ascii?Q?AZ6GBulu8mY2bveYjsiK3NuCypw8RtKrecv2iVj76sny29g51I+AKrP2AHZt?=
 =?us-ascii?Q?C3sN1+RJMVDXErW/6mFGgfDW2QNJQ3DSzuX9+VA+7CR59D6WeSb5gBzoTQI3?=
 =?us-ascii?Q?71dp0eYFzMpIbRWdA+lGO1F4MELTEE6uziRZ0ZaAdaExJAHEEuQf1QOMXig5?=
 =?us-ascii?Q?U4WUaSu/8BcOIF7mjJ7zBkQAwuU9L61EA11BMYFJFuYtliIPskP9kZ5QJjqY?=
 =?us-ascii?Q?phpTH2Yy2Dv357r2xxX0ZtYO6p+e/ElFuC7WMte4HpIiXW4rnZVTuIloCX6q?=
 =?us-ascii?Q?RGfFELwMYr3uy1EoXPJmGjQNE1cNOhuF4weolyfSJcM2vaAeE6J//4VfK8iO?=
 =?us-ascii?Q?2NGGd2wQMoz4CNaF0xFuUkc6Yg0+OpjFPCpFU56I2U2t2ZTxp/oi0AcVx0s3?=
 =?us-ascii?Q?AsQC8+k0byfUoeER1cdrnZyPEk1amqaOvkfBSQ1Jh28afc6H//hyNyREx+OE?=
 =?us-ascii?Q?3B9rqLJrCa76cbRT0xwohh4nAgov2PVKGlqsrCOaZ+LudV/vd+UE6qmvdkXG?=
 =?us-ascii?Q?i65mf+cTTrZT/DHhNoqIm7pl1M23jx9UREQFagBMPl2e520Jnkh1XqxPI+C1?=
 =?us-ascii?Q?NXJMR4lnvmlivIVdBnrpCyXGgr4fnARyRv9fmOPfAOgvb9iRn8nzSPxne4Qt?=
 =?us-ascii?Q?rchMPgGjIlZ42RgjB9XeYInz9y13sHwb2uBH7tXp2fnIW7ruETNqBFhjF+U6?=
 =?us-ascii?Q?lm0PtLvkUpRC3SA8WxoSGMYdXnSQjKODux7eTJzd9YmSG0UChGor9YC6q8n6?=
 =?us-ascii?Q?REqvECKb9pFL44yWocSGLQ3jCyxgIbBSYLOviyxS6Qi/YQ7XdEJh2e4Zc/qw?=
 =?us-ascii?Q?v1ILWuE2+G4/OVQT+vDC/k3ABNmkJnMJW/MHlONP5Dl+njFW3oOvLdE+Y9x5?=
 =?us-ascii?Q?OV/Z1pqPRHYFMdUp3t3SKbHINyOZStpEsWWZUHHXUX0V32YXbNQZzxH2zAlV?=
 =?us-ascii?Q?qMjhSZWxYa/aZg4fikD4k0kVPUx/g4xmT0TL3zgYOnjUWLhqAXm7yEQwft09?=
 =?us-ascii?Q?SoMe5ta/unypsJ5oiVYlIZczUy4PPvp1afRRpVqBsJNE+a9iRd1NhThatu0z?=
 =?us-ascii?Q?LXNeuFYLAXItItn9KMg2FbyDEGyp9DrxBxHRk5MjgTqu4pPYU2Zz2Y1ELb5C?=
 =?us-ascii?Q?fct1NZQ8ZYh+FIK9vATfTLs2Sh+/puw35QF0eBsz?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a04fbf1-2c68-4e9e-50c3-08db6b046493
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2023 05:18:01.4129
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L4izGWAjUdpHOwNr3Zg5Eldg5iQlWctPKSw6eXvSKMmLySY/qDdgQ0z8Eo720h4qyyaoxR1mhw2S0DbmkuqY+44bv6C6hdrHURzUEk28uAQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5597
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Christophe JAILLET
> Sent: Sunday, June 11, 2023 1:44 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>
> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>; intel-wired-
> lan@lists.osuosl.org; kernel-janitors@vger.kernel.org; linux-
> kernel@vger.kernel.org; netdev@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next] ice: Remove managed memory us=
age
> in ice_get_fw_log_cfg()
>=20
> There is no need to use managed memory allocation here. The memory is
> released at the end of the function.
>=20
> You kzalloc()/kfree() to simplify the code.
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Agreed.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  drivers/net/ethernet/intel/ice/ice_common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c
> b/drivers/net/ethernet/intel/ice/ice_common.c
> index eb2dc0983776..4b799a5d378a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_common.c
> +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> @@ -834,7 +834,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
>  	u16 size;
>=20
>  	size =3D sizeof(*config) * ICE_AQC_FW_LOG_ID_MAX;
> -	config =3D devm_kzalloc(ice_hw_to_dev(hw), size, GFP_KERNEL);
> +	config =3D kzalloc(size, GFP_KERNEL);
>  	if (!config)
>  		return -ENOMEM;
>=20
> @@ -857,7 +857,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
>  		}
>  	}
>=20
> -	devm_kfree(ice_hw_to_dev(hw), config);
> +	kfree(config);
>=20
>  	return status;
>  }
> --
> 2.34.1
>=20
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan