Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1685947150-4949-1-git-send-email-yangtiezhu@loongson.cn> <CAAhV-H5CXX+tVdXj8jpYjeprwFihDJw6O6K5t6dRZPH8bWZ94A@mail.gmail.com>
In-Reply-To: <CAAhV-H5CXX+tVdXj8jpYjeprwFihDJw6O6K5t6dRZPH8bWZ94A@mail.gmail.com>
From:   Jeff Xie <xiehuan09@gmail.com>
Date:   Mon, 12 Jun 2023 15:41:40 +0800
Message-ID: <CAEr6+EA9OCRANk+kVov=jZmrbxAV_vVhLV-F+5v7P7dYM2g7PQ@mail.gmail.com>
Subject: Re: [PATCH v5 0/6] Add uprobes support for LoongArch
To:     Huacai Chen <chenhuacai@kernel.org>
Cc:     Tiezhu Yang <yangtiezhu@loongson.cn>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 7, 2023 at 4:52=E2=80=AFPM Huacai Chen <chenhuacai@kernel.org> =
wrote:
>
> Hi, Jeff,
>
> I queued this series at
> https://github.com/chenhuacai/linux/commits/loongarch-next, could you
> please test it when you have time? Thanks.

I have tested this series and saw no errors while using uprobe, the
patchset looks good to me.

Tested-by: Jeff Xie <xiehuan09@gmail.com>

>
> Huacai
>
> On Mon, Jun 5, 2023 at 2:39=E2=80=AFPM Tiezhu Yang <yangtiezhu@loongson.c=
n> wrote:
> >
> > v5:
> >   -- Rebased on 6.4rc5
> >   -- Like arm64, add user_enable_single_step() in arch_uprobe_pre_xol()=
,
> >      add user_disable_single_step() in arch_uprobe_{post,abort}_xol(),
> >      suggested by Jeff and Huacai offline
> >
> > v4:
> >   -- Rebased on 6.4rc1
> >   -- Fix problem about "perf probe -x /lib64/libc.so.6 malloc"
> >
> > v3:
> >   -- Check atomic instructions in insns_not_supported()
> >   -- Remove five DIE_* definitions in kdebug.h
> >
> > v2:
> >   -- Move the functions to inst.c in patch #1
> >   -- Pass around union for insns_not_supported(),
> >      insns_need_simulation() and arch_simulate_insn()
> >
> > v1:
> >   -- Split the RFC patch #2 into two patches
> >   -- Use larch_insn_gen_break() to generate break insns
> >      for kprobes and uprobes
> >   -- Pass around instruction word instead of union for
> >      insns_not_supported(), insns_need_simulation() and
> >      arch_simulate_insn() to avoid type conversion for callers
> >   -- Add a simple test case for uprobes in the commit message
> >
> > Tiezhu Yang (6):
> >   LoongArch: Move three functions from kprobes.c to inst.c
> >   LoongArch: Add larch_insn_gen_break() to generate break insns
> >   LoongArch: Use larch_insn_gen_break() for kprobes
> >   LoongArch: Add uprobes support
> >   LoongArch: Check atomic instructions in insns_not_supported()
> >   LoongArch: Remove five DIE_* definitions in kdebug.h
> >
> >  arch/loongarch/Kconfig               |   3 +
> >  arch/loongarch/include/asm/inst.h    |  42 ++++++++++
> >  arch/loongarch/include/asm/kdebug.h  |   5 --
> >  arch/loongarch/include/asm/kprobes.h |   2 +-
> >  arch/loongarch/include/asm/uprobes.h |  35 ++++++++
> >  arch/loongarch/kernel/Makefile       |   1 +
> >  arch/loongarch/kernel/inst.c         |  54 +++++++++++++
> >  arch/loongarch/kernel/kprobes.c      |  75 ++++-------------
> >  arch/loongarch/kernel/traps.c        |   9 +--
> >  arch/loongarch/kernel/uprobes.c      | 152 +++++++++++++++++++++++++++=
++++++++
> >  10 files changed, 306 insertions(+), 72 deletions(-)
> >  create mode 100644 arch/loongarch/include/asm/uprobes.h
> >  create mode 100644 arch/loongarch/kernel/uprobes.c
> >
> > --
> > 2.1.0
> >


--=20
Thanks,
JeffXie