Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Jun 2023 09:39:10 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
cc:     Daniel Thompson <daniel.thompson@linaro.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Bjorn Andersson <andersson@kernel.org>,
        linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: sensor-hub: Allow multi-function sensor devices
In-Reply-To: <51dfdee66713e470d9a925ac5a8f8ae1da644462.camel@linux.intel.com>
Message-ID: <nycvar.YFH.7.76.2306120938360.5716@cbobk.fhfr.pm>
References: <20230528092427.42332-1-daniel.thompson@linaro.org>  <nycvar.YFH.7.76.2306091742090.5716@cbobk.fhfr.pm> <51dfdee66713e470d9a925ac5a8f8ae1da644462.camel@linux.intel.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 11 Jun 2023, srinivas pandruvada wrote:

> > > The Lenovo Yoga C630 has a combined keyboard and accelerometer that 
> > > interfaces via i2c-hid. Currently this laptop either has a working 
> > > keyboard (if CONFIG_HID_SENSOR_HUB is disabled) or a working 
> > > accelerometer. only works on kernels. Put another way, most distro 
> > > kernels enable CONFIG_HID_SENSOR_HUB and therefore cannot work on 
> > > this device since the keyboard doesn't work!
> > > 
> > > Fix this by providing a richer connect mask during the probe. With 
> > > this change both keyboard and screen orientation sensors work 
> > > correctly.
> > > 
> > > Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> > 
> > Srinivas, are you aware of any multi-function device that this patch 
> > might break?
> I tried two systems, one with ISH and another with external hub. Didn't 
> break anything. I don't have 5+ years old systems, to confirm if it will 
> break something on older systems with external hub.

Thanks a lot. Can I take the above as an equivalent of

	Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

? :)

-- 
Jiri Kosina
SUSE Labs